Re: [Django] #26219: Cannot filter by DecimalField in RawQuery

[Django]

#26219: Cannot filter by DecimalField in RawQuery
-+-
 Reporter:  jirek|Owner:  akki
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  DecimalField | Triage Stage:  Accepted
  RawQuery   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"0d2b97ca18b576d1bbff2ccb089527e36d99eaf9" 0d2b97ca]:
 {{{
 #!CommitTicketReference repository=""
 revision="0d2b97ca18b576d1bbff2ccb089527e36d99eaf9"
 [1.9.x] Fixed #26219 -- Fixed crash when filtering by Decimal in RawQuery.

 Backport of fdccc02576ae5a524338f65e629948604d80b4c8 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.68a1a11d6514b32467b870dabe2cc160%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26219: Cannot filter by DecimalField in RawQuery

[Django]

#26219: Cannot filter by DecimalField in RawQuery
-+-
 Reporter:  jirek|Owner:  akki
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  DecimalField | Triage Stage:  Accepted
  RawQuery   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"fdccc02576ae5a524338f65e629948604d80b4c8" fdccc025]:
 {{{
 #!CommitTicketReference repository=""
 revision="fdccc02576ae5a524338f65e629948604d80b4c8"
 Fixed #26219 -- Fixed crash when filtering by Decimal in RawQuery.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.44ef556777d2dd0232ae0dc550946e80%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26219: Cannot filter by DecimalField in RawQuery

[Django]

#26219: Cannot filter by DecimalField in RawQuery
-+-
 Reporter:  jirek|Owner:  akki
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  DecimalField | Triage Stage:  Accepted
  RawQuery   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by akki):

 * has_patch:  0 => 1


Comment:

 PR: https://github.com/django/django/pull/6150

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.db6f610b314110d8353c9df9903c2362%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26219: Cannot filter by DecimalField in RawQuery

[Django]

#26219: Cannot filter by DecimalField in RawQuery
-+-
 Reporter:  jirek|Owner:  akki
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  DecimalField | Triage Stage:  Accepted
  RawQuery   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by akki):

 * owner:  nobody => akki
 * status:  new => assigned
 * has_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.75d1c9d334957a7d5e6b0e3a666e5662%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26219: Cannot filter by DecimalField in RawQuery

[Django]

#26219: Cannot filter by DecimalField in RawQuery
-+-
 Reporter:  jirek|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  DecimalField | Triage Stage:  Accepted
  RawQuery   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by charettes):

 * easy:  0 => 1


Comment:

 Marking as ''easy picking'' since a test can easily be written from the
 report.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.2d929ed4d48c268647890cc90b24ce65%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26219: Cannot filter by DecimalField in RawQuery

[Django]

#26219: Cannot filter by DecimalField in RawQuery
-+-
 Reporter:  jirek|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  DecimalField | Triage Stage:  Accepted
  RawQuery   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_tests:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.7db135f874ecd8e8a11880d0fb35be19%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26219: Cannot filter by DecimalField in RawQuery

[Django]

#26219: Cannot filter by DecimalField in RawQuery
-+-
 Reporter:  jirek|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  DecimalField | Triage Stage:  Accepted
  RawQuery   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by charettes):

 * has_patch:  0 => 1
 * severity:  Normal => Release blocker


Comment:

 Ahh we did a bit of concurrent research!

 This is regression introduced by d9521f66b1851b0eacd55bc78f801dc64123e333
 in 1.9+.

 The proposed patch is what I also had in mind.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.ab02c3d41a607d53468648a817732b03%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26219: Cannot filter by DecimalField in RawQuery

[Django]

#26219: Cannot filter by DecimalField in RawQuery
-+-
 Reporter:  jirek|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  DecimalField | Triage Stage:  Accepted
  RawQuery   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by jarshwah):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 Yep, this is indeed a bug. The following patch seems to fix the problem,
 but I haven't run the test suite to verify no bad behaviour is introduced.
 This is probably a regression introduced in 1.8 (I think). I remember
 modifying this code around then.

 {{{
 diff --git a/django/db/backends/base/operations.py
 b/django/db/backends/base/operations.py
 index 7957265..10641bf 100644
 --- a/django/db/backends/base/operations.py
 +++ b/django/db/backends/base/operations.py
 @@ -485,7 +485,7 @@ class BaseDatabaseOperations(object):
  raise ValueError("Django does not support timezone-aware
 times.")
  return six.text_type(value)

 -def adapt_decimalfield_value(self, value, max_digits,
 decimal_places):
 +def adapt_decimalfield_value(self, value, max_digits=None,
 decimal_places=None):
  """
  Transforms a decimal.Decimal value to an object compatible with
 what is
  expected by the backend driver for decimal (numeric) columns.

 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.33828526091d2de818ea7a98add070b9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.