Re: [Django] #26572: AdminEmailHandler fails to honor subject length limit

[Django]

#26572: AdminEmailHandler fails to honor subject length limit
-+
 Reporter:  pdewacht |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Mail)  |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by timgraham):

 I'm inclined to say that applications like django-post-office should take
 care of truncating data as they see fit rather than Django making some
 arbitrary choice about it.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9123d54cd68344d2c12530d914631c2c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26572: AdminEmailHandler fails to honor subject length limit

[Django]

#26572: AdminEmailHandler fails to honor subject length limit
-+
 Reporter:  pdewacht |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Mail)  |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by claudep):

 An alternative would be to truncate at a much shorter length, 120 chars
 comes to mind. Would that risk of stripping valuable data? Should we then
 repeat the record message in the body of the message?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a091a603db0b3cf424be7dc86720ee64%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26572: AdminEmailHandler fails to honor subject length limit

[Django]

#26572: AdminEmailHandler fails to honor subject length limit
-+
 Reporter:  pdewacht |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Mail)  |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by pdewacht):

 We're using django-post-office as email backend. It stores the messages in
 a database table and tries to put the subject in a varchar(989). That blew
 up when we had a log message that was unexpectedly long.

 Personally I prefer truncating over line wrapping -- multiline subject
 headers seem esoteric even if it's true that it's technically allowed. I
 fear it will cause interoperability problems (see e.g. django-post-office
 breaking).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.486f966a8345e41fd2ca3b1e19d1d0f2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26572: AdminEmailHandler fails to honor subject length limit

[Django]

#26572: AdminEmailHandler fails to honor subject length limit
-+
 Reporter:  pdewacht |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Mail)  |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by claudep):

 * needs_better_patch:  1 => 0


Comment:

 The [https://github.com/django/django/pull/6551 new PR].

 pdewacht, what was your issue with subject line length?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a2fff4a201d53f9a767de73dd69a3813%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26572: AdminEmailHandler fails to honor subject length limit

[Django]

#26572: AdminEmailHandler fails to honor subject length limit
-+
 Reporter:  pdewacht |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Mail)  |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by claudep):

 * needs_better_patch:  0 => 1


Comment:

 After some more consideration, I discovered that headers are not limited
 in total length by the spec, only individual lines are. Read
 https://tools.ietf.org/html/rfc5322#section-2.1.3: `An unfolded header
 field has no length restriction and therefore may be indeterminately
 long.`.
 Then Python is automatically folding headers when sending messages, by
 default to 78 characters. So now I think that the subject line truncation
 is simply wrong. Of course, it's not nice to receive very long headers,
 but we have no reason to truncate subject or any other header.
 We might even question the refusal to accept newlines in headers, but that
 would be the subject of a separate ticket.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8314f12cfd58e73bd2333127e032416d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26572: AdminEmailHandler fails to honor subject length limit

[Django]

#26572: AdminEmailHandler fails to honor subject length limit
-+
 Reporter:  pdewacht |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Mail)  |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by claudep):

 * has_patch:  0 => 1


Comment:

 I tried the "lower level" technique in
 [https://github.com/django/django/pull/6550 that PR].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a7f6dfaa534c0b188ac5aa9d76a4bf52%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26572: AdminEmailHandler fails to honor subject length limit

[Django]

#26572: AdminEmailHandler fails to honor subject length limit
-+
 Reporter:  pdewacht |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Mail)  |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by claudep):

 * needs_better_patch:   => 0
 * component:  Uncategorized => Core (Mail)
 * needs_tests:   => 0
 * needs_docs:   => 0
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1dc2f45982a2572f0c000a092f8ed8e6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.