Re: [Django] #26702: Document custom field subclass change requires new custom field class

[Django]

#26702: Document custom field subclass change requires new custom field class
-+-
 Reporter:  baylee   |Owner:  baylee
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.9
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"4765769b76c07f074a915655503d29028d50c122" 4765769b]:
 {{{
 #!CommitTicketReference repository=""
 revision="4765769b76c07f074a915655503d29028d50c122"
 [1.9.x] Fixed #26702 -- Documented how to change the base class of a
 custom field.

 Backport of 7767978beec6098baea75d50a191a3b8224e729f from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e5847a57d351707d6df85a7df3bc9f66%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26702: Document custom field subclass change requires new custom field class

[Django]

#26702: Document custom field subclass change requires new custom field class
-+-
 Reporter:  baylee   |Owner:  baylee
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.9
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"5e46075fcf5dce3a846d208ab39e7f7aed7f70eb" 5e46075]:
 {{{
 #!CommitTicketReference repository=""
 revision="5e46075fcf5dce3a846d208ab39e7f7aed7f70eb"
 [1.10.x] Fixed #26702 -- Documented how to change the base class of a
 custom field.

 Backport of 7767978beec6098baea75d50a191a3b8224e729f from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.f4fa0e6edbc583b27c868d62b810f1db%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26702: Document custom field subclass change requires new custom field class

[Django]

#26702: Document custom field subclass change requires new custom field class
-+-
 Reporter:  baylee   |Owner:  baylee
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.9
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7767978beec6098baea75d50a191a3b8224e729f" 7767978b]:
 {{{
 #!CommitTicketReference repository=""
 revision="7767978beec6098baea75d50a191a3b8224e729f"
 Fixed #26702 -- Documented how to change the base class of a custom field.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d05880027ea9934f21819a96b30eff57%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26702: Document custom field subclass change requires new custom field class

[Django]

#26702: Document custom field subclass change requires new custom field class
-+-
 Reporter:  baylee   |Owner:  baylee
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.9
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  1
-+-
Changes (by heindshed):

 * cc: heindshed (added)
 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * easy:  0 => 1
 * needs_docs:  0 => 1
 * ui_ux:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d802c6cf41af7e28ee66c96cdad3fd7b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26702: Document custom field subclass change requires new custom field class

[Django]

#26702: Document custom field subclass change requires new custom field class
-+-
 Reporter:  baylee   |Owner:  baylee
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.9
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by heindshed):

 * status:  assigned => closed
 * resolution:   => fixed


Old description:

> Related to #26586
>
> Can't alter a custom field to have a different base field type.
> Documentation should be updated to reflect this and proposed solution.
>
> Example before state:
> {{{
> class CustomCharField(models.CharField):
> def foo(self):
> pass
>
> class Author(models.Model):
> name = CustomCharField(max_length=255)
> }}}
>
> Example of what won't work:
> {{{
> class CustomCharField(models.TextField):
> def foo(self):
> pass
>
> class Author(models.Model):
> name = CustomCharField(max_length=255)
> }}}
>
> Example of what you should change to:
> {{{
> class CustomFieldMixin(object):
> def foo(self):
> pass
>
> class CustomCharField(CustomFieldMixin, models.CharField):
> pass
>
> class CustomTextField(CustomFieldMixin, models.TextField):
> pass
>
> class Author(models.Model):
> name = CustomTextField(max_length=255)
> }}}
>
> Should also include link to:
> https://docs.djangoproject.com/en/1.9/topics/migrations/#considerations-
> when-removing-model-fields to explain why user must keep old field
> definition around.

New description:

 McÅfË€ JUST CALL NOW  zoho phone number 1-888-633-5526  Email tech
 1-888-633-5526 nical Support Customer Phone Number
 zoho phone number  1-888-633-5526  mail tech 1-888-633-5526  support
  zoho phone number  1-888-633-5526  customer service number
  zoho phone number  1-888-633-5526  mail tech 1-888-633-5526  support
 telephone number
  zoho phone number  1-888-633-5526  email Helpline Number
  zoho phone number  1-888-633-5526  mail customer support
  zoho phone number  1-888-633-5526  mail toll free support number
  zoho phone number  1-888-633-5526  email customer service phone number
 tech 1-888-633-5526  support numbers for  zoho phone number
 1-888-633-5526  email
  zoho phone number  1-888-633-5526  email customer support number
  zoho phone number  1-888-633-5526  email tech 1-888-633-5526 nical
 support number
  zoho phone number  1-888-633-5526  email support telephone number
  zoho phone number  1-888-633-5526  email tech 1-888-633-5526 nical
 support phone number
  zoho phone number  1-888-633-5526  mail customer support numbers
  zoho phone number  1-888-633-5526  email support number
  zoho phone number  1-888-633-5526  email customer support phone number
 usa
  zoho phone number  1-888-633-5526  email tech 1-888-633-5526  support
 phone number
  zoho phone number  1-888-633-5526  email phone tech 1-888-633-5526
 support
  zoho phone number  1-888-633-5526  email tech 1-888-633-5526  support
 phone numbers
  zoho phone number  1-888-633-5526  email free tech 1-888-633-5526
 support phone number
  zoho phone number  1-888-633-5526  email live mail tech 1-888-633-5526
 support
  zoho phone number  1-888-633-5526  email live tech 1-888-633-5526
 support
  zoho phone number  1-888-633-5526  email live chat tech 1-888-633-5526
 support
  zoho phone number  1-888-633-5526  email tech 1-888-633-5526  support
 live
  zoho phone number  1-888-633-5526  email live support
  zoho phone number  1-888-633-5526  email live customer support
  zoho phone number  1-888-633-5526  mail free customer service number usa
  zoho phone number  1-888-633-5526  email tech 1-888-633-5526 nical
 support
  zoho phone number  1-888-633-5526  email support usa
  zoho phone number  1-888-633-5526  email helpdesk number
  zoho phone number  1-888-633-5526  email tech 1-888-633-5526  support
 helpdesk number
  zoho phone number  1-888-633-5526  email helpdesk contact number
  zoho phone number  1-888-633-5526  email tech 1-888-633-5526  support
 services
  zoho phone number  1-888-633-5526  email customer support service
  zoho phone number  1-888-633-5526  email customer support services usa
  zoho phone number  1-888-633-5526  email toll free service
  zoho phone number  1-888-633-5526  email toll free customer service
  zoho phone number  1-888-633-5526  email customer service desk
  zoho phone number  1-888-633-5526  email help desk services
  zoho pho

Re: [Django] #26702: Document custom field subclass change requires new custom field class

[Django]

#26702: Document custom field subclass change requires new custom field class
-+-
 Reporter:  baylee   |Owner:  baylee
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by phildini):

 * stage:  Accepted => Ready for checkin


Comment:

 This doc patch is clear and concise, doesn't cover anything extraneous,
 and seems to meet all the docs guidelines.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7f46460565fbfbd39ff295f7f99ac191%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26702: Document custom field subclass change requires new custom field class

[Django]

#26702: Document custom field subclass change requires new custom field class
--+
 Reporter:  baylee|Owner:  baylee
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.46716e080b58199f639a998d3b163a29%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26702: Document custom field subclass change requires new custom field class

[Django]

#26702: Document custom field subclass change requires new custom field class
--+
 Reporter:  baylee|Owner:  baylee
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by baylee):

 That makes sense. I've updated the PR to use a simplified example.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.033b8848a3c2c078d33657cc88b9f086%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26702: Document custom field subclass change requires new custom field class

[Django]

#26702: Document custom field subclass change requires new custom field class
--+
 Reporter:  baylee|Owner:  baylee
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/6705 PR]. I haven't reviewed it
 myself, but marking as needs improvement per previous comment.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e71fdf49e2d3b4a7f1703abd2f81d004%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26702: Document custom field subclass change requires new custom field class

[Django]

#26702: Document custom field subclass change requires new custom field class
--+
 Reporter:  baylee|Owner:  baylee
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by tuffnatty):

 The method/mixin part is confusing for an average reader who is searching
 for a simple case; I think that it should be an example separate from the
 original case in #26586 where no mixin is needed.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ad159de9d2fad44e4cce2eeca4987002%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26702: Document custom field subclass change requires new custom field class

[Django]

#26702: Document custom field subclass change requires new custom field class
--+
 Reporter:  baylee|Owner:  baylee
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.63765d012366c0cc2d9c6bc2580aeee8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26702: Document custom field subclass change requires new custom field class

[Django]

#26702: Document custom field subclass change requires new custom field class
-+-
 Reporter:  baylee   |Owner:  baylee
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by baylee):

 * status:  new => assigned
 * needs_docs:   => 0
 * owner:  nobody => baylee
 * needs_tests:   => 0
 * needs_better_patch:   => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.212c9763633f3c604871b81c1a60697d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.