Re: [Django] #27622: Testing client should accept vendor tree json variants

[Django]

#27622: Testing client should accept vendor tree json variants
-+-
 Reporter:  John Gresty  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  json vendor  | Triage Stage:  Accepted
  testing_client |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Anton Samarchyan):

 * cc: desecho@… (added)
 * has_patch:  0 => 1


Comment:

 Added [https://github.com/django/django/pull/7760 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9bf955d379475093b09b47b1e1928fcd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27622: Testing client should accept vendor tree json variants

[Django]

#27622: Testing client should accept vendor tree json variants
-+-
 Reporter:  John Gresty  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  json vendor  | Triage Stage:  Accepted
  testing_client |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Adam Chainz):

 The regex mentions `vnd.bigcompany.funnypictures` as a possible vendor
 name which the suggested regex won't parse. Maybe django can use a looser
 regex like `r'^application\/(vnd\..+\+)?json$'` as per the robustness
 principle.

 Or maybe even drop the header check - if a test calls `resp.json()` it's
 already 99.99% sure the response is in JSON, and if it's not, what's wrong
 with the test giving a `JSONDecodeError`? (Maybe heading into backwards
 incompatible territory there though).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.07f9b7348a3949cfdee00f64ab195401%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27622: Testing client should accept vendor tree json variants

[Django]

#27622: Testing client should accept vendor tree json variants
-+-
 Reporter:  John Gresty  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  json vendor  | Triage Stage:  Accepted
  testing_client |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


Comment:

 Thanks, I guess it's okay to accept `application/json` variants then. I
 didn't verify your regex is correct.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.34092bff1fc3167bbb4b3fccc6a96fbb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27622: Testing client should accept vendor tree json variants

[Django]

#27622: Testing client should accept vendor tree json variants
-+-
 Reporter:  John Gresty  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  json vendor  | Triage Stage:
  testing_client |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by John Gresty):

 Replying to [comment:2 Tim Graham]:
 > I'm not familiar with vendor tree json variants. Could you explain that
 a bit more and give a use case in the Django ecosystem? Is it common
 practice and/or a standard?

 Vendor trees are defined in section 3.2 of RFC 6838
 ([https://tools.ietf.org/html/rfc6838#section-3.2]). My use case was
 trying to test a json api ([http://jsonapi.org]) implemented using
 [https://github.com/django-json-api/django-rest-framework-json-api] which
 returns the IANA registered content-type 'application/vnd.api+json'

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2a6319b75d1a2683bf4e56d2171520c4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27622: Testing client should accept vendor tree json variants

[Django]

#27622: Testing client should accept vendor tree json variants
-+-
 Reporter:  John Gresty  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  json vendor  | Triage Stage:
  testing_client |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham):

 I'm not familiar with vendor tree json variants. Could you explain that a
 bit more and give a use case in the Django ecosystem? Is it common
 practice and/or a standard?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.11a3f65eedad2000eedeb71389704d9f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27622: Testing client should accept vendor tree json variants

[Django]

#27622: Testing client should accept vendor tree json variants
-+-
 Reporter:  John Gresty  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  json vendor  | Triage Stage:
  testing_client |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by John Gresty):

 * keywords:  json jsonp json_api testing_client => json vendor
   testing_client


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c4089a03107ea30fdc6f2ad3deaf9a0f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.