Re: [Django] #28852: Search in admin can't use index when several fields are in `search_fields`

[Django]

#28852: Search in admin can't use index when several fields are in 
`search_fields`
-+-
 Reporter:  Jonathan Sundqvist   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  search   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Rather than adding more syntactic sugar like `@english@field_2`, I think
 overriding `ModelAdmin.get_search_results()` may be the best approach. If
 you come up with a solution that you think is particularly elegant, I'd
 please raise it on the DevelopersMailingList to see if there's a consensus
 to add it to Django.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.f3856470912d78894a4091397c44cf18%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28852: Search in admin can't use index when several fields are in `search_fields`

[Django]

#28852: Search in admin can't use index when several fields are in 
`search_fields`
-+-
 Reporter:  Jonathan Sundqvist   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  search   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jonathan Sundqvist):

 > What do you think of overriding ModelAdmin.get_queryset to use
 .annotate(sv=SearchVector(...)) and then specifying 'sv__search' in the
 ModelAdmin.search_fields? It looks like that won't work with the current
 implementation, as search_fields must be model fields and not queryset
 annotations.

 From what I can see that won't really work either even if you were to
 override the modeladmin queryset. Being able to set the config of the
 search vector and the search query is key to be able to use the index.

 You could require a `full_text_search` setting in the modeladmin to
 configure the search vector.

 {{{
 full_text_search = {
 'config': 'english',
 'fields': ['field_1', 'field_2'],
 }
 }}}

 But as far as I know just using `sv__search` in that case would omit any
 config for that particular search query. I'll check it out and see what
 results I get.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.1b573c1971198de379dbc2603fa44d49%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28852: Search in admin can't use index when several fields are in `search_fields`

[Django]

#28852: Search in admin can't use index when several fields are in 
`search_fields`
-+-
 Reporter:  Jonathan Sundqvist   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  search   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tomer Chachamu):

 * cc: Tomer Chachamu (added)


Comment:

 I've also had to customise {{{ModelAdmin.get_search_results}}} because of
 its not-so-smartness (I will probably open a separate card for it).

 We've already moved away from the symbols for lookups, see
 
https://docs.djangoproject.com/en/dev/ref/contrib/admin/#django.contrib.admin.ModelAdmin.search_fields
 and previous discussion https://code.djangoproject.com/ticket/26184.

 What do you think of overriding {{{ModelAdmin.get_queryset}}} to use
 {{{.annotate(sv=SearchVector(...))}}} and then specifying
 {{{'sv__search'}}} in the {{{ModelAdmin.search_fields}}}? It looks like
 that won't work with the current implementation, as {{{search_fields}}}
 must be model fields and not queryset annotations.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.6c852d70d4691e669b8519bccdf4a84b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.