Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  Chetan Khanna => (none)
 * status:  assigned => new

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e755d3a7d-85ddb94c-fb6e-4df7-a99c-0507a0ba1176-00%40eu-central-1.amazonses.com.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  Chetan
 |  Khanna
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f95a3b7c8e58c504456d07fa06ebdeb6%40djangoproject.com.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  Chetan
 |  Khanna
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Chetan Khanna):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b60d564ec798cf38443f01912918%40djangoproject.com.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  Chetan
 |  Khanna
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7a5ac857e47142b22a73583d3bd88e43%40djangoproject.com.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  Chetan
 |  Khanna
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * owner:  Can Sarıgöl => Chetan Khanna


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3ad3cd01bdd2cf12d6d9f38301460ad6%40djangoproject.com.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  Can
 |  Sarıgöl
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Chetan Khanna):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


Comment:

 [https://github.com/django/django/pull/12258]

 I've added a PR based off the one Anssi started. I'll be glad if someone
 could take a look and let me know of any improvements needed. All sqlite
 and postgres tests were passing when I tested through django-docker-box.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c83acbae495da643dee4a3d3fbf3a598%40djangoproject.com.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  Can
 |  Sarıgöl
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1
 * version:  2.0 => master
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.021e2a54a442422069e95aff91ad4529%40djangoproject.com.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  Can
 |  Sarıgöl
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Can Sarıgöl):

 * status:  new => assigned
 * needs_better_patch:  1 => 0
 * cc: Can Sarıgöl (added)
 * owner:  nobody => Can Sarıgöl


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.45106dbf97332aa51b1e8344daf26baf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Can Sarıgöl):

 [https://github.com/django/django/pull/11387 PR]

 a different approach

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.dc0f1af566cd06cd89ca3565d5eb9bea%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


Comment:

 Anssi started a [https://github.com/django/django/pull/9984 PR] but
 doesn't have time to finish it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ed0d0e8cd6152d3fddedd6c86406659b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * severity:  Release blocker => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.43e1c5f99d6b8510ba94e4cd64d9c9e5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Thierry Bastian):

 @Ran Benita: I was afraid you'd say something like that. My knowledge of
 django internals is not that great at the moment. So I will have to try
 and find a better way to do that on my own.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a4a46575075d8b86f9ee9bfb7cfe2dfa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 It could be acceptable (at least as a temporary measure) to raise a
 message that it's not supported.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.86fdb975792beb84dce6cd4252e0ea3f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ran Benita):

 I'm afraid this case is harder. Essentially, the current implementation of
 select_for_update(of=(...)) is based on the select_related()
 infrastructure, but of course once .values()/.values_list() is invoked
 there is no more select_related.

 I will try to dig deeper once I am able. Help is welcome.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ef0a865fd1eaac467ba822494f82c2ed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * has_patch:  1 => 0
 * stage:  Ready for checkin => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1ef7fe7d1b1c9f891a39c080746231e8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Thierry Bastian):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 Ok so you fixed the simple case with self, but it still fails where there
 are joins.

 So if you have 2 models:


 {{{

 class A(models.Model):
foo = models.TextField()

 class B(models.Model):
 bla = models.TextField()
 a = models.ForeignKey(a, on_delete=models.CASCADE)

 and then if you want to do:
 B.objects.all().select_related('a').select_for_update(of=('self', 'a')) ,
 that works
 but the same with a values_list:
 B.objects.all().select_related('a').select_for_update(of=('self',
 'a')).values_list('pk', 'a__foo'), that does not work and results in
 something like (I have different class names in my code)

 Traceback (most recent call last):
   File "", line 2, in 
   File "/usr/local/filewave/python/lib/python3.6/site-
 packages/django/db/models/query.py", line 248, in __repr__
 data = list(self[:REPR_OUTPUT_SIZE + 1])
   File "/usr/local/filewave/python/lib/python3.6/site-
 packages/django/db/models/query.py", line 272, in __iter__
 self._fetch_all()
   File "/usr/local/filewave/python/lib/python3.6/site-
 packages/django/db/models/query.py", line 1179, in _fetch_all
 self._result_cache = list(self._iterable_class(self))
   File "/usr/local/filewave/python/lib/python3.6/site-
 packages/django/db/models/query.py", line 139, in __iter__
 return compiler.results_iter(tuple_expected=True,
 chunked_fetch=self.chunked_fetch, chunk_size=self.chunk_size)
   File "/usr/local/filewave/python/lib/python3.6/site-
 packages/django/db/models/sql/compiler.py", line 1015, in results_iter
 results = self.execute_sql(MULTI, chunked_fetch=chunked_fetch,
 chunk_size=chunk_size)
   File "/usr/local/filewave/python/lib/python3.6/site-
 packages/django/db/models/sql/compiler.py", line 1051, in execute_sql
 sql, params = self.as_sql()
   File "/usr/local/filewave/python/lib/python3.6/site-
 packages/django/db/models/sql/compiler.py", line 508, in as_sql
 of=self.get_select_for_update_of_arguments(),
   File "/usr/local/filewave/python/lib/python3.6/site-
 packages/django/db/models/sql/compiler.py", line 962, in
 get_select_for_update_of_arguments
 ', '.join(_get_field_choices()),
 django.core.exceptions.FieldError: Invalid field name(s) given in
 select_for_update(of=(...)): mdm_client. Only relational fields followed
 in the query are allowed. Choices are: self.


 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1ed2c1efa5b271bffe364f2b75b92c6f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"4e4619a2b8f79699fbdb2c4f1bc4db55f59af6e6" 4e4619a]:
 {{{
 #!CommitTicketReference repository=""
 revision="4e4619a2b8f79699fbdb2c4f1bc4db55f59af6e6"
 [2.0.x] Fixed #28944 -- Fixed crash when chaining values()/values_list()
 after QuerySet.select_for_update(of=()).

 Backport of c21f158295d92e35caf96436bfdbbff554fc5569 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1a4c8ca6869e7666fb61d863fd67d64a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c21f158295d92e35caf96436bfdbbff554fc5569" c21f1582]:
 {{{
 #!CommitTicketReference repository=""
 revision="c21f158295d92e35caf96436bfdbbff554fc5569"
 Fixed #28944 -- Fixed crash when chaining values()/values_list() after
 QuerySet.select_for_update(of=()).
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0d4b0dfeba400875118d2cdd1701%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * stage:  Accepted => Ready for checkin


Comment:

 I think the patch is RFC except for a few cosmetic comments and a release
 note for 2.0.1.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7ce10855565d44060d05c91617561050%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ran Benita):

 * has_patch:  0 => 1


Comment:

 Suggested fix: https://github.com/django/django/pull/9487

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f0c27dbe67b0d5ef53f05d6740aa5b07%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28944: Chaining values()/values_list() after QuerySet.select_for_update(of=()) crashes (was: Queryset cannot handle select_for_update and values/values_list at the same time)

[Django]

#28944: Chaining values()/values_list() after QuerySet.select_for_update(of=())
crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * cc: Ran Benita (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.79b06a8e709f0332650758e4698c4c89%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.