Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Maron
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  ForeignKey,  | Triage Stage:  Ready for
  get_search_results, search_fields  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"3071660acfbdf4b5c59457c8e9dc345d5e8894c5" 3071660a]:
 {{{
 #!CommitTicketReference repository=""
 revision="3071660acfbdf4b5c59457c8e9dc345d5e8894c5"
 Fixed #29010, Fixed #29138 -- Added limit_choices_to and to_field support
 to autocomplete fields.

 * Fixed #29010 -- Added limit_choices_to support to autocomplete fields.
 * Fixed #29138 -- Allowed autocomplete fields to target a custom
   to_field rather than the PK.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.c079f42c75cc2f7113093c537da17cc2%40djangoproject.com.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Maron
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Ready for
  get_search_results, search_fields  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.cbafc27580b2234fae0562db96b65363%40djangoproject.com.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Maron
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Johannes Maron):

 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.7c7361171f347799adf347173356b163%40djangoproject.com.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Johannes Hoppe):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.e688b970d677a9161ab2f83f56976d51%40djangoproject.com.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Johannes Hoppe):

 Ok Carlton, honeymoon's over. I addressed all review comments.

 Gordon, interesting idea, why don't you start a new issue for that, since
 it seems to be a separate issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.66324e03c0f3ddf8c59298ae79973972%40djangoproject.com.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Andy Grabow):

 * cc: Andy Grabow (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.88b559281d501df553f92cd6ac69d7b4%40djangoproject.com.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Gordon Wrigley):

 It would be really nice if it were easy to inject additional values into
 the widget at form construction time and then filter on them in
 get_search_results.

 With the current patch I believe that would require:
 1: overriding build_attrs to pass the value along
 2: overriding autocomplete.js to pass the value along

 Regarding these:
 1: is not a particularly big deal, but could be tidied up with something
 like a get_search_args.
 2: this is annoying just because it's outside the python, it would be nice
 if it was a wild card pass, perhaps the fields could be bundled into a
 dict or some such.

 After than you can pull the values off the request in get_search_results,
 which is maybe not elegant, but works fine.

 In terms or what values to pass along the most useful and the ones on my
 mind are the model and pk of the admin page the autocomplete is resident
 on.
 The page specifically because when there's dynamic (can add and remove)
 inlines involved the model and pk of the inlined object is not always
 useful.
 As an example if you consider polls and choices this is required for a
 "default_choice" field which is only allowed to choose from the polls
 existing choices.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.e50dbc37b8b952b3210e808d0af09698%40djangoproject.com.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 OK, thanks for the update. No problem Joe. This is a good win, and it
 doesn’t need much now, so if you have some time over the next few weeks,
 that’s plenty.  Enjoy the wedding! 😀

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.fd05176541cc2296ab1baebf38ca12be%40djangoproject.com.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Johannes Hoppe):

 Hi Clarton, I have this wedding on Friday, in which I have an important
 part to play ;) I'll get to it next week, I hope. As always, I don't mind
 help with the docs until then. Best Joe

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.96c5fb8ed520f1460c3bf61424337665%40djangoproject.com.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Gordon Wrigley):

 * cc: Gordon Wrigley (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.0569c17531b705f1343ea7a86d9c156d%40djangoproject.com.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * needs_docs:  0 => 1


Comment:

 The patch is looking good. I've raised a possible adjustment on the
 ticket, as Andy says it looks like there a test missing for the M2M case,
 and it'll docs.

 Joe: if you don't have capacity for this now, say, and either I or someone
 else can pick it up to finish.
 Good work!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.cf003c8cf07951b9dac313c361265462%40djangoproject.com.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Andy Grabow):

 I have tested that feature branch - works like a charm!

 To me the added tests also look good, there is just one thin missing:
 admin_views/models.py:646
 There is a prepared field for ManyToMany (related_answers) tests, but the
 matching test case is missing.

 With that test case checked in, this feature could finally go live. :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.228f930b67985f9383e17f774e4ce6da%40djangoproject.com.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ehossack):

 * cc: ehossack (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.53c11b7f17a2fe30ffd92b12a724245a%40djangoproject.com.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Johannes Hoppe):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.f0873bdb593d6a0178c95c8d98d6de0d%40djangoproject.com.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Florian Apolloner):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.a242431829e16d9a99f88024bff58870%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Johannes Hoppe):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.e4b60aedec0cb2e7a7e3369bdf6522cc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Johannes Hoppe):

 * type:  New feature => Bug
 * stage:  Someday/Maybe => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.696cdc6b9a87e420a78ef99e4ebc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:
  get_search_results, search_fields  |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Johannes Hoppe):

 * owner:  nobody => Johannes Hoppe
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.99afda0966842c164a03bc67cedca2b4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:
  get_search_results, search_fields  |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by David W. Lloyd):

 Replying to [comment:14 Johannes Hoppe]:
 > Well not necessarily. I did have a go at this yesterday evening.
 `limit_choices_to`  could be fixed, without a larger refactoring.
 > I would use a couple of strange API's though. I am not yet happy with my
 solution.

 I'm curious how limit_choices_to can be accessed without also then knowing
 the referring model... so I'll log the ticket and link this one :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.f024dae32eb6d9e824e739c6af557734%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:
  get_search_results, search_fields  |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Johannes Hoppe):

 Well not necessarily. I did have a go at this yesterday evening.
 `limit_choices_to`  could be fixed, without a larger refactoring.
 I would use a couple of strange API's though. I am not yet happy with my
 solution.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.c22c2cd502d33d05d948ff0be15fa057%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:
  get_search_results, search_fields  |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by David W. Lloyd):

 Replying to [comment:12 Johannes Hoppe]:
 > Is there a ticket now for the `limit_choices_to` issue yet? I'd really
 like to fix that one.

 I can create a ticket, but isn't it the same problem as this ticket? Once
 the AutocompleteView knows which model to get "limit_choices_to" from, the
 original issue being presented here would *also* be addressed at the same
 time - unless I'm missing something?

 I'll gladly create a separate ticket for limit_choices_to if you prefer, I
 just thought that the solution to that problem would end up fixing this
 issue as well...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.e91f793ae7be79e00923a761959d3c7f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:
  get_search_results, search_fields  |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Johannes Hoppe):

 Is there a ticket now for the `limit_choices_to` issue yet? I'd really
 like to fix that one.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.007970ac5c3f5c4690c32ceb1697448b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:
  get_search_results, search_fields  |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Is this really a `Someday/Maybe`, rather than a `wontfix` as it stands?
 No doubt we evolve the capabilities here but this doesn't look at all
 actionable with the current design.

 As per comment on #29700, I'd (currently/initially) favour pointing users
 to subclassing `AutocompleteJsonView` and seeing what they come up with.
 I suspect good ideas would come out of there...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.9a2185c95d7407665bd2e59f3531b41e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:
  get_search_results, search_fields  |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by David W. Lloyd):

 Replying to [comment:8 Johannes Hoppe]:

 > > Replying to [comment:6 Johannes Hoppe]:
 >
 > > - the new autocomplete widget ignores any filtering done in the
 "limit_choices_to" ORM definition, unlike a regular select field; not very
 DRY, since limit_choices_to can, with other widgets, be used to filter
 lookups effectively... inconsistent, unintuitive behavior. If you're not
 going to fix it, perhaps update the autocomplete documentation to mention
 that limit_choices_to is completely ignored...
 >
 > I agree this is a problem. I would much welcome a fix here to. It seems
 we all missed in the reviews.
 >

 I think the problem is that any fix would almost have to do what the
 feature request here is proposing - if the view doesn't know where the
 relation is coming from, it can't consult the ORM field and get the
 correct limit_choices_to filter to apply. If the referring model were
 passed in, one way or another, this filtering could be accomplished.
 Rather than doing a view per widget, having the ModelAdmin provide its
 underlying model to any autocomplete view being referenced seems like it
 might do the trick?

 > Go ahead an decouple it. That's an easy one. You add a new method that
 by defaults calls the current soring method.
 > Please open a separate issue for that one. I would be happy to review
 this feature.
 >

 Will do, thanks!

 > It's a pretty big hypophysis that "many folks are using the admin to
 build complex interfaces", even though this is discouraged. In general I
 would kindly ask you to watch your tone. This feature is a result of a lot
 of hard work by "many folks". Phrases like "half-baked" may hurt people's
 feelings.
 >
 > You have to chose here, you either: Love it, change it or leave it.

 Understood; I'm new here and this wasn't the right tone, I apologize. I do
 love 95% of it and I hope I can help change the other five.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.8c64cb3f080729817eedfdeb40fbcc57%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:
  get_search_results, search_fields  |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Hi. Just seconding Joe's comment about tone.

 Can we please make sure we breathe before posting and are respectful of
 each other and the thought, time and energy that goes into work on Django
 from all the volunteers.

 Thank you.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.2023216866e304390e4559c798131dd4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:
  get_search_results, search_fields  |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Johannes Hoppe):

 Replying to [comment:7 David W. Lloyd]:
 > Replying to [comment:6 Johannes Hoppe]:
 >
 > > To add a bit more context here, we did have an intermediate solution
 that would have made this easier. A view per widget. We ultimately dropped
 that approach to decrease complexity. A decision I still support.
 >
 > Was there no in-between option? This severely limits the usefulness of
 the widget... as a separate-but-related issue:

 I agree, but this feature took ten years to be implemented. We decreased
 scope to decrease complexity. Now that it's out we can see what additional
 features get requested and chose to work on those.

 > - the new autocomplete widget ignores any filtering done in the
 "limit_choices_to" ORM definition, unlike a regular select field; not very
 DRY, since limit_choices_to can, with other widgets, be used to filter
 lookups effectively... inconsistent, unintuitive behavior. If you're not
 going to fix it, perhaps update the autocomplete documentation to mention
 that limit_choices_to is completely ignored...

 I agree this is a problem. I would much welcome a fix here to. It seems we
 all missed in the reviews.

 > - the new autocomplete widget ties its ordering of results to the
 ModelAdmin in question, which is also unintuitive if your ModelAdmin has a
 default ordering other than alphabetical... for example, if you want the
 ModelAdmin to default to showing the newest entries, your autocomplete
 results will ALSO be ordered thus, but such sorting is extremely confusing
 and unlikely to be helpful in a type-ahead scenario

 The sorting is only there for pagination purposes but it can be used to
 improve results. I use the widgets on full text indexes too, which go way
 beyond a simple typeahead.

 > Your proposal to use django-select2 or DAL almost makes me wonder: why
 add autocomplete to the admin at all, then? It's 2018, this is a standard
 design pattern for administrative backends, and to omit the ability to
 filter based on referring entity, to ignore limit_choices_to, and to
 tightly couple autocomplete result sorting to default ModelAdmin result
 sorting seems highly counterintuitive in a pretty common set of use cases.

 Go ahead an decouple it. That's an easy one. You add a new method that by
 defaults calls the current soring method. Please open a separate issue for
 that one. I would be happy to review this feature.

 > > My suggestion would be use an external library like `django-select2`
 or `django-autocomplete` if you want to implement more sophisticated
 logic.
 > > Please also keep in mind, the admin is not recommend to be used for
 sofistikated user interfaces.
 >
 > Based on the packages out there targeting the admin & the extensive
 articles on customizing it, that recommendation just seems optimistic.
 Django's built-in admin is hailed as one of its selling points, and the
 fact that it HAS a strong built-in solution has probably discouraged the
 creation of third-party standalone packages targeting scaffolding &
 building admin backends - why reinvent the wheel? This recommendation
 seems to ignore reality - many folks are using the admin to build complex
 interfaces, the autocomplete in 2.0 *can* really help us all out, but it's
 a little half-baked at the moment. Baking it some more, to allow for
 filtering based on relation and decoupled sorting, seems like a high-value
 enhancement...

 Please not that these 3rd party librarie have been around a lot longer
 than the new admin feature – no wheel reinvention happening. Furthermore
 they address a lot more use cases they are meant for user interaction
 (none-admins).
 It's a pretty big hypophysis that "many folks are using the admin to build
 complex interfaces", even though this is discouraged. In general I would
 kindly ask you to watch your tone. This feature is a result of a lot of
 hard work by "many folks". Phrases like "half-baked" may hurt people's
 feelings.

 You have to chose here, you either: Love it, change it or leave it.

-- 
Ticket URL: 
Django 
The Web f

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:
  get_search_results, search_fields  |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by David W. Lloyd):

 Replying to [comment:6 Johannes Hoppe]:

 > To add a bit more context here, we did have an intermediate solution
 that would have made this easier. A view per widget. We ultimately dropped
 that approach to decrease complexity. A decision I still support.

 Was there no in-between option? This severely limits the usefulness of the
 widget... as a separate-but-related issue:

 - the new autocomplete widget ignores any filtering done in the
 "limit_choices_to" ORM definition, unlike a regular select field; not very
 DRY, since limit_choices_to can, with other widgets, be used to filter
 lookups effectively... inconsistent, unintuitive behavior. If you're not
 going to fix it, perhaps update the autocomplete documentation to mention
 that limit_choices_to is completely ignored...

 - the new autocomplete widget ties its ordering of results to the
 ModelAdmin in question, which is also unintuitive if your ModelAdmin has a
 default ordering other than alphabetical... for example, if you want the
 ModelAdmin to default to showing the newest entries, your autocomplete
 results will ALSO be ordered thus, but such sorting is extremely confusing
 and unlikely to be helpful in a type-ahead scenario

 Your proposal to use django-select2 or DAL almost makes me wonder: why add
 autocomplete to the admin at all, then? It's 2018, this is a standard
 design pattern for administrative backends, and to omit the ability to
 filter based on referring entity, to ignore limit_choices_to, and to
 tightly couple autocomplete result sorting to default ModelAdmin result
 sorting seems highly counterintuitive in a pretty common set of use cases.


 > My suggestion would be use an external library like `django-select2` or
 `django-autocomplete` if you want to implement more sophisticated logic.
 > Please also keep in mind, the admin is not recommend to be used for
 sofistikated user interfaces.

 Based on the packages out there targeting the admin & the extensive
 articles on customizing it, that recommendation just seems optimistic.
 Django's built-in admin is hailed as one of its selling points, and the
 fact that it HAS a strong built-in solution has probably discouraged the
 creation of third-party standalone packages targeting scaffolding &
 building admin backends - why reinvent the wheel? This recommendation
 seems to ignore reality - many folks are using the admin to build complex
 interfaces, the autocomplete in 2.0 *can* really help us all out, but it's
 a little half-baked at the moment. Baking it some more, to allow for
 filtering based on relation and decoupled sorting, seems like a high-value
 enhancement...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.baa73404326d05671909ee5c026aea40%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:
  get_search_results, search_fields  |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Johannes Hoppe):

 * stage:  Accepted => Someday/Maybe


Comment:

 Hi there,

 currently you don't explicitly know who is calling this method, since it's
 all called from the same view. Both Widgets call the same view as the view
 is on AAdmin.
 So this is conceptually not supported. That doesn't mean it doesn't work.
 You can always check https://en.wikipedia.org/wiki/HTTP_referer

 To add a bit more context here, we did have an intermediate solution that
 would have made this easier. A view per widget. We ultimately dropped that
 approach to decrease complexity. A decision I still support.

 My suggestion would be use an external library like `django-select2` or
 `django-autocomplete` if you want to implement more sophisticated logic.
 Please also keep in mind, the admin is not recommend to be used for
 sofistikated user interfaces.

 Anyhow, at the moment I would strongly advice against adding a "hint" to
 the request. Since it's not safe against request forging and can lead to
 unintended security issues.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.382b4a7074c58830131c7d00e5943d66%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.db54a8ae3cc4b9aca4b1198ebab11aa8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model (was: Which models is querying search_fields to autocomplete?)

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:
  get_search_results, search_fields  |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * cc: Johannes Hoppe (added)
 * component:  Database layer (models, ORM) => contrib.admin


Comment:

 I see. I guess it might be possible to add a hint of the model where the
 query is coming from in a GET parameter. That would be untrusted though.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.966b6b9fa679464f5ca5a02b35212fe8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.