Re: [Django] #29230: Incorrect behavior of QuerySet.prefetch_related() in some circumstances during multilevel data prefetching

[Django]

#29230: Incorrect behavior of QuerySet.prefetch_related() in some circumstances
during multilevel data prefetching
-+-
 Reporter:  Alex Sichkar |Owner:  Paulo
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  prefetch_related | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"25d4d8465b5a92cae5647117e2a42f71cd97a06f" 25d4d846]:
 {{{
 #!CommitTicketReference repository=""
 revision="25d4d8465b5a92cae5647117e2a42f71cd97a06f"
 [2.1.x] Fixed #29230 -- Fixed nested prefetches that clash with
 descriptors.

 Backport of 6104875a2cc797bbd1254aa61f22a9b03d652128 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.56320109eac190c61071edfb7048062a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29230: Incorrect behavior of QuerySet.prefetch_related() in some circumstances during multilevel data prefetching

[Django]

#29230: Incorrect behavior of QuerySet.prefetch_related() in some circumstances
during multilevel data prefetching
-+-
 Reporter:  Alex Sichkar |Owner:  Paulo
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  prefetch_related | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"6104875a2cc797bbd1254aa61f22a9b03d652128" 6104875a]:
 {{{
 #!CommitTicketReference repository=""
 revision="6104875a2cc797bbd1254aa61f22a9b03d652128"
 Fixed #29230 -- Fixed nested prefetches that clash with descriptors.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.05a73d11974cd06ca48bd6a135284fd0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29230: Incorrect behavior of QuerySet.prefetch_related() in some circumstances during multilevel data prefetching

[Django]

#29230: Incorrect behavior of QuerySet.prefetch_related() in some circumstances
during multilevel data prefetching
-+-
 Reporter:  Alex Sichkar |Owner:  Paulo
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  prefetch_related | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Paulo):

 PR: https://github.com/django/django/pull/9995

 The commit in
 
https://code.djangoproject.com/changeset/379caf397ea41923278821085204c296f960e70e/
 didn't fix this.
 It just reversed the execution order of prefetch objects.

 Changing the attached test from:


 {{{
 projects = Project.objects.prefetch_related(
 Prefetch('tasks', queryset=tasks),
 Prefetch('tasks', to_attr='some_attr_name'),
 )
 }}}


 to:


 {{{
 projects = Project.objects.prefetch_related(
 Prefetch('tasks', to_attr='some_attr_name'),
 Prefetch('tasks', queryset=tasks),
 )
 }}}


 Made it fail again.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.92b5eaa74f1e41898e73e76c808d2db2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29230: Incorrect behavior of QuerySet.prefetch_related() in some circumstances during multilevel data prefetching

[Django]

#29230: Incorrect behavior of QuerySet.prefetch_related() in some circumstances
during multilevel data prefetching
-+-
 Reporter:  Alex Sichkar |Owner:  Paulo
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  prefetch_related | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Paulo):

 * owner:  nobody => Paulo
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.41baba578efb47552987d13c9847fa00%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29230: Incorrect behavior of QuerySet.prefetch_related() in some circumstances during multilevel data prefetching

[Django]

#29230: Incorrect behavior of QuerySet.prefetch_related() in some circumstances
during multilevel data prefetching
-+-
 Reporter:  Alex Sichkar |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  prefetch_related | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


Comment:

 I found that your test case was fixed in Django 2.0 by
 379caf397ea41923278821085204c296f960e70e. Since a regression test wasn't
 added as part of that commit, I'll accept the ticket to do that. If you
 can adapt your test for `tests/prefetch_related` (using existing models as
 much as possible) that would be great.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ac87155ef3777f3a97ce495af97685f1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29230: Incorrect behavior of QuerySet.prefetch_related() in some circumstances during multilevel data prefetching

[Django]

#29230: Incorrect behavior of QuerySet.prefetch_related() in some circumstances
during multilevel data prefetching
-+-
 Reporter:  Alex Sichkar |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  prefetch_related | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Alex Sichkar):

 * Attachment "prefetch_related_issue.zip" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.0a212df41011c964943f68014c2210e9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.