Re: [Django] #29454: Default size for django.core.files.uploadedfile is None and then len will raise error

[Django]

#29454: Default size for django.core.files.uploadedfile is None and then len 
will
raise error
-+-
 Reporter:  jxltom   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  File |  Version:  2.0
  uploads/storage|
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 Closing, absent some use case for the fix.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.907bca5a7e25833fd4b955be6f77a64f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29454: Default size for django.core.files.uploadedfile is None and then len will raise error

[Django]

#29454: Default size for django.core.files.uploadedfile is None and then len 
will
raise error
-+-
 Reporter:  jxltom   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  File |  Version:  2.0
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Windson yang):

 the code is in
 https://github.com/django/django/blob/master/django/core/files/base.py#L28,
 I'm not sure we should handle if the file doesn't have size.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.cbe723be34d96b215152bfbfdaa6b6ad%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29454: Default size for django.core.files.uploadedfile is None and then len will raise error

[Django]

#29454: Default size for django.core.files.uploadedfile is None and then len 
will
raise error
-+-
 Reporter:  jxltom   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  File |  Version:  2.0
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Old description:

> By default, ```size``` of  django.core.files.uploadedfile is ```None```
> and ```__len__``` will return ```size``` by default. Calling ```len```
> will raise ```TypeError: 'NoneType' object cannot be interpreted as an
> integer``` error if size is not assigned specifically.
>
> Can this be handled better? such as do not implement ```__len__``` method
> if ```size``` is set as ```None```

New description:

 By default, `size` of  django.core.files.uploadedfile is `None` and
 `__len__` will return `size` by default. Calling `len` will raise
 `TypeError: 'NoneType' object cannot be interpreted as an integer` error
 if size is not assigned specifically.

 Can this be handled better? Such not implementing `__len__` method if
 `size` is set as `None`.

--

Comment (by Tim Graham):

 Did you find this to be a problem in practice?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.405be41e1a12df2170d9782486a85b64%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.