Re: [Django] #29618: using query parameters to filter by boolean causes validation error due to lowercase true/false

[Django]

#29618: using query parameters to filter by boolean causes validation error due 
to
lowercase true/false
-+-
 Reporter:  levi schubert|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:  filter   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Ah, it it does take `'False'` — my mistake. (That explains using
 `title()`.) This shouldn't work IMO. (But I suppose we can't change that
 for BC reasons...?)

 For reference:

 * Django `forms`: See
 
[https://github.com/django/django/blob/49f97b645fb1716cf69177558c41cf650a701eed/django/forms/fields.py#L701
 `forms.BooleanField.to_python()`], with e.g.
 
[https://github.com/django/django/blob/49f97b645fb1716cf69177558c41cf650a701eed/django/forms/widgets.py#L518
 `CheckboxInput.value_from_datadict()`]. The widget pulls the value from
 the `GET` `QueryDict`, which is then passed to the field, before being
 accessed via the form's `cleaned_data`.
 * Django REST Framework serialisers: See [https://github.com/encode
 /django-rest-
 
framework/blob/8493990a66e36d5dd4a62742d861b5b6b15cae80/rest_framework/fields.py#L682
 `BooleanField.to_internal_value()`]. The mapping from the various input
 values to a bool is done in a single step, being made available by the
 serialiser's `validated_data`.

 Either way, the input is sanitised and correctly cast to the boolean type
 before ever encountering the model field.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.c147bbdb2321855d8e44766a0e3e33bb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29618: using query parameters to filter by boolean causes validation error due to lowercase true/false

[Django]

#29618: using query parameters to filter by boolean causes validation error due 
to
lowercase true/false
-+-
 Reporter:  levi schubert|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:  filter   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * component:  Uncategorized => Database layer (models, ORM)


Comment:

 I believe the request is to allow
 `Mode.objects.filter(booleanfield='true')` (see
 
[https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L997-L1007
 BooleanField.to_python()]). I don't find the existing laxness of accepting
 0, 1, 't', 'f', 'True', 'False', True, and False particularly compelling
 and I wouldn't advocate for being even more liberal in the accepted
 values.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.778651dfd87487112cac7013ab0bcbcd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29618: using query parameters to filter by boolean causes validation error due to lowercase true/false

[Django]

#29618: using query parameters to filter by boolean causes validation error due 
to
lowercase true/false
---+--
 Reporter:  levi schubert  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Uncategorized  |  Version:  2.0
 Severity:  Normal |   Resolution:  invalid
 Keywords:  filter | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 It’s hard to know from your description exactly what you’re doing but I’d
 guess you’re just taking the **string** value contained in `request.GET`
 and trying to filter the model field on that.

 If so, this won’t work, since you need to pass a boolean `True` or `False`
 to a boolean field.

 I don’t understand the point about `title()` at all, since the string
 `’False’` isn’t a boolean either.

 It would have been helpful if you’d have provided a complete reproduce and
 the exact error, plus traceback.

 However, the correct approach here it to pass `request.GET` into a form in
 order to validate the raw (user submitted) data and convert it to
 appropriate types, before using the value from the form’s `cleaned_data`
 in order to filter your queryset.

 There’s a bit of biolerplate involved in this. You might want to check out
 [https://django-filter.readthedocs.io/en/master/ Django Filter], that
 wraps this up.

 I’m going to close this as a usage question. If I’ve missed something and
 there’s a reproducible big here please do follow-up with details and we
 can re-open.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.446ce2294f662e7f9bfacac96a27925e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29618: using query parameters to filter by boolean causes validation error due to lowercase true/false (was: using query parameters to filter by boolean causes assertion error due to low

[Django]

#29618: using query parameters to filter by boolean causes validation error due 
to
lowercase true/false
---+--
 Reporter:  levi schubert  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Uncategorized  |  Version:  2.0
 Severity:  Normal |   Resolution:
 Keywords:  filter | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.a091ab9629106951f67d81b03227db5b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.