Re: [Django] #29721: Migrations are not applied atomically

2021-01-20 Thread Django 
#29721: Migrations are not applied atomically
+-
 Reporter:  Gavin Wahl  |Owner:  Sanyam Khurana
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  2.1
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-

Comment (by Mariusz Felisiak ):

 In [changeset:"900b2ce92bd68fb4b17e923cffdbde30eb24f7d2" 900b2ce9]:
 {{{
 #!CommitTicketReference repository=""
 revision="900b2ce92bd68fb4b17e923cffdbde30eb24f7d2"
 [3.2.x] Refs #29721 -- Simplified migration used to test atomic recording.

 This makes sure atomic recording of migration application is used when
 the schema editor doesn't defer any statement.

 Backport of 533a5835784b95335c8373b6d0b9495b3834e96e from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ae1b03cae7cc76a308715bf983cfc6be%40djangoproject.com.

Re: [Django] #29721: Migrations are not applied atomically

2021-01-20 Thread Django 
#29721: Migrations are not applied atomically
+-
 Reporter:  Gavin Wahl  |Owner:  Sanyam Khurana
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  2.1
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-

Comment (by Mariusz Felisiak ):

 In [changeset:"533a5835784b95335c8373b6d0b9495b3834e96e" 533a583]:
 {{{
 #!CommitTicketReference repository=""
 revision="533a5835784b95335c8373b6d0b9495b3834e96e"
 Refs #29721 -- Simplified migration used to test atomic recording.

 This makes sure atomic recording of migration application is used when
 the schema editor doesn't defer any statement.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d1eb0a8b018202b1ba17b142a279ae5c%40djangoproject.com.

Re: [Django] #29721: Migrations are not applied atomically

2018-10-24 Thread Django 
#29721: Migrations are not applied atomically
+-
 Reporter:  Gavin Wahl  |Owner:  Sanyam Khurana
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  2.1
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c86a3d80a25acd1887319198ca21a84c451014ad" c86a3d80]:
 {{{
 #!CommitTicketReference repository=""
 revision="c86a3d80a25acd1887319198ca21a84c451014ad"
 Fixed #29721 -- Ensured migrations are applied and recorded atomically.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cbdd65178fa6f4882d13c3e9e42f12ac%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29721: Migrations are not applied atomically

2018-10-24 Thread Django 
#29721: Migrations are not applied atomically
+-
 Reporter:  Gavin Wahl  |Owner:  Sanyam Khurana
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  2.1
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by Simon Charette):

 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8598acebc4140daee2832053c48a40dd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29721: Migrations are not applied atomically

2018-10-20 Thread Django 
#29721: Migrations are not applied atomically
+--
 Reporter:  Gavin Wahl  |Owner:  Sanyam Khurana
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  2.1
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  1   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Simon Charette):

 * needs_tests:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 Removing the RFC status as a test for backends supporting transactional
 DDL can probably be added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d70e22518a69bb15c9b1629b4ad3a25d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29721: Migrations are not applied atomically

2018-10-20 Thread Django 
#29721: Migrations are not applied atomically
+-
 Reporter:  Gavin Wahl  |Owner:  Sanyam Khurana
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  2.1
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by Simon Charette):

 * has_patch:  0 => 1
 * stage:  Accepted => Ready for checkin


Comment:

 Given the difficulty of adding a test that isn't highly implementation
 specific and how the new implementation is technically more correct I
 consider this patch RFC.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b87d4816027d05a5cd9863e5a9cc6543%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29721: Migrations are not applied atomically

2018-10-19 Thread Django 
#29721: Migrations are not applied atomically
+--
 Reporter:  Gavin Wahl  |Owner:  Sanyam Khurana
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  2.1
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Sanyam Khurana):

 * status:  new => assigned
 * owner:  nobody => Sanyam Khurana


Comment:

 I'm working on this during DjangoCon US sprints and would submit a patch
 ASAP.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.905dcdafde3bd5e89901dcead467693c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29721: Migrations are not applied atomically

2018-09-13 Thread Django 
#29721: Migrations are not applied atomically
+
 Reporter:  Gavin Wahl  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  2.1
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by Tim Graham):

 * type:  Uncategorized => Bug


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0a83c78035b708a007a4749380ba6534%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29721: Migrations are not applied atomically

2018-09-01 Thread Django 
#29721: Migrations are not applied atomically
---+
 Reporter:  Gavin Wahl |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Migrations |  Version:  2.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Simon Charette):

 This is really strange, are you sure the migration was not marked as
 `atomic=False`?

 If not It's unlikely to have happened without an exception being surfaced.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cd7b9ca82b06db52ada3b335d32de9f4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29721: Migrations are not applied atomically

2018-08-31 Thread Django 
#29721: Migrations are not applied atomically
---+
 Reporter:  Gavin Wahl |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Migrations |  Version:  2.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Gavin Wahl):

 It was on postgres. It was a regular migration adding some tables, and the
 tables were added but the migration was not recorded in django_migrations.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6f188d6be5c81e513d2aab1ef0bbb0d7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29721: Migrations are not applied atomically

2018-08-29 Thread Django 
#29721: Migrations are not applied atomically
---+
 Reporter:  Gavin Wahl |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Migrations |  Version:  2.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Simon Charette):

 * stage:  Unreviewed => Accepted


Comment:

 I guess we could move the recording logic in the context manager to be
 entirely correct but I'm surprised this has happened to you given the
 small amount of operations performed between the two blocks.

 Are you certain you didn't
 [https://docs.djangoproject.com/en/2.1/topics/migrations/#mysql the
 documented caveat of MySQL regarding atomic migrations]? In that case this
 change wouldn't help at all. Was it the `django_migrations` table creation
 that failed?

 Are you able to provide a patch/PR?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.af6fff83541a5c7fd6c8a10e45ba5da0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.