Re: [Django] #3055: GenericRelation should squawk if pointed to a model that doesn't have a GenericForeignKey on it

[Django]

#3055: GenericRelation should squawk if pointed to a model that doesn't have a
GenericForeignKey on it
-+-
 Reporter:  panta@…  |Owner:
 Type:  defect   |  marcosmoyano
Component:  Database layer   |   Status:  closed
  (models, ORM)  |  Version:  master
 Severity:  major|   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Russell Keith-Magee ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"d818e0c9b2b88276cc499974f9eee893170bf0a8"]:
 {{{
 #!CommitTicketReference repository=""
 revision="d818e0c9b2b88276cc499974f9eee893170bf0a8"
 Fixed #16905 -- Added extensible checks (nee validation) framework

 This is the result of Christopher Medrela's 2013 Summer of Code project.

 Thanks also to Preston Holmes, Tim Graham, Anssi Kääriäinen, Florian
 Apolloner, and Alex Gaynor for review notes along the way.

 Also: Fixes #8579, fixes #3055, fixes #19844.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.bcdce6bf6f559e31b274f623457666a9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #3055: GenericRelation should squawk if pointed to a model that doesn't have a GenericForeignKey on it

[Django]

#3055: GenericRelation should squawk if pointed to a model that doesn't have a
GenericForeignKey on it
-+-
 Reporter:  panta@…  |Owner:
 Type:  defect   |  marcosmoyano
Component:  Database layer   |   Status:  reopened
  (models, ORM)  |  Version:  SVN
 Severity:  major|   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by lrekucki):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #3055: GenericRelation should squawk if pointed to a model that doesn't have a GenericForeignKey on it

[Django]

#3055: GenericRelation should squawk if pointed to a model that doesn't have a
GenericForeignKey on it
-+-
   Reporter:  panta@…|  Owner:  marcosmoyano
   Type:  defect | Status:  reopened
  Milestone: |  Component:  Database layer
Version:  SVN|  (models, ORM)
 Resolution: |   Severity:  major
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
  UI/UX:  0  |  Easy pickings:  0
-+-

Comment (by carljm):

 This blocks on #16905 (extensible validation).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #3055: GenericRelation should squawk if pointed to a model that doesn't have a GenericForeignKey on it

[Django]

#3055: GenericRelation should squawk if pointed to a model that doesn't have a
GenericForeignKey on it
-+-
   Reporter:  panta@…|  Owner:  marcosmoyano
   Type:  defect | Status:  reopened
  Milestone: |  Component:  Database layer
Version:  SVN|  (models, ORM)
 Resolution: |   Severity:  major
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
  UI/UX:  0  |  Easy pickings:  0
-+-
Changes (by mtredinnick):

 * stage:  Ready for checkin => Accepted


Comment:

 Moving out of "ready for checkin" status, since the patch requires
 rethinking.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #3055: GenericRelation should squawk if pointed to a model that doesn't have a GenericForeignKey on it

[Django]

#3055: GenericRelation should squawk if pointed to a model that doesn't have a
GenericForeignKey on it
-+-
   Reporter:  panta@…|  Owner:  marcosmoyano
   Type:  defect | Status:  reopened
  Milestone: |  Component:  Database layer
Version:  SVN|  (models, ORM)
 Resolution: |   Severity:  major
   Triage Stage:  Ready for  |   Keywords:
  checkin|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-

Comment (by ramiro):

 In [16541]:
 {{{
 #!CommitTicketReference repository="" revision="16541"
 [1.3.X] Reverted [14563] because it introduced a dependency from core on a
 contrib app (contenttypes). Fixes #16283, Refs #3055. Thanks TheRoSS for
 the report and Aymeric Augustin for finding the problem.

 This caused models shipped with some contrib apps to pollute the namespace
 when user's apps had the same name (e.g. auth, sites), even when these
 contrib apps weren't installed.

 This undesired loading of contrib apps happened when model validation was
 executed, for example when running management commands that set or inherit
 `requires_model_validation=True`:
 cleanup, dumpdata, flush, loaddata, reset, runfcgi, sql, sqlall, sqlclear,
 sqlcustom, sqlflush, sqlindexes, sqlinitialdata, sqlreset,
 sqlsequencereset, syncdb, createsuperusers, ping_google, collectstatic,
 findstatic.

 This could also cause hard to diagnose problems e.g. when performing
 reverse URL resolving.

 Backport of [16493] from trunk.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #3055: GenericRelation should squawk if pointed to a model that doesn't have a GenericForeignKey on it

[Django]

#3055: GenericRelation should squawk if pointed to a model that doesn't have a
GenericForeignKey on it
-+-
   Reporter:  panta@…|  Owner:  marcosmoyano
   Type:  defect | Status:  reopened
  Milestone: |  Component:  Database layer
Version:  SVN|  (models, ORM)
 Resolution: |   Severity:  major
   Triage Stage:  Ready for  |   Keywords:
  checkin|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by ramiro):

 * status:  closed => reopened
 * resolution:  fixed =>


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #3055: GenericRelation should squawk if pointed to a model that doesn't have a GenericForeignKey on it

[Django]

#3055: GenericRelation should squawk if pointed to a model that doesn't have a
GenericForeignKey on it
-+-
   Reporter:  panta@…|  Owner:  marcosmoyano
   Type:  defect | Status:  closed
  Milestone: |  Component:  Database layer
Version:  SVN|  (models, ORM)
 Resolution:  fixed  |   Severity:  major
   Triage Stage:  Ready for  |   Keywords:
  checkin|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-

Comment (by ramiro):

 In [16493]:
 {{{
 #!CommitTicketReference repository="" revision="16493"
 Reverted [14563] because it introduced a dependency from core on a contrib
 app (contenttypes). Fixes #16283, Refs #3055. Thanks TheRoSS for the
 report and Aymeric Augustin for finding the problem.

 This caused models shipped with some contrib apps to pollute the namespace
 when user's apps had the same name (e.g. auth, sites), even when these
 contrib apps weren't installed.

 This undesired loading of contrib apps happened when model validation was
 executed, for example when running management commands that set or inherit
 `requires_model_validation=True`:
 cleanup, dumpdata, flush, loaddata, reset, runfcgi, sql, sqlall, sqlclear,
 sqlcustom, sqlflush, sqlindexes, sqlinitialdata, sqlreset,
 sqlsequencereset, syncdb, createsuperusers, ping_google, collectstatic,
 findstatic.

 This could also cause hard to diagnose problems e.g. when performing
 reverse URL resolving.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #3055: GenericRelation should squawk if pointed to a model that doesn't have a GenericForeignKey on it

[Django]

#3055: GenericRelation should squawk if pointed to a model that doesn't have a
GenericForeignKey on it
-+-
   Reporter:  panta@…|  Owner:  marcosmoyano
   Type:  defect | Status:  closed
  Milestone: |  Component:  Database layer
Version:  SVN|  (models, ORM)
 Resolution:  fixed  |   Severity:  major
   Triage Stage:  Ready for  |   Keywords:
  checkin|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by ramiro):

 * ui_ux:   => 0
 * easy:   => 0


Comment:

 This change has introduced a dependancy of core on contrib apps reported
 by tickets #16283 and #16368.

 Long term solution for validate core management command extensibility is
 what #8579 asks for.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #3055: GenericRelation should squawk if pointed to a model that doesn't have a GenericForeignKey on it

[Django]

#3055: GenericRelation should squawk if pointed to a model that doesn't have a
GenericForeignKey on it
---+
  Reporter:  pa...@elasticworld.org| Owner:  
marcosmoyano
Status:  closed| Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  SVN
 
Resolution:  fixed |  Keywords: 
 
 Stage:  Ready for checkin | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by ramiro):

  * status:  assigned => closed
  * resolution:  => fixed

Comment:

 Fixed in r14563.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #3055: GenericRelation should squawk if pointed to a model that doesn't have a GenericForeignKey on it

[Django]

#3055: GenericRelation should squawk if pointed to a model that doesn't have a
GenericForeignKey on it
---+
  Reporter:  pa...@elasticworld.org| Owner:  
marcosmoyano
Status:  assigned  | Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  SVN
 
Resolution:|  Keywords: 
 
 Stage:  Ready for checkin | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by ramiro):

  * has_patch:  0 => 1

Comment:

 Nit: consider changing slightly  the validation message to '"model '%s'
 must have a GenericForeignKey in order to create a GenericRelation
 pointing to it."' or similar.

 Other that that, this is RFC.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #3055: GenericRelation should squawk if pointed to a model that doesn't have a GenericForeignKey on it

[Django]

#3055: GenericRelation should squawk if pointed to a model that doesn't have a
GenericForeignKey on it
---+
  Reporter:  pa...@elasticworld.org| Owner:  
marcosmoyano
Status:  assigned  | Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  SVN
 
Resolution:|  Keywords: 
 
 Stage:  Ready for checkin | Has_patch:  0  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by marcosmoyano):

  * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #3055: GenericRelation should squawk if pointed to a model that doesn't have a GenericForeignKey on it

[Django]

#3055: GenericRelation should squawk if pointed to a model that doesn't have a
GenericForeignKey on it
---+
  Reporter:  pa...@elasticworld.org| Owner:  
marcosmoyano
Status:  assigned  | Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  SVN
 
Resolution:|  Keywords: 
 
 Stage:  Accepted  | Has_patch:  0  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by marcosmoyano):

  * owner:  nobody => marcosmoyano
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #3055: GenericRelation should squawk if pointed to a model that doesn't have a GenericForeignKey on it

[Django]

#3055: GenericRelation should squawk if pointed to a model that doesn't have a
GenericForeignKey on it
---+
  Reporter:  pa...@elasticworld.org| Owner:  nobody
Status:  new   | Milestone:
 Component:  Database layer (models, ORM)  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by carljm):

  * summary:  Deleting an object with two generic relations to different
  but related models (via a ForeignKey)
  apparently generates incorrect SQL =>
  GenericRelation should squawk if pointed to a
  model that doesn't have a GenericForeignKey on
  it

Comment:

 Jason's comment is correct. The SQL is wrong because the models are wrong.
 It's not legit to point a GenericRelation at a model which doesn't have a
 GenericForeignKey.

 However, the result should not be bad SQL when you try to delete;
 GenericRelations should fail fast if they are invalid. Updating the
 summary accordingly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.