Re: [Django] #30729: Add support for the RFC 7239 Forwarded header

[Django]

#30729: Add support for the RFC 7239 Forwarded header
---+-
 Reporter:  Ben Stähli |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Someday/Maybe
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Ryan Hiebert):

 * cc: Ryan Hiebert (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e6e8f98ba-50f561c3-aa68-4a13-9a61-4b65f0266e9e-00%40eu-central-1.amazonses.com.

Re: [Django] #30729: Add support for the RFC 7239 Forwarded header

[Django]

#30729: Add support for the RFC 7239 Forwarded header
---+-
 Reporter:  Ben Stähli |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Someday/Maybe
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Ülgen Sarıkavak):

 * cc: Ülgen Sarıkavak (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e313e6e17-56d68401-706c-4cbc-a728-64fcae9164b4-00%40eu-central-1.amazonses.com.

Re: [Django] #30729: Add support for the RFC 7239 Forwarded header

[Django]

#30729: Add support for the RFC 7239 Forwarded header
---+-
 Reporter:  Ben Stähli |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Someday/Maybe
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by braiam):

 * cc: braiam (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187d3b2663d-fc5f1ced-7aae-4497-a7ae-2969b19e01d7-00%40eu-central-1.amazonses.com.

Re: [Django] #30729: Add support for the RFC 7239 Forwarded header

[Django]

#30729: Add support for the RFC 7239 Forwarded header
---+-
 Reporter:  Ben Stähli |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Someday/Maybe
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Maciej Olko):

 * cc: Maciej Olko (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070185e71fcd12-41881401-4b9f-4577-94ed-7812cd349914-00%40eu-central-1.amazonses.com.

Re: [Django] #30729: Add support for the RFC 7239 Forwarded header

[Django]

#30729: Add support for the RFC 7239 Forwarded header
---+-
 Reporter:  Ben Stähli |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Someday/Maybe
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Adam (Chainz) Johnson):

 * cc: Adam (Chainz) Johnson (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.294fc7afc918a8482c43de59b2c56d97%40djangoproject.com.

Re: [Django] #30729: Add support for the RFC 7239 Forwarded header

[Django]

#30729: Add support for the RFC 7239 Forwarded header
---+-
 Reporter:  Ben Stähli |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Someday/Maybe
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Narbonne):

 * cc: Narbonne (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9d75b9ecc474b8e3a77e78354c0b0d76%40djangoproject.com.

Re: [Django] #30729: Add support for the RFC 7239 Forwarded header

[Django]

#30729: Add support for the RFC 7239 Forwarded header
---+-
 Reporter:  Ben Stähli |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Someday/Maybe
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by Ben Stähli):

 add support means all aspects of the new header need to be covered. as far
 as I can see, this touches at least these settings:

 - SECURE_PROXY_SSL_HEADER
 https://docs.djangoproject.com/en/3.0/ref/settings/#secure-proxy-ssl-
 header
 - USE_X_FORWARDED_HOST
 https://docs.djangoproject.com/en/3.0/ref/settings/#use-x-forwarded-host
 - USE_X_FORWARDED_PORT
 https://docs.djangoproject.com/en/3.0/ref/settings/#use-x-forwarded-port

 and, the parsing and security part is not to underestimate, as it's only
 one header, that must be parsed.

 Replying to [comment:5 Santiago Basulto]:
 > I'd be tempted to take over this. I'd like to know what would "add
 support" involves. Is it just trusting hosts based on X-Forwarded as we do
 with [https://docs.djangoproject.com/en/3.0/ref/settings/#use-x-forwarded-
 host x-forwarded-host]?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.988f282b0f6ac591b0ecf617fd68f7df%40djangoproject.com.

Re: [Django] #30729: Add support for the RFC 7239 Forwarded header

[Django]

#30729: Add support for the RFC 7239 Forwarded header
---+-
 Reporter:  Ben Stähli |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Someday/Maybe
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by Santiago Basulto):

 I'd be tempted to take over this. I'd like to know what would "add
 support" involves. Is it just trusting hosts based on X-Forwarded as we do
 with [x-forwarded-
 host](https://docs.djangoproject.com/en/3.0/ref/settings/#use-x-forwarded-
 host)?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f8bcbde70268f7078d4a981901e79212%40djangoproject.com.

Re: [Django] #30729: Add support for the RFC 7239 Forwarded header

[Django]

#30729: Add support for the RFC 7239 Forwarded header
---+-
 Reporter:  Ben Stähli |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Someday/Maybe
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Carlton Gibson):

 * component:  Uncategorized => HTTP handling
 * type:  Uncategorized => New feature
 * stage:  Unreviewed => Someday/Maybe


Comment:

 I'm tempted to say `needsinfo` here, but, yes there's the RFC so I guess
 we should pick it up at some point.

 A case insenstive search for `x[-_]forwarded` doesn't turn up too many
 results, so in theory it's easy enough... **but** we'd need to think about
 supporting both approaches, probably indefinitely, and provide decent
 documentation around that, and a migration to the new header from the old
 (ones).

 I'd like to see some detail on all that before we say "Yes, let's go!
 ''Accepted''". As such we'll call it ''Someday/Maybe'' for now. (Happy to
 see more detail and/or an adjustment if someone wants to push it forward.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.68db83311ce23a9b096b70d1dabb41b5%40djangoproject.com.

Re: [Django] #30729: Add support for the RFC 7239 Forwarded header

[Django]

#30729: Add support for the RFC 7239 Forwarded header
---+--
 Reporter:  Ben Stähli |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Ben Stähli):

 Not really. But it would be a good thing to go ahead and support it,
 otherwise it will never be adopted. Also, it is an RFC, so I guess it will
 probably become the new standard. Tomorrow, or in some years only, who
 knows.

 A quick research shows that some frameworks are discussing it.

 -
 https://duckduckgo.com/?q=is+RFC-7239+forwarded+support=canonical=web
 - https://github.com/aspnet/AspNetCore/issues/5978
 - https://issues.jboss.org/browse/UNDERTOW-1207?_sscc=t
 - http://tomcat.10.x6.nabble.com/Bug-63080-New-Support-rfc7239-Forwarded-
 header-td5081951.html
 - https://groups.google.com/forum/#!msg/golang-
 nuts/wc45kx0bsr8/BX1Dds8cAwAJ

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.8b1d32789d79fd16cf9a247645d5019c%40djangoproject.com.

Re: [Django] #30729: Add support for the RFC 7239 Forwarded header (was: Forwarded Header)

[Django]

#30729: Add support for the RFC 7239 Forwarded header
---+--
 Reporter:  Ben Stähli |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Claude Paroz):

 Can you tell us a bit more about the current adoption state of this
 header?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.2b6b6030fe1f3b693aad32a367f010ee%40djangoproject.com.