Re: [Django] #32051: Animation issues with rocket on Congrats new project page

[Django]

#32051: Animation issues with rocket on Congrats new project page
-+-
 Reporter:  Thibaud Colas|Owner:  Thibaud
 |  Colas
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  accessibility, ui| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b807298c666711ba106b06fef05a25073c62b802" b807298]:
 {{{
 #!CommitTicketReference repository=""
 revision="b807298c666711ba106b06fef05a25073c62b802"
 Fixed #32051 -- Fixed rocket animation on the 'Congrats' page.

 - Fixed congratulations smoke being cropped.
 - Refactored congratulation rocket so the animation can be stopped.
 - Made animation respect user preference for reduced animation.
 - Made rocket animation stop after 7s.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.2dcea5ce8996a6be24f0e7a69b596239%40djangoproject.com.

Re: [Django] #32051: Animation issues with rocket on Congrats new project page

[Django]

#32051: Animation issues with rocket on Congrats new project page
-+-
 Reporter:  Thibaud Colas|Owner:  Thibaud
 |  Colas
 Type:  Bug  |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility, ui| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"838e115ab159174f759f09d63398e1eed14e4dbe" 838e115a]:
 {{{
 #!CommitTicketReference repository=""
 revision="838e115ab159174f759f09d63398e1eed14e4dbe"
 Refs #32051 -- Cleaned up CSS and SVG in the 'Congrats' page.

 - Removed unnecessary vendor prefixes.
 - Removed unused CSS and SVG code.
 - Removed invalid CSS.
 - Removed IE9-only browser reset styles.
 - Fixed animation on Firefox.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.939b79beabd0fe74092b89339b3f2ccd%40djangoproject.com.

Re: [Django] #32051: Animation issues with rocket on Congrats new project page

[Django]

#32051: Animation issues with rocket on Congrats new project page
-+-
 Reporter:  Thibaud Colas|Owner:  Thibaud
 |  Colas
 Type:  Bug  |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility, ui| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by felixxm):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.90d672d5f02a3b811fcd7ebc22d5b104%40djangoproject.com.

Re: [Django] #32051: Animation issues with rocket on Congrats new project page

[Django]

#32051: Animation issues with rocket on Congrats new project page
---+--
 Reporter:  Thibaud Colas  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Core (Other)   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  accessibility, ui  | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Description changed by Thibaud Colas:

Old description:

> There are a number of issues with the rocket animation shown on the
> Congrats page. In no specific order,
>
> - The page take up between 10 and 30% of my CPU to render the animations
> on a MacBook Pro from 2015.
> - Firefox has a different animation from other browsers, where the rocket
> `exhaust__line` extends further than it should.
> - For other browsers (tested in Chrome and Safari on macOS), the smoke is
> cropped to the sides because of root-level SVGs being `overflow: hidden`.
> - The animation doesn’t respect [`prefers-reduced-motion:
> reduce`](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-
> reduced-motion) (more of an enhancement).
>
> I’ve taken a stab at addressing these, and cleaning up unused CSS and
> SVG, in https://github.com/django/django/pull/13463.

New description:

 There are a number of issues with the rocket animation shown on the
 Congrats page. In no specific order,

 - The page take up between 10 and 30% of my CPU to render the animations
 on a MacBook Pro from 2015.
 - Firefox has a different animation from other browsers, where the rocket
 `exhaust__line` extends further than it should.
 - For other browsers (tested in Chrome and Safari on macOS), the smoke is
 cropped to the sides because of root-level SVGs being `overflow: hidden`.
 - The animation doesn’t respect [https://developer.mozilla.org/en-
 US/docs/Web/CSS/@media/prefers-reduced-motion `prefers-reduced-motion:
 reduce`] (more of an enhancement).

 I’ve taken a stab at addressing these, and cleaning up unused CSS and SVG,
 in https://github.com/django/django/pull/13463.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.68b8299855aa0360043727a44894a858%40djangoproject.com.

Re: [Django] #32051: Animation issues with rocket on Congrats new project page

[Django]

#32051: Animation issues with rocket on Congrats new project page
---+--
 Reporter:  thibaudcolas   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Core (Other)   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  accessibility, ui  | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by thibaudcolas):

 * keywords:   => accessibility, ui
 * ui_ux:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.a2b74981ccd675b340c2f8577b034f71%40djangoproject.com.

Re: [Django] #32051: Animation issues with rocket on Congrats new project page (was: Animation issues with rocket on Congrats page)

[Django]

#32051: Animation issues with rocket on Congrats new project page
---+--
 Reporter:  Thibaud Colas  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Core (Other)   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.c908fade3d573f044486486d2c529bf1%40djangoproject.com.