Re: [Django] #32639: ADMINS and MANAGERS may contain invalid email addreses

[Django]

#32639: ADMINS and MANAGERS may contain invalid email addreses
-+-
 Reporter:  Matthias Kestenholz  |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Core (System |  Version:  4.0
  checks)|
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Matthias Kestenholz):

 Thanks!

 I tend to agree that adding checks is bothersome, especially since I have
 been bitten by new checks in the past.  However, `mail_managers` and
 friends will choke later anyway and it would be better to catch typos
 earlier. Django's `EmailValidator` is battle tested and has been
 essentially unchanged since 2015 and building on this should (yeah I know,
 famous last words) be safe. `root@localhost` etc. are valid according to
 the `EmailValidator` so I really have a hard time imagining regressions.
 Also, such regressions would be detected very early, when starting up the
 application server, not in the middle of the night when everyone is
 sleeping.

 Because of these points I still think this new check would be a good idea.

 Of course it is your call. Thanks again :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.41f4173c36c83ffa0b8ab0166909888f%40djangoproject.com.

Re: [Django] #32639: ADMINS and MANAGERS may contain invalid email addreses

[Django]

#32639: ADMINS and MANAGERS may contain invalid email addreses
-+-
 Reporter:  Matthias Kestenholz  |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Core (System |  Version:  4.0
  checks)|
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 Thanks for this proposition, however I don't think that we need extra
 checks, because we will probably introduce some regressions with them
 (like we did in the past). Email validation is too fragile.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7f71dc99dafdf36647f053d22f362aa2%40djangoproject.com.

Re: [Django] #32639: ADMINS and MANAGERS may contain invalid email addreses

[Django]

#32639: ADMINS and MANAGERS may contain invalid email addreses
-+-
 Reporter:  Matthias Kestenholz  |Owner:  nobody
 Type:  New feature  |   Status:  assigned
Component:  Core (System |  Version:  4.0
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Matthias Kestenholz):

 [https://github.com/django/django/pull/14254 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cf36a15bf6b001edda9f952b0cccd4c5%40djangoproject.com.