Re: [Django] #33229: BaseDatabaseOperations.adapt_datetimefield_value and adapt_timefield_value() crash on expressions

[Django]

#33229: BaseDatabaseOperations.adapt_datetimefield_value and
adapt_timefield_value() crash on expressions
-+-
 Reporter:  Tim Graham   |Owner:
 |  SwastikTripathi
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a7e7043c8746933dafce652507d3b821801cdc7d" a7e7043c]:
 {{{
 #!CommitTicketReference repository=""
 revision="a7e7043c8746933dafce652507d3b821801cdc7d"
 Fixed #33229 -- Fixed
 BaseDatabaseOperations.adapt_datetimefield_value()/adapt_timefield_value()
 crash with expressions.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.814fd2c4723213c6d4236818b4b350bc%40djangoproject.com.

Re: [Django] #33229: BaseDatabaseOperations.adapt_datetimefield_value and adapt_timefield_value() crash on expressions

[Django]

#33229: BaseDatabaseOperations.adapt_datetimefield_value and
adapt_timefield_value() crash on expressions
-+-
 Reporter:  Tim Graham   |Owner:
 |  SwastikTripathi
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4a982678ced1cebc05434eef2b98876f%40djangoproject.com.

Re: [Django] #33229: BaseDatabaseOperations.adapt_datetimefield_value and adapt_timefield_value() crash on expressions

[Django]

#33229: BaseDatabaseOperations.adapt_datetimefield_value and
adapt_timefield_value() crash on expressions
-+-
 Reporter:  Tim Graham   |Owner:
 |  SwastikTripathi
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/15081 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.48a8c725d3de08222a1d8d4d3d339304%40djangoproject.com.

Re: [Django] #33229: BaseDatabaseOperations.adapt_datetimefield_value and adapt_timefield_value() crash on expressions

[Django]

#33229: BaseDatabaseOperations.adapt_datetimefield_value and
adapt_timefield_value() crash on expressions
-+-
 Reporter:  Tim Graham   |Owner:
 |  SwastikTripathi
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by SwastikTripathi):

 * owner:  (none) => SwastikTripathi
 * status:  new => assigned
 * has_patch:  0 => 1


Comment:

 I'm adding {{{ if hasattr(value, 'resolve_expression'):}}} the condition
 to adapt_datetimefield_value() and adapt_timefield_value() in
 django/db/backends/postgresql/operations.py and
 django/db/backends/base/operations.py

 Do you know why it wasn't added there?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.01779f793a65627737da93a01a6e9c73%40djangoproject.com.

Re: [Django] #33229: BaseDatabaseOperations.adapt_datetimefield_value and adapt_timefield_value() crash on expressions

[Django]

#33229: BaseDatabaseOperations.adapt_datetimefield_value and
adapt_timefield_value() crash on expressions
-+-
 Reporter:  Tim Graham   |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  Vishal Pandey => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d24ebabce680d2af1812c840bbba2368%40djangoproject.com.

Re: [Django] #33229: BaseDatabaseOperations.adapt_datetimefield_value and adapt_timefield_value() crash on expressions

[Django]

#33229: BaseDatabaseOperations.adapt_datetimefield_value and
adapt_timefield_value() crash on expressions
-+-
 Reporter:  Tim Graham   |Owner:  Vishal
 |  Pandey
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report. We should probably add the same to the
 `BaseDatabaseOperations.adapt_datefield_value()`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8c4137a4b305991d385614c851196411%40djangoproject.com.

Re: [Django] #33229: BaseDatabaseOperations.adapt_datetimefield_value and adapt_timefield_value() crash on expressions

[Django]

#33229: BaseDatabaseOperations.adapt_datetimefield_value and
adapt_timefield_value() crash on expressions
-+-
 Reporter:  Tim Graham   |Owner:  Vishal
 |  Pandey
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Vishal Pandey):

 * owner:  nobody => Vishal Pandey
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5338487f6b2f9de74005e4c066a5f666%40djangoproject.com.