Re: [Django] #33391: Clarify Aggregate.empty_result_set_value docs.

[Django]

#33391: Clarify Aggregate.empty_result_set_value docs.
-+-
 Reporter:  Claude Paroz |Owner:  Mariusz
 Type:   |  Felisiak
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"fe59bf202d35467e3e4a169c1aac979b713a020a" fe59bf2]:
 {{{
 #!CommitTicketReference repository=""
 revision="fe59bf202d35467e3e4a169c1aac979b713a020a"
 [4.0.x] Fixed #33391 -- Clarified Aggregate.empty_result_set_value docs.

 Backport of 4400d8568ad5695c46e8de45635a82a27a26b871 from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.44569e8004bd0adeb31a867bb96c37e3%40djangoproject.com.

Re: [Django] #33391: Clarify Aggregate.empty_result_set_value docs.

[Django]

#33391: Clarify Aggregate.empty_result_set_value docs.
-+-
 Reporter:  Claude Paroz |Owner:  Mariusz
 Type:   |  Felisiak
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"4400d8568ad5695c46e8de45635a82a27a26b871" 4400d856]:
 {{{
 #!CommitTicketReference repository=""
 revision="4400d8568ad5695c46e8de45635a82a27a26b871"
 Fixed #33391 -- Clarified Aggregate.empty_result_set_value docs.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f680174a1d74ff489cf8f7d4133868ff%40djangoproject.com.

Re: [Django] #33391: Clarify Aggregate.empty_result_set_value docs.

[Django]

#33391: Clarify Aggregate.empty_result_set_value docs.
-+-
 Reporter:  Claude Paroz |Owner:  Mariusz
 Type:   |  Felisiak
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 [https://github.com/django/django/pull/15263 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6e77faa102553c5198987a35de7ce6a9%40djangoproject.com.

Re: [Django] #33391: Clarify Aggregate.empty_result_set_value docs.

[Django]

#33391: Clarify Aggregate.empty_result_set_value docs.
-+-
 Reporter:  Claude Paroz |Owner:  Mariusz
 Type:   |  Felisiak
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * owner:  nobody => Mariusz Felisiak
 * status:  new => assigned
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.dc4481d99601d394801ab701b4e22c1f%40djangoproject.com.

Re: [Django] #33391: Clarify Aggregate.empty_result_set_value docs.

[Django]

#33391: Clarify Aggregate.empty_result_set_value docs.
--+
 Reporter:  Claude Paroz  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Claude Paroz):

 * has_patch:  0 => 1


Comment:

 Ah thanks, now I understand (even the original sentence!). The new
 proposal is a lot better!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.95a7f3b4e3b3405d93f523540623e86f%40djangoproject.com.

Re: [Django] #33391: Clarify Aggregate.empty_result_set_value docs. (was: Meaning of empty_result_set_value documentation)

[Django]

#33391: Clarify Aggregate.empty_result_set_value docs.
--+
 Reporter:  Claude Paroz  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted


Comment:

 `Aggregate.empty_result_set_value` defaults to `None` which is fine for
 most (all?) aggregates, so I'd clarify this in docs, e.g.:
 {{{#!diff
 diff --git a/docs/ref/models/expressions.txt
 b/docs/ref/models/expressions.txt
 index 5ea7f9f0aa..208b810048 100644
 --- a/docs/ref/models/expressions.txt
 +++ b/docs/ref/models/expressions.txt
 @@ -418,9 +418,8 @@ The ``Aggregate`` API is as follows:

  .. versionadded:: 4.0

 -Override
 :attr:`~django.db.models.Expression.empty_result_set_value` to
 -``None`` since most aggregate functions result in ``NULL`` when
 applied
 -to an empty result set.
 +Defaults to ``None`` since most aggregate functions result in
 ``NULL``
 +when applied to an empty result set.

  The ``expressions`` positional arguments can include expressions,
 transforms of
  the model field, or the names of model fields. They will be converted to
 a
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.2786ff4d4134189bdd0ba50e7f4630b7%40djangoproject.com.