Re: [Django] #33681: Cache OPTIONS are not passed to the Redis client.

2022-05-15 Thread Django 
#33681: Cache OPTIONS are not passed to the Redis client.
-+-
 Reporter:  Ben Picolo   |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  closed
Component:  Core (Cache system)  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"5c6ebe19cca28a96518325bd16435c9e555bc13c" 5c6ebe19]:
 {{{
 #!CommitTicketReference repository=""
 revision="5c6ebe19cca28a96518325bd16435c9e555bc13c"
 [4.0.x] Fixed #33681 -- Made Redis client pass CACHES["OPTIONS"] to a
 connection pool.

 Thanks Ben Picolo for the report.
 Backport of d27e6b233f83c3429f21ff3c250a28ff302637ef from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180cb17f15d-7eb3526d-3a3f-4fc4-b34d-e396f7d2868f-00%40eu-central-1.amazonses.com.

Re: [Django] #33681: Cache OPTIONS are not passed to the Redis client.

2022-05-15 Thread Django 
#33681: Cache OPTIONS are not passed to the Redis client.
-+-
 Reporter:  Ben Picolo   |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  closed
Component:  Core (Cache system)  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"d27e6b233f83c3429f21ff3c250a28ff302637ef" d27e6b23]:
 {{{
 #!CommitTicketReference repository=""
 revision="d27e6b233f83c3429f21ff3c250a28ff302637ef"
 Fixed #33681 -- Made Redis client pass CACHES["OPTIONS"] to a connection
 pool.

 Thanks Ben Picolo for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180cb16d28b-fc475eaa-b6d7-49c4-8b9a-9a4a8366d954-00%40eu-central-1.amazonses.com.

Re: [Django] #33681: Cache OPTIONS are not passed to the Redis client.

2022-05-13 Thread Django 
#33681: Cache OPTIONS are not passed to the Redis client.
-+-
 Reporter:  Ben Picolo   |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/15684 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180bd22197f-d3e99e78-cd02-4064-b8c7-0419cce806a9-00%40eu-central-1.amazonses.com.

Re: [Django] #33681: Cache OPTIONS are not passed to the Redis client.

2022-05-12 Thread Django 
#33681: Cache OPTIONS are not passed to the Redis client.
-+-
 Reporter:  Ben Picolo   |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Mariusz Felisiak
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180b7b8941f-d75d4d42-7790-4c9b-a1b9-ea45a3a0e5a0-00%40eu-central-1.amazonses.com.

Re: [Django] #33681: Cache OPTIONS are not passed to the Redis client.

2022-05-08 Thread Django 
#33681: Cache OPTIONS are not passed to the Redis client.
-+
 Reporter:  Ben Picolo   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Mariusz Felisiak):

 Replying to [comment:7 Ben Picolo]:
 > I could probably give that a go, will see if I can take it on this
 weekend

 Sounds good!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180a747af42-5ad07f64-a30a-4d51-859c-1c0b76695bf2-00%40eu-central-1.amazonses.com.

Re: [Django] #33681: Cache OPTIONS are not passed to the Redis client.

2022-05-06 Thread Django 
#33681: Cache OPTIONS are not passed to the Redis client.
-+
 Reporter:  Ben Picolo   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Ben Picolo):

 I could probably give that a go, will see if I can take it on this weekend

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180993e0907-120d95d0-ca59-43c6-9f1a-6a5dd01d393b-00%40eu-central-1.amazonses.com.

Re: [Django] #33681: Cache OPTIONS are not passed to the Redis client. (was: Redis client OPTIONS don't work as documented, which makes setting Redis timeouts difficult)

2022-05-05 Thread Django 
#33681: Cache OPTIONS are not passed to the Redis client.
-+
 Reporter:  Ben Picolo   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Mariusz Felisiak):

 * cc: Nick Pope (added)
 * type:  Cleanup/optimization => Bug
 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report. Agreed, we should pass all options to the Redis
 client. Would you like to prepare a patch? It's probably enough to pass
 the OPTIONS to the underlying client, e.g.

 {{{#!diff
 diff --git a/django/core/cache/backends/redis.py
 b/django/core/cache/backends/redis.py
 index e0d30784ff..51701b77b3 100644
 --- a/django/core/cache/backends/redis.py
 +++ b/django/core/cache/backends/redis.py
 @@ -35,6 +35,7 @@ class RedisCacheClient:
  db=None,
  pool_class=None,
  parser_class=None,
 +**options,
  ):
  import redis

 @@ -58,6 +59,7 @@ class RedisCacheClient:
  parser_class = import_string(parser_class)
  parser_class = parser_class or self._lib.connection.DefaultParser

 +self._options = options
  self._pool_options = {"parser_class": parser_class, "db": db}

  def _get_connection_pool_index(self, write):
 @@ -81,7 +83,7 @@ class RedisCacheClient:
  # cache client can be implemented which might require the key to
 select
  # the server, e.g. sharding.
  pool = self._get_connection_pool(write)
 -return self._client(connection_pool=pool)
 +return self._client(connection_pool=pool, **self._options)

  def add(self, key, value, timeout):
  client = self.get_client(key, write=True)
 }}}

 Marking as a release blocker as this is as a bug in the new feature.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180979c5a35-2c99546c-be92-4201-bc22-043c4f88fe71-00%40eu-central-1.amazonses.com.