Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  closed
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"154dd1c0edb25f3ab1e951eef8e0c2a1e6274e87" 154dd1c]:
 {{{
 #!CommitTicketReference repository=""
 revision="154dd1c0edb25f3ab1e951eef8e0c2a1e6274e87"
 Refs #33697 -- Added backward incompatibility note about removing
 multipartparser.parse_header().
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181abd8db34-d4970fb9-01db-4607-b12f-6e70e8b7f153-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  closed
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * resolution:   => fixed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181a96d0adf-38f17a20-aae1-477d-8b36-fb1bf323690e-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"d4d5427571b4bf3a21c902276c2a00215c2a37cc" d4d54275]:
 {{{
 #!CommitTicketReference repository=""
 revision="d4d5427571b4bf3a21c902276c2a00215c2a37cc"
 Refs #33697 -- Used django.utils.http.parse_header_parameters() for
 parsing boundary streams.

 This also removes unused parse_header() and _parse_header_params()
 helpers in django.http.multipartparser.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181a96cb7b8-9c321338-291e-41d6-a86e-343f3bde9087-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181a9444bbd-c02d987c-178a-4dff-9526-78382d29748a-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"d6e0c7c30c1eb83f49345181dc63723968f297ae" d6e0c7c3]:
 {{{
 #!CommitTicketReference repository=""
 revision="d6e0c7c30c1eb83f49345181dc63723968f297ae"
 Refs #33697 -- Made MediaType use
 django.utils.http.parse_header_parameters().
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181a8f696db-9d43dc60-3a88-4d32-aa8e-461783e05c72-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 [https://github.com/django/django/pull/15797 New PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181a4ee2dcc-516f4f89-c5c1-47d7-a324-1ed3b3f0c130-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"49b470b9187b6be60e573fed08c8f4a87f133750" 49b470b9]:
 {{{
 #!CommitTicketReference repository=""
 revision="49b470b9187b6be60e573fed08c8f4a87f133750"
 Refs #33697 -- Made MultiPartParser use
 django.utils.http.parse_header_parameters() for parsing Content-Type
 header.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701812b352958-915bf5d2-3546-4ba4-a527-a56c97848d3d-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"2f974e3c1e8c2a74114b1e9f0e8257743c4d472c" 2f974e3]:
 {{{
 #!CommitTicketReference repository=""
 revision="2f974e3c1e8c2a74114b1e9f0e8257743c4d472c"
 [4.1.x] Refs #33697 -- Fixed multipart parsing of headers with double
 quotes and semicolons.

 See
 
https://github.com/python/cpython/commit/1ef0c0349e8fdb5415e21231cb42edbf232b742a

 Backport of 93cedc82f29076c824d476354527af1150888e4f from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811e6fbcd0-b6afd17b-e3e7-44d3-a268-43f588ae3003-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"93cedc82f29076c824d476354527af1150888e4f" 93cedc8]:
 {{{
 #!CommitTicketReference repository=""
 revision="93cedc82f29076c824d476354527af1150888e4f"
 Refs #33697 -- Fixed multipart parsing of headers with double quotes and
 semicolons.

 See
 
https://github.com/python/cpython/commit/1ef0c0349e8fdb5415e21231cb42edbf232b742a
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811e6fbb5a-c0aa2a34-613a-493d-a921-a567504d995a-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180ef7ee77b-b3dd553c-0750-4b34-9e14-febf3dfce9c3-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mehrdad Moradizadeh):

 I have made a [https://github.com/django/django/pull/15718 PR] this issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180e2fe3cc0-3aa98f6b-a551-455b-8d0e-fc6d14e90739-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/15718 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180e2aaef46-b1f36ac3-8120-4a8a-b724-8929206d3b0c-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mehrdad Moradizadeh):

 * owner:  nobody => Mehrdad Moradizadeh
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180d810cc97-0222df27-b032-4308-9fbc-f222f9758fc6-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
--+
 Reporter:  Carlton Gibson|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Utilities |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Carlton Gibson):

 Hi Kapil.

 There's already some coverage, so making the change ensuring the existing
 tests pass would be a start.

 On implementation, you may find you need to adjust tests, or add new ones.
 That's OK.

 If we need extra tests after that, they can be suggested on review.

 The [https://docs.djangoproject.com/en/dev/internals/contributing/writing-
 code/submitting-patches/ Submitting patches] guide should help you on your
 next steps.

 Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180bc610d12-9b41799f-97d1-4fd7-a2d8-76d5079ecfb4-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
--+
 Reporter:  Carlton Gibson|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Utilities |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Kapil Bansal):

 Hi,
 I want to give this issue a try. Although I am not sure how to run and
 check what these functions are doing?
 Would it be like creating a new django project and tests from where this
 function is called? Or something else?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180b98735e5-b56749ec-919f-4c69-88bd-3f97eedc300d-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
--+
 Reporter:  Carlton Gibson|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Utilities |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Carlton Gibson):

 +1 Yes. (And there's the list vs scalar thing... but that's just needing
 to sit and think it through clearly.) — Ideal would be to unify on a
 single version in `utils` and use in both places.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180b2ecaa2f-1d612d06-1791-4400-aa3c-8bf3aac27529-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
--+
 Reporter:  Carlton Gibson|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Utilities |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted


Comment:

 It looks that the only difference between `_parseparam()` and
 `django.http.multipartparser._parse_header_params()` is that it works on
 strings (instead of bytes) and that it contains
 
https://github.com/python/cpython/commit/1ef0c0349e8fdb5415e21231cb42edbf232b742a
 (which is desired in both places).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180b2debd36-89c53c8c-fc57-4221-befd-81010f16732b-00%40eu-central-1.amazonses.com.