Re: [Django] #33784: Formats should not be escaped in admin calendar widget.

[Django]

#33784: Formats should not be escaped in admin calendar widget.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Ankur Roy
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"5197014eff14c5744e56138e8d22cd571676f838" 5197014]:
 {{{
 #!CommitTicketReference repository=""
 revision="5197014eff14c5744e56138e8d22cd571676f838"
 [4.1.x] Fixed #33784 -- Removed unnecessary format escaping in admin
 calendar widget.

 Replacements were added in fa0653cd1d791a8bce835e8992cbeab6fd70d0e7
 where we created a callback function by concatenating strings. It's
 unnecessary since d638cdc42acec608c1967f44af6be32a477c239f.

 Backport of d19a53d8e3640e8f937048bf7826c7e2229a9665 from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018178818af4-b414fd8f-1b11-4f7d-a935-bd10a1cd70ee-00%40eu-central-1.amazonses.com.

Re: [Django] #33784: Formats should not be escaped in admin calendar widget.

[Django]

#33784: Formats should not be escaped in admin calendar widget.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Ankur Roy
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"d19a53d8e3640e8f937048bf7826c7e2229a9665" d19a53d8]:
 {{{
 #!CommitTicketReference repository=""
 revision="d19a53d8e3640e8f937048bf7826c7e2229a9665"
 Fixed #33784 -- Removed unnecessary format escaping in admin calendar
 widget.

 Replacements were added in fa0653cd1d791a8bce835e8992cbeab6fd70d0e7
 where we created a callback function by concatenating strings. It's
 unnecessary since d638cdc42acec608c1967f44af6be32a477c239f.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181788035f1-adf11e51-8e29-476b-b1ea-4789fc799bfe-00%40eu-central-1.amazonses.com.

Re: [Django] #33784: Formats should not be escaped in admin calendar widget.

[Django]

#33784: Formats should not be escaped in admin calendar widget.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Ankur Roy
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  0 => 1
 * stage:  Accepted => Ready for checkin


Comment:

 [https://github.com/django/django/pull/15780 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701817806c63c-98734c18-927c-4a8f-a880-e17e252fbe00-00%40eu-central-1.amazonses.com.

Re: [Django] #33784: Formats should not be escaped in admin calendar widget.

[Django]

#33784: Formats should not be escaped in admin calendar widget.
--+-
 Reporter:  Mariusz Felisiak  |Owner:  Ankur Roy
 Type:  Bug   |   Status:  assigned
Component:  contrib.admin |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+-
Changes (by Mariusz Felisiak):

 * easy:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018161e97b1f-7e3221c1-0187-4206-856b-a685b40cf2be-00%40eu-central-1.amazonses.com.

Re: [Django] #33784: Formats should not be escaped in admin calendar widget.

[Django]

#33784: Formats should not be escaped in admin calendar widget.
--+-
 Reporter:  Mariusz Felisiak  |Owner:  Ankur Roy
 Type:  Bug   |   Status:  assigned
Component:  contrib.admin |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+-
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181615bc37e-15f379f2-3c3b-4de0-bb85-4caf35112ff6-00%40eu-central-1.amazonses.com.

Re: [Django] #33784: Formats should not be escaped in admin calendar widget.

[Django]

#33784: Formats should not be escaped in admin calendar widget.
--+--
 Reporter:  Mariusz Felisiak  |Owner:  Ankur Roy
 Type:  Bug   |   Status:  assigned
Component:  contrib.admin |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--

Comment (by Ankur Roy):

 Yes, I would. Thank you.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018161207bef-57679d14-e901-40d5-8a47-cea147423bf1-00%40eu-central-1.amazonses.com.

Re: [Django] #33784: Formats should not be escaped in admin calendar widget.

[Django]

#33784: Formats should not be escaped in admin calendar widget.
--+--
 Reporter:  Mariusz Felisiak  |Owner:  Ankur Roy
 Type:  Bug   |   Status:  assigned
Component:  contrib.admin |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by David Wobrock):

 * cc: David Wobrock (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181610ee075-68154ee1-690f-458f-aa98-f43d7c5a39d4-00%40eu-central-1.amazonses.com.

Re: [Django] #33784: Formats should not be escaped in admin calendar widget.

[Django]

#33784: Formats should not be escaped in admin calendar widget.
--+--
 Reporter:  Mariusz Felisiak  |Owner:  Ankur Roy
 Type:  Bug   |   Status:  assigned
Component:  contrib.admin |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--

Comment (by Mariusz Felisiak):

 Ankur, would you like to prepare a patch? and drop these replacements,
 e.g.
 {{{#!diff
 diff --git
 a/django/contrib/admin/static/admin/js/admin/DateTimeShortcuts.js
 b/django/contrib/admin/static/admin/js/admin/DateTimeShortcuts.js
 index ea8c155d74..aa1cae9eeb 100644
 --- a/django/contrib/admin/static/admin/js/admin/DateTimeShortcuts.js
 +++ b/django/contrib/admin/static/admin/js/admin/DateTimeShortcuts.js
 @@ -387,13 +387,7 @@
  DateTimeShortcuts.calendars[num].drawNextMonth();
  },
  handleCalendarCallback: function(num) {
 -let format = get_format('DATE_INPUT_FORMATS')[0];
 -// the format needs to be escaped a little
 -format = format.replace('\\', '')
 -.replace('\r', '\\r')
 -.replace('\n', '\\n')
 -.replace('\t', '\\t')
 -.replace("'", "\\'");
 +const format = get_format('DATE_INPUT_FORMATS')[0];
  return function(y, m, d) {
  DateTimeShortcuts.calendarInputs[num].value = new Date(y,
 m - 1, d).strftime(format);
  DateTimeShortcuts.calendarInputs[num].focus()
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181608f62a7-c43ab07f-b983-4b9e-aea9-b30bb7e13e3d-00%40eu-central-1.amazonses.com.