Re: [Django] #34045: Admin changelist checkboxes do not have labels

[Django]

#34045: Admin changelist checkboxes do not have labels
-+-
 Reporter:  Tom Carrick  |Owner:  Durval
 |  Carvalho
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"85366fbca723c9b37d0ac9db1d44e3f1cb188db2" 85366fb]:
 {{{
 #!CommitTicketReference repository=""
 revision="85366fbca723c9b37d0ac9db1d44e3f1cb188db2"
 Fixed #34045 -- Improved accessibility of selecting items in admin
 changelist.

 This adds "aria-label".
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018659afd7ea-a34fa860-f742-46b0-a854-d04019ea99dd-00%40eu-central-1.amazonses.com.

Re: [Django] #34045: Admin changelist checkboxes do not have labels

[Django]

#34045: Admin changelist checkboxes do not have labels
-+-
 Reporter:  Tom Carrick  |Owner:  Durval
 |  Carvalho
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186592276dc-4e0c11b5-6981-41cd-8139-1c1e910782e9-00%40eu-central-1.amazonses.com.

Re: [Django] #34045: Admin changelist checkboxes do not have labels

[Django]

#34045: Admin changelist checkboxes do not have labels
---+---
 Reporter:  Tom Carrick|Owner:  Durval Carvalho
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+---
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018635979ac3-4180f34f-3d87-47e0-8e88-e82e09e03b65-00%40eu-central-1.amazonses.com.

Re: [Django] #34045: Admin changelist checkboxes do not have labels

[Django]

#34045: Admin changelist checkboxes do not have labels
---+---
 Reporter:  Tom Carrick|Owner:  Durval Carvalho
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+---
Changes (by Mariusz Felisiak):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/16515 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018635976037-17aaeaad-08c8-4d40-8307-280435ef822a-00%40eu-central-1.amazonses.com.

Re: [Django] #34045: Admin changelist checkboxes do not have labels

[Django]

#34045: Admin changelist checkboxes do not have labels
---+---
 Reporter:  Tom Carrick|Owner:  Durval Carvalho
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+---
Changes (by Sarah Abderemane):

 * cc: Sarah Abderemane (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186122d5de2-05b84b19-82c9-4bbc-9c68-bf13c042f74a-00%40eu-central-1.amazonses.com.

Re: [Django] #34045: Admin changelist checkboxes do not have labels

[Django]

#34045: Admin changelist checkboxes do not have labels
---+---
 Reporter:  Tom Carrick|Owner:  Durval Carvalho
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+---

Comment (by Durval Carvalho):

 Hey, guys!

 I was working on this ticket and Mariusz Felisiak wrote that each line
 should have a defined aria label [¹]. But I'm not sure which text I should
 use. Maybe the str(instance)? What do you think?

 [¹] https://github.com/django/django/pull/16515#issuecomment-1410872283

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186092371b6-a6be9abe-341b-4df7-a36a-f5f4e3f224cb-00%40eu-central-1.amazonses.com.

Re: [Django] #34045: Admin changelist checkboxes do not have labels

[Django]

#34045: Admin changelist checkboxes do not have labels
---+---
 Reporter:  Tom Carrick|Owner:  Durval Carvalho
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+---
Changes (by Durval Carvalho):

 * owner:  Neeraj Kumar => Durval Carvalho


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186091665c5-709099dc-a371-427a-9240-6bf19908a5e8-00%40eu-central-1.amazonses.com.

Re: [Django] #34045: Admin changelist checkboxes do not have labels

[Django]

#34045: Admin changelist checkboxes do not have labels
---+
 Reporter:  Tom Carrick|Owner:  Neeraj Kumar
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+
Changes (by Neeraj Kumar):

 * owner:  nobody => Neeraj Kumar
 * status:  new => assigned
 * ui_ux:  0 => 1


Comment:

 Added a screenshot, we can use "Select all" text for checkbox label

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701838aa80339-065e1271-37d0-4963-960d-a072e2b94634-00%40eu-central-1.amazonses.com.

Re: [Django] #34045: Admin changelist checkboxes do not have labels

[Django]

#34045: Admin changelist checkboxes do not have labels
---+
 Reporter:  Tom Carrick|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Neeraj Kumar):

 * Attachment "Screenshot 2022-09-30 at 12.37.20 AM.png" added.

 Selection checkbox

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701838aa6b1e7-283d8d88-d08f-421c-afe3-1dabd8b3f919-00%40eu-central-1.amazonses.com.

Re: [Django] #34045: Admin changelist checkboxes do not have labels

[Django]

#34045: Admin changelist checkboxes do not have labels
---+
 Reporter:  Tom Carrick|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Description changed by Tom Carrick:

Old description:



New description:

 This is failing WCAG level A so is quite fundamental. Screen reader users
 currently have no way to know what these checkboxes are for. We should add
 some kind of screenreader friendly label to make it clear you're selecting
 this row for running an action.

 I'm not quite sure on the text. As the checkbox appears before the text
 describing the row I'm not sure if it'd need any extra info on the label -
 I suppose if we just added the label we'd be asking the user to select
 something that they don't yet know what it is?

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070183793592c2-553d8d6e-d191-4cd4-908a-24c398ba1071-00%40eu-central-1.amazonses.com.

Re: [Django] #34045: Admin changelist checkboxes do not have labels

[Django]

#34045: Admin changelist checkboxes do not have labels
---+
 Reporter:  Tom Carrick|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted


Comment:

 I guess we need `aria-label`s. Tentatively accepted.

 I'd be grateful for any description, by the way .

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070183792da795-c509c8b1-a3eb-4a6a-a0a5-5dfa71e0eb0a-00%40eu-central-1.amazonses.com.