Re: [Django] #34377: AdminSite.catch_all_view() drops query string in redirects

[Django]

#34377: AdminSite.catch_all_view() drops query string in redirects
-+-
 Reporter:  Dominique Bischof|Owner:  Dominique
 |  Bischof
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  4.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"17e08b2177928b02158997ee1c44d8322a2e6eb8" 17e08b21]:
 {{{
 #!CommitTicketReference repository=""
 revision="17e08b2177928b02158997ee1c44d8322a2e6eb8"
 Fixed #34377 -- Fixed preserving query strings in
 AdminSite.catch_all_view().

 Included full path when redirecting with append slash to include query
 strings.

 Regression in ba31b0103442ac891fb3cb98f316781254e366c3.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186a678141a-6146f469-e527-4ef3-acdb-5934b0599a9f-00%40eu-central-1.amazonses.com.

Re: [Django] #34377: AdminSite.catch_all_view() drops query string in redirects

[Django]

#34377: AdminSite.catch_all_view() drops query string in redirects
-+-
 Reporter:  Dominique Bischof|Owner:  Dominique
 |  Bischof
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186a6587017-03c38824-c8d6-4c13-ab78-b5d6e5eae23f-00%40eu-central-1.amazonses.com.

Re: [Django] #34377: AdminSite.catch_all_view() drops query string in redirects

[Django]

#34377: AdminSite.catch_all_view() drops query string in redirects
-+-
 Reporter:  Dominique Bischof|Owner:  Dominique
 |  Bischof
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Dominique Bischof):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/16612

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186a3e8eb56-8cbb0d82-7cab-4a01-aa3a-b3e652131f14-00%40eu-central-1.amazonses.com.

Re: [Django] #34377: AdminSite.catch_all_view() drops query string in redirects

[Django]

#34377: AdminSite.catch_all_view() drops query string in redirects
-+-
 Reporter:  Dominique Bischof|Owner:  Dominique
 |  Bischof
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jon Dufresne):

 * cc: Jon Dufresne (removed)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186a374757d-589b5ad5-cae7-494f-8448-0614027a5f08-00%40eu-central-1.amazonses.com.

Re: [Django] #34377: AdminSite.catch_all_view() drops query string in redirects

[Django]

#34377: AdminSite.catch_all_view() drops query string in redirects
-+-
 Reporter:  Dominique Bischof|Owner:  Dominique
 |  Bischof
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Dominique Bischof):

 * owner:  nobody => Dominique Bischof
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186a3686277-d5df8d1e-fe44-4ab6-be5f-43535586d1ca-00%40eu-central-1.amazonses.com.

Re: [Django] #34377: AdminSite.catch_all_view() drops query string in redirects

[Django]

#34377: AdminSite.catch_all_view() drops query string in redirects
---+
 Reporter:  Dominique Bischof  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  4.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Mariusz Felisiak):

 * cc: Carlton Gibson, Jon Dufresne (added)
 * easy:  1 => 0
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report! Using `get_full_path()` should fix the issue:

 {{{#!diff
 diff --git a/django/contrib/admin/sites.py b/django/contrib/admin/sites.py
 index 61be31d890..96c54e44ad 100644
 --- a/django/contrib/admin/sites.py
 +++ b/django/contrib/admin/sites.py
 @@ -453,7 +453,7 @@ class AdminSite:
  pass
  else:
  if getattr(match.func, "should_append_slash", True):
 -return HttpResponsePermanentRedirect("%s/" %
 request.path)
 +return
 HttpResponsePermanentRedirect(request.get_full_path(force_append_slash=True))
  raise Http404

  def _build_app_dict(self, request, label=None):
 }}}
 Would you like to prepare PR via GitHub? (a regression test is required.)

 Regression in ba31b0103442ac891fb3cb98f316781254e366c3.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186a09ac34a-b96bda3c-b5a6-4d06-a5c9-c7b35625f012-00%40eu-central-1.amazonses.com.