Re: [Django] #34380: Make URLField assume "https".

2024-01-18 Thread Django 
#34380: Make URLField assume "https".
-+-
 Reporter:  Coen van der Kamp|Owner:  Coen van
 Type:   |  der Kamp
  Cleanup/optimization   |   Status:  closed
Component:  Forms|  Version:  4.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 > Or is the way to go to use `FORMS_URLFIELD_ASSUME_HTTPS` for now,
 ignoring its `DeprecationMessage`, and to remove the setting with Django
 6.0 again?

 That was our idea (check out the entire [https://forum.djangoproject.com/t
 /stop-the-django-5-0-press-move-urlfield-assume-scheme-change-from-
 deprecation-to-hard-cut/25652/20 discussion]). If you agree for an early
 adoption of the new (Django 6.0+) default, set
 `FORMS_URLFIELD_ASSUME_HTTPS = True` and ignore it's deprecation warning
 during Django 5.X release cycle with e.g.
 `warnings.filterwarnings("ignore", "FORMS_URLFIELD_ASSUME_HTTPS",
 category=RemovedInDjango60Warning)`. In Django 6.0 you will be able to
 remove both the `FORMS_URLFIELD_ASSUME_HTTPS` setting and a `warnings`
 filter.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d1c81a8a6-de56eb22-2d10-47c5-81d5-026ff23fbc12-00%40eu-central-1.amazonses.com.

Re: [Django] #34380: Make URLField assume "https".

2024-01-18 Thread Django 
#34380: Make URLField assume "https".
-+-
 Reporter:  Coen van der Kamp|Owner:  Coen van
 Type:   |  der Kamp
  Cleanup/optimization   |   Status:  closed
Component:  Forms|  Version:  4.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Daniel Hahler):

 There is no (easy) way to pass/use `assume_scheme` via
 `django.db.models.fields.URLField` (directly), avoiding the deprecation
 messages (since using the transitional setting
 `FORMS_URLFIELD_ASSUME_HTTPS` also triggers a deprecation message
 already).

 Should `django.db.models.fields.URLField` accept/handle `assume_scheme`?

 Or is the way to go to use `FORMS_URLFIELD_ASSUME_HTTPS` for now, ignoring
 its `DeprecationMessage`, and to remove the setting with Django 6.0 again?

 Might be nice to document this then in the release notes / documentation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d1c718d68-15fb53a1-06db-4666-a29b-baf229087c64-00%40eu-central-1.amazonses.com.

Re: [Django] #34380: Make URLField assume "https".

2023-11-28 Thread Django 
#34380: Make URLField assume "https".
-+-
 Reporter:  Coen van der Kamp|Owner:  Coen van
 Type:   |  der Kamp
  Cleanup/optimization   |   Status:  closed
Component:  Forms|  Version:  4.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"92af3d4d235448446e53e982275315bedcc4c204" 92af3d4d]:
 {{{
 #!CommitTicketReference repository=""
 revision="92af3d4d235448446e53e982275315bedcc4c204"
 [5.0.x] Refs #34380 -- Added FORMS_URLFIELD_ASSUME_HTTPS transitional
 setting.

 This allows early adoption of the new default "https".

 Backport of a4931cd75a1780923b02e43475ba5447df3adb31 from main.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018c1755e03b-23d9df0a-c724-40e8-8162-58fbc1969910-00%40eu-central-1.amazonses.com.

Re: [Django] #34380: Make URLField assume "https".

2023-11-28 Thread Django 
#34380: Make URLField assume "https".
-+-
 Reporter:  Coen van der Kamp|Owner:  Coen van
 Type:   |  der Kamp
  Cleanup/optimization   |   Status:  closed
Component:  Forms|  Version:  4.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"a4931cd75a1780923b02e43475ba5447df3adb31" a4931cd7]:
 {{{
 #!CommitTicketReference repository=""
 revision="a4931cd75a1780923b02e43475ba5447df3adb31"
 Refs #34380 -- Added FORMS_URLFIELD_ASSUME_HTTPS transitional setting.

 This allows early adoption of the new default "https".
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018c17518432-17fc527a-f531-450e-9c4d-db872587702c-00%40eu-central-1.amazonses.com.

Re: [Django] #34380: Make URLField assume "https".

2023-11-25 Thread Django 
#34380: Make URLField assume "https".
-+-
 Reporter:  Coen van der Kamp|Owner:  Coen van
 Type:   |  der Kamp
  Cleanup/optimization   |   Status:  closed
Component:  Forms|  Version:  4.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"4c74dff75910ba500ce232c30742c7dfe3bcc4ea" 4c74dff]:
 {{{
 #!CommitTicketReference repository=""
 revision="4c74dff75910ba500ce232c30742c7dfe3bcc4ea"
 [5.0.x] Refs #34380 -- Improved docs for forms.URLField.assume_scheme.

 Backport of 0203771b626c27c1af24cdeb0e425ccca3d19ad5 from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018c079b-e53b2b04-8f3b-4907-b8b2-db66adc72cdf-00%40eu-central-1.amazonses.com.

Re: [Django] #34380: Make URLField assume "https".

2023-11-25 Thread Django 
#34380: Make URLField assume "https".
-+-
 Reporter:  Coen van der Kamp|Owner:  Coen van
 Type:   |  der Kamp
  Cleanup/optimization   |   Status:  closed
Component:  Forms|  Version:  4.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"0203771b626c27c1af24cdeb0e425ccca3d19ad5" 0203771]:
 {{{
 #!CommitTicketReference repository=""
 revision="0203771b626c27c1af24cdeb0e425ccca3d19ad5"
 Refs #34380 -- Improved docs for forms.URLField.assume_scheme.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018c079d7949-276dcab1-33ba-41f1-b203-0e65f07697c7-00%40eu-central-1.amazonses.com.

Re: [Django] #34380: Make URLField assume "https".

2023-04-27 Thread Django 
#34380: Make URLField assume "https".
-+-
 Reporter:  Coen van der Kamp|Owner:  Coen van
 Type:   |  der Kamp
  Cleanup/optimization   |   Status:  closed
Component:  Forms|  Version:  4.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7bbbadc69383f0a2b99253e153b974f8783e876d" 7bbbadc6]:
 {{{
 #!CommitTicketReference repository=""
 revision="7bbbadc69383f0a2b99253e153b974f8783e876d"
 Fixed #34380 -- Allowed specifying a default URL scheme in forms.URLField.

 This also deprecates "http" as the default scheme.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187c65bb2eb-f1895618-9680-45c8-ae05-b6d33b923136-00%40eu-central-1.amazonses.com.

Re: [Django] #34380: Make URLField assume "https".

2023-04-26 Thread Django 
#34380: Make URLField assume "https".
-+-
 Reporter:  Coen van der Kamp|Owner:  Coen van
 Type:   |  der Kamp
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin
 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187c16973ac-e45c2f7a-7acc-4ef3-9067-0df8d86c9111-00%40eu-central-1.amazonses.com.

Re: [Django] #34380: Make URLField assume "https".

2023-03-08 Thread Django 
#34380: Make URLField assume "https".
-+-
 Reporter:  Coen van der Kamp|Owner:  Coen van
 Type:   |  der Kamp
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Coen van der Kamp):

 I've updated the PR (improved the patch).
 https://github.com/django/django/pull/16614/files
 Not sure if I need to update something on this ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186c2b5ef5b-ae6ee3b5-05cf-4fb1-82c4-b7eda75e7c54-00%40eu-central-1.amazonses.com.

Re: [Django] #34380: Make URLField assume "https". (was: URLField assumes http)

2023-03-05 Thread Django 
#34380: Make URLField assume "https".
-+-
 Reporter:  Coen van der Kamp|Owner:  Coen van
 Type:   |  der Kamp
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => assigned
 * needs_better_patch:  0 => 1
 * owner:  nobody => Coen van der Kamp
 * needs_docs:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for this report. As far as I'm aware, we should switch the default
 to "https" via the
 [https://docs.djangoproject.com/en/stable/internals/contributing/writing-
 code/submitting-patches/#deprecating-a-feature deprecation process] (see
 #32375 for a similar change).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186b53866ca-9a2810a8-f1fe-4150-b937-620c33acb0b2-00%40eu-central-1.amazonses.com.