Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

[Django]

#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  Jason
 Type:   |  Hall
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  css, accessibility,  | Triage Stage:  Ready for
  mobile |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"53719d6b5b745dd99b1ab9315afb242f706ebbf1" 53719d6b]:
 {{{#!CommitTicketReference repository=""
 revision="53719d6b5b745dd99b1ab9315afb242f706ebbf1"
 Fixed #35321 -- Prevented Mobile Safari zoom-in on Django admin inputs.

 Thanks Simon Willison for the report and Ben Cardy for testing.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ef65bead5-78044c21-09eb-4f6a-8ce8-1d357fc178a1-00%40eu-central-1.amazonses.com.

Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

[Django]

#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  Jason
 Type:   |  Hall
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:  Ready for
  mobile |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Sarah Boyce):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ef58de94b-943aefab-0630-406c-bfff-024aad067c7b-00%40eu-central-1.amazonses.com.

Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

[Django]

#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  Jason
 Type:   |  Hall
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:  Accepted
  mobile |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Sarah Boyce):

 * needs_better_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ef1f3e289-88d18f4c-1075-4f5d-9182-21e96d853275-00%40eu-central-1.amazonses.com.

Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

[Django]

#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  Jason
 Type:   |  Hall
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:  Accepted
  mobile |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  0 => 1

Comment:

 [https://github.com/django/django/pull/18013 PR]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e73fb4f3d-911d7268-9e3a-4d1f-8e3d-84162bcecbe4-00%40eu-central-1.amazonses.com.

Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

[Django]

#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  Jason
 Type:   |  Hall
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:  Accepted
  mobile |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e710254ff-9d97c66f-b47a-473d-9d81-fe4f76901209-00%40eu-central-1.amazonses.com.

Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

[Django]

#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  Jason
 Type:   |  Hall
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:  Accepted
  mobile |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Jason Hall):

 * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e70d0271a-71fdf3e9-ca45-4f46-abba-3d76bcc14118-00%40eu-central-1.amazonses.com.

Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

[Django]

#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  Jason
 Type:   |  Hall
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:  Accepted
  mobile |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Comment (by Jason Hall):

 Then, can I just add this:

 label {
 font-size: 1rem;
 }

 to the base.css file in django/contrib/admin/static/admin/css folder?  I
 guess I'll try that and see what happens.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e70c5a9d2-ff20832e-646a-4947-8aad-f8e0057ced74-00%40eu-central-1.amazonses.com.

Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

[Django]

#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  Jason
 Type:   |  Hall
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:  Accepted
  mobile |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Jason Hall):

 * owner:  nobody => Jason Hall
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e6e1df51d-05a6ae4b-0ed0-46d1-9bed-f08ee45d163f-00%40eu-central-1.amazonses.com.

Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

[Django]

#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:  Accepted
  mobile |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Comment (by Tom Carrick):

 16px is probably a good minimum for all (non-small) text in the admin, but
 I think restricting this to just labels for now to fix this issue is a
 good first step. 1rem is probably the way to go.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e6089ee38-eca95ee7-1da2-42f0-b7cd-e5e7e07dc0f0-00%40eu-central-1.amazonses.com.

Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

[Django]

#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:  Accepted
  mobile |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Comment (by Almaz):

 So, does this ticket requires some discussion before picking it up?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e60831820-a2db20d6-188b-43aa-b893-85bfffb4177f-00%40eu-central-1.amazonses.com.

Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

[Django]

#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:  Accepted
  mobile |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * cc: Thibaud Colas, Sarah Abderemane, Tom Carrick (added)
 * stage:  Unreviewed => Accepted
 * type:  Uncategorized => Cleanup/optimization

Comment:

 Thanks for the detailed report. I'll leave a specific fix to be discussed
 and confirmed by the Accessibility Team.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e5f463dcb-5f8649ca-5d50-4048-962b-d90f87c68226-00%40eu-central-1.amazonses.com.

Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

[Django]

#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:
  mobile |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Comment (by Simon Willison):

 I also found these "form defaults" here:
 
https://github.com/django/django/blob/6f7c0a4d66f36c59ae9eafa168b455e462d81901/django/contrib/admin/static/admin/css/base.css#L471-L478


 {{{
 input, textarea, select, .form-row p, form .button {
 margin: 2px 0;
 padding: 2px 3px;
 vertical-align: middle;
 font-family: var(--font-family-primary);
 font-weight: normal;
 font-size: 0.8125rem;
 }
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e5ed0c447-281839ef-86cb-469f-be91-19cca73c354e-00%40eu-central-1.amazonses.com.

Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

[Django]

#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:
  mobile |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Comment (by Simon Willison):

 This change will likely have knock-on effects. Labels are currently set to
 0.8125rem - should they be increased to 1rem too?
 
https://github.com/django/django/blob/6f7c0a4d66f36c59ae9eafa168b455e462d81901/django/contrib/admin/static/admin/css/forms.css#L39-L43
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e5ecf74bb-ecce6e07-d99c-4bf6-953d-9cbcec3e5d32-00%40eu-central-1.amazonses.com.

Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

[Django]

#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:
  mobile |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Comment (by Simon Willison):

 Here's where the font-size is set for those fields:

 
https://github.com/django/django/blob/6f7c0a4d66f36c59ae9eafa168b455e462d81901/django/contrib/admin/static/admin/css/responsive.css#L181-L196

 It's set to font-size: 0.875rem as-of this change two years ago:
 
https://github.com/django/django/commit/1f42a352e04d2e63117f067a1432594ffbb6a8b4
 - which changed it from the previous font-size of 14px (still small enough
 to cause a zoom on Mobile Safari) to using rem values instead.

 I believe 1rem would be the equivalent of 16px.

 Here's the issue where px was swapped out for rem, to ensure browser font
 sizing worked correctly: https://code.djangoproject.com/ticket/33434
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e5ecb9d70-12c82aee-6d95-4b50-a043-5095205f55c2-00%40eu-central-1.amazonses.com.