Re: [Django] #4695: xgettext skips some translation strings in javascript files

[Django]

#4695: xgettext skips some translation strings in javascript files
---+
  Reporter:  v...@voy.cz| Owner:  ramiro
Status:  new   | Milestone:  1.2   
 Component:  Internationalization  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by ramiro):

  * owner:  nobody => ramiro
  * milestone:  => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #4695: xgettext skips some translation strings in javascript files

[Django]

#4695: xgettext skips some translation strings in javascript files
---+
  Reporter:  v...@voy.cz| Owner:  nobody
Status:  new   | Milestone:
 Component:  Internationalization  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by ramiro):

 I've attached a patch that contains the simple regular expression fix
 described by seveas plus the beginnings of regression tests for the
 translatable literal extraction functionality. Hopefully we will be able
 to expand them with more Javascript extraction corner cases and to add
 template extraction cases.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #4695: xgettext skips some translation strings in javascript files

[Django]

#4695: xgettext skips some translation strings in javascript files
---+
  Reporter:  v...@voy.cz| Owner:  nobody
Status:  new   | Milestone:
 Component:  Internationalization  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by seveas):

  * has_patch:  0 => 1
  * version:  0.96 => SVN

Comment:

 This one-line fix against current trunk (11227) would solve the problem.

 {{{
 #!diff
 Index: core/management/commands/makemessages.py
 ===
 --- core/management/commands/makemessages.py(revision 11227)
 +++ core/management/commands/makemessages.py(working copy)
 @@ -17,7 +17,7 @@
  # still sensible for us to use it, since subprocess didn't exist in 2.3.
  warnings.filterwarnings('ignore', category=DeprecationWarning,
 message=r'os\.popen3')

 -pythonize_re = re.compile(r'\n\s*//')
 +pythonize_re = re.compile(r'(?:^|\n)\s*//')

  def handle_extensions(extensions=('html',)):
  """
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #4695: xgettext skips some translation strings in javascript files

[Django]

#4695: xgettext skips some translation strings in javascript files
---+
  Reporter:  v...@voy.cz| Owner:  nobody
Status:  new   | Milestone:
 Component:  Internationalization  |   Version:  0.96  
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by dc):

 For this '''javascript''' makemessages runs pythonize_re and produces
 temporary '''.py file''':
 {{{
 // '
 gettext("foo");
 # '
 gettext("bar");
 }}}
 then calls xgettext to process it as '''perl''' source.

 If we will ignore nonsense conversions, the problem is in pythonize_re
 which is defined as
 {{{
 r'\n\s*//'
 }}}
 and will not match at the beginning of the file.

 But with all that really dirty magic the problem can be in another place.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---