Re: [Django] #5831: Template Debug highlights wrong {% for %} tag

2011-08-12 Thread Django 
#5831: Template Debug highlights wrong {% for %} tag
-+-
   Reporter:  Charmless  |  Owner:  vladmos
   | Status:  closed
   Type:  Bug|  Component:  Template system
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  debug for toplevel
 Resolution:  fixed  |  nesting
   Triage Stage:  Ready for  |  Has patch:  1
  checkin|Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by jezdez):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [16605]:
 {{{
 #!CommitTicketReference repository="" revision="16605"
 Fixed #5831 -- Made sure the ForNode reports the correct source of an
 exception happening in one of the loops. Thanks, Charmless and vladmos.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5831: Template Debug highlights wrong {% for %} tag

2011-06-26 Thread Django 
#5831: Template Debug highlights wrong {% for %} tag
-+-
   Reporter:  Charmless  |  Owner:  vladmos
   | Status:  new
   Type:  Bug|  Component:  Template system
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  debug for toplevel
 Resolution: |  nesting
   Triage Stage:  Ready for  |  Has patch:  1
  checkin|Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by lrekucki):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5831: Template Debug highlights wrong {% for %} tag

2011-06-16 Thread Django 
#5831: Template Debug highlights wrong {% for %} tag
-+-
   Reporter:  Charmless  |  Owner:  vladmos
   | Status:  new
   Type:  Bug|  Component:  Template system
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  debug for toplevel
 Resolution: |  nesting
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by vladmos):

 * cc: m@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5831: Template Debug highlights wrong {% for %} tag

2011-06-09 Thread Django 
#5831: Template Debug highlights wrong {% for %} tag
-+-
   Reporter:  Charmless  |  Owner:  vladmos
   | Status:  new
   Type:  Bug|  Component:  Template system
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  debug for toplevel
 Resolution: |  nesting
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-

Comment (by vladmos):

 Chanded order if and try..except statements. Now try..except is performed
 only when settings.TEMPLATE_DEBUG is true, so it shouldn't slower
 rendering with debugger disabled.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5831: Template Debug highlights wrong {% for %} tag

2011-06-09 Thread Django 
#5831: Template Debug highlights wrong {% for %} tag
-+-
   Reporter:  Charmless  |  Owner:  vladmos
   | Status:  new
   Type:  Bug|  Component:  Template system
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  debug for toplevel
 Resolution: |  nesting
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-

Comment (by vladmos):

 Chanded order if and try..except statements. Now try..except is performed
 only when settings.TEMPLATE_DEBUG is true, so it shouldn't slower
 rendering with debugger disabled.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5831: Template Debug highlights wrong {% for %} tag

2011-06-09 Thread Django 
#5831: Template Debug highlights wrong {% for %} tag
-+-
   Reporter:  Charmless  |  Owner:  vladmos
   | Status:  new
   Type:  Bug|  Component:  Template system
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  debug for toplevel
 Resolution: |  nesting
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by vladmos):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


Comment:

 django.template.defaulttags.ForNode.render method calls .render method for
 subnodes and there loses the information which exactly node caused the
 error, that's why DebugNodeList always marked the first forloop of nested
 as which caused the error.

 I've made a patch which adds source of the the node that actually caused
 the error as the exception's attribute, which is later intercepted by
 DebugNodeList.render method.

 Tests are included.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5831: Template Debug highlights wrong {% for %} tag

2011-06-09 Thread Django 
#5831: Template Debug highlights wrong {% for %} tag
-+-
   Reporter:  Charmless  |  Owner:  vladmos
   | Status:  new
   Type:  Bug|  Component:  Template system
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  debug for toplevel
 Resolution: |  nesting
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  1
Patch needs improvement:  1  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by vladmos):

 * status:  reopened => new
 * owner:  charmless => vladmos
 * ui_ux:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5831: Template Debug highlights wrong {% for %} tag

2011-04-29 Thread Django 
#5831: Template Debug highlights wrong {% for %} tag
-+-
   Reporter:  Charmless  |  Owner:  charmless
   | Status:  reopened
   Type:  Bug|  Component:  Template system
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  debug for toplevel
 Resolution: |  nesting
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  1
Patch needs improvement:  1  |  Easy pickings:  0
-+-
Changes (by julien):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * easy:   => 0


Comment:

 Confirming that this issue is still occurring. Needs tests to take this
 further. The patch also needs improvement as the `ForNode`'s code has
 changed since 4 years ago.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5831: Template Debug highlights wrong {% for %} tag

2009-08-21 Thread Django 
#5831: Template Debug highlights wrong {% for %} tag
--+-
  Reporter:  Charmless   | Owner:  
charmless 
Status:  reopened | Milestone:  
  
 Component:  Template system  |   Version:  SVN 
  
Resolution:   |  Keywords:  debug 
for toplevel nesting
 Stage:  Accepted | Has_patch:  1   
  
Needs_docs:  0|   Needs_tests:  0   
  
Needs_better_patch:  0|  
--+-
Comment (by nikecitycn):

 [http://www.sneakersupplier.com Nike air force ones]
 [http://www.sneakersupplier.com Air Jordan shoes]
 [http://www.sneakersupplier.com Nike Dunks]
 [http://www.sneakersupplier.com Nike Shox]
 [http://www.sneakersupplier.com Nike Shoes]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5831: Template Debug highlights wrong {% for %} tag

2009-08-20 Thread Django 
#5831: Template Debug highlights wrong {% for %} tag
--+-
  Reporter:  Charmless   | Owner:  
charmless 
Status:  reopened | Milestone:  
  
 Component:  Template system  |   Version:  SVN 
  
Resolution:   |  Keywords:  debug 
for toplevel nesting
 Stage:  Accepted | Has_patch:  1   
  
Needs_docs:  0|   Needs_tests:  0   
  
Needs_better_patch:  0|  
--+-
Comment (by nikecitycn):

 [http://www.sneakersupplier.com Nike air force ones]
 [http://www.sneakersupplier.com Air Jordan shoes]
 [http://www.sneakersupplier.com Nike Dunks]
 [http://www.sneakersupplier.com Nike Shox]
 [http://www.sneakersupplier.com Nike Shoes]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5831: Template Debug highlights wrong {% for %} tag

2008-12-29 Thread Django 
#5831: Template Debug highlights wrong {% for %} tag
--+-
  Reporter:  Charmless   | Owner:  
charmless 
Status:  reopened | Milestone:  
  
 Component:  Template system  |   Version:  SVN 
  
Resolution:   |  Keywords:  debug 
for toplevel nesting
 Stage:  Accepted | Has_patch:  1   
  
Needs_docs:  0|   Needs_tests:  0   
  
Needs_better_patch:  0|  
--+-
Changes (by kmtracey):

  * status:  closed => reopened
  * resolution:  fixed =>

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5831: Template Debug highlights wrong {% for %} tag

2008-12-29 Thread Django 
#5831: Template Debug highlights wrong {% for %} tag
--+-
  Reporter:  Charmless   | Owner:  
charmless 
Status:  closed   | Milestone:  
  
 Component:  Template system  |   Version:  SVN 
  
Resolution:  fixed|  Keywords:  debug 
for toplevel nesting
 Stage:  Accepted | Has_patch:  1   
  
Needs_docs:  0|   Needs_tests:  0   
  
Needs_better_patch:  0|  
--+-
Changes (by sunrise):

  * status:  assigned => closed
  * resolution:  => fixed

Comment:

 {{{
 #!html
 This works ok for me.. but It probably needs feedback. http://www.sneakerright.com";>djangoproject Air
 Jordan
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---