Re: [Django] #6961: loaddata fails if models directory instead of models.py

[Django]

#6961: loaddata fails if models directory instead of models.py
+---
  Reporter:  pmd| Owner:  nobody  
Status:  closed | Milestone:  
 Component:  django-admin.py|   Version:  SVN 
Resolution:  fixed  |  Keywords:  loaddata
 Stage:  Ready for checkin  | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by Alex):

  * status:  reopened => closed
  * resolution:  => fixed

Comment:

 Requiring models for various things is a seperate issue, closing this as
 the bug here was fixed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6961: loaddata fails if models directory instead of models.py

[Django]

#6961: loaddata fails if models directory instead of models.py
+---
  Reporter:  pmd| Owner:  nobody  
Status:  reopened   | Milestone:  
 Component:  django-admin.py|   Version:  SVN 
Resolution: |  Keywords:  loaddata
 Stage:  Ready for checkin  | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by xcc...@gmail.com):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 Bump on stephaner's comment.  Why are models needed at all?  Consider the
 case where you have an app for doing various things for your site.  There
 may not be any models, but there may be an initial_data fixture to add in
 a default user or Site information.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6961: loaddata fails if models directory instead of models.py

[Django]

#6961: loaddata fails if models directory instead of models.py
+---
  Reporter:  pmd| Owner:  nobody  
Status:  new| Milestone:  
 Component:  django-admin.py|   Version:  SVN 
Resolution: |  Keywords:  loaddata
 Stage:  Ready for checkin  | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by justinlilly):

  * stage:  Accepted => Ready for checkin

Comment:

 Patch looks good, applied cleanly. I've combined the tests for patch3 and
 patch3 into this patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6961: loaddata fails if models directory instead of models.py

[Django]

#6961: loaddata fails if models directory instead of models.py
--+-
  Reporter:  pmd  | Owner:  nobody  
Status:  new  | Milestone:  
 Component:  django-admin.py  |   Version:  SVN 
Resolution:   |  Keywords:  loaddata
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Comment (by stephaner):

 I'm not sure if it's related to this bug but the loaddata command works
 only if there's a models.py file (empty) in the app directory:

 That doesn't work:


 {{{
 app/__init__.py
 fixtures/data.json

 }}}

 that works:


 {{{
 app/__init__.py
 models.py
 fixtures/data.json
 }}}


 and the documentation says (or I didn't find) nothing about that
 requirement.
 Tested with trunk r11032.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6961: loaddata fails if models directory instead of models.py

[Django]

#6961: loaddata fails if models directory instead of models.py
--+-
  Reporter:  pmd  | Owner:  nobody  
Status:  new  | Milestone:  
 Component:  django-admin.py  |   Version:  SVN 
Resolution:   |  Keywords:  loaddata
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Changes (by mmalone):

 * cc: mjmal...@gmail.com (added)

Comment:

 Seems what we're really trying to do here is determine whether the models
 module (return by {{{get_apps()}}}) is a package (a directory with an
 {{{__init__.py}}} and submodules) or a normal module. According to
 [http://www.python.org/doc/essays/packages.html an essay] that was
 published when package support landed in Python, the only difference
 between a package and an ordinary module is that a package has a
 {{{__path__}}} attribute. Handily enough, the {{{__path__}}} attribute is
 an array that, by default, contains a single string pointing to the
 package directory, which is at the equivalent level in the file system
 directory hierarchy as {{{models.py}}}.

 I've attached a patch that checks the modules for the existence of a
 {{{__path__}}} attribute and handles them properly (and another patch
 containing some tests). I'm fairly confident this is the right way to do
 this, given the essay linked to above. I think this method may also be
 used to remove the Meta.app_label requirement for models submodules.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6961: loaddata fails if models directory instead of models.py

[Django]

#6961: loaddata fails if models directory instead of models.py
--+-
  Reporter:  pmd  | Owner:  nobody  
Status:  new  | Milestone:  
 Component:  django-admin.py  |   Version:  SVN 
Resolution:   |  Keywords:  loaddata
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Changes (by zhaoz):

  * needs_better_patch:  1 => 0

Comment:

 Replying to [comment:5 zhaoz]:
 > The patch did not work for me when patched against svn trunk's 9222,
 failed test.

 Scratch what I last said, it's working, but it doesn't seem to be done in
 a very elegant way.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6961: loaddata fails if models directory instead of models.py

[Django]

#6961: loaddata fails if models directory instead of models.py
--+-
  Reporter:  pmd  | Owner:  nobody  
Status:  new  | Milestone:  
 Component:  django-admin.py  |   Version:  SVN 
Resolution:   |  Keywords:  loaddata
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  1|  
--+-
Changes (by zhaoz):

  * needs_better_patch:  0 => 1

Comment:

 The patch did not work for me when patched against svn trunk's 9222,
 failed test.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6961: loaddata fails if models directory instead of models.py

[Django]

#6961: loaddata fails if models directory instead of models.py
--+-
  Reporter:  pmd  | Owner:  nobody  
Status:  new  | Milestone:  
 Component:  django-admin.py  |   Version:  SVN 
Resolution:   |  Keywords:  loaddata
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Changes (by anonymous):

 * cc: [EMAIL PROTECTED] (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6961: loaddata fails if models directory instead of models.py

[Django]

#6961: loaddata fails if models directory instead of models.py
--+-
  Reporter:  pmd  | Owner:  nobody  
Status:  new  | Milestone:  
 Component:  django-admin.py  |   Version:  SVN 
Resolution:   |  Keywords:  loaddata
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Changes (by zhaoz):

  * component:  Core framework => django-admin.py

Comment:

 What is the status of this bug? I recently bumped into this issue, it
 looks like it hasn't been touched for quite awhile.

 What needs to be done?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---