Re: [Django] #7299: XViewMiddleware raises AttributeError when authentication system is disabled

[Django]

#7299: XViewMiddleware raises AttributeError when authentication system is
disabled
---+-
 Reporter:  ishikawa_takanori  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Core (Other)   |  Version:  master
 Severity:  Normal |   Resolution:  duplicate
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by claudep):

 * status:  reopened => closed
 * resolution:   => duplicate


Comment:

 Duplicate of already fixed #14506

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #7299: XViewMiddleware raises AttributeError when authentication system is disabled

[Django]

#7299: XViewMiddleware raises AttributeError when authentication system is
disabled
-+-
   Reporter: |  Owner:  nobody
  ishikawa_takanori  | Status:  reopened
   Type:  Bug|  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by Alex):

 * ui_ux:   => 0
 * easy:   => 0
 * stage:  Design decision needed => Accepted


Comment:

 Marking as accepted, if it has a dependency it should raise an explicit
 error about that, not fail on an attribute error.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #7299: XViewMiddleware raises AttributeError when authentication system is disabled

[Django]

#7299: XViewMiddleware raises AttributeError when authentication system is
disabled
-+--
  Reporter:  ishikawa_takanori   | Owner:  nobody
Status:  reopened| Milestone:
 Component:  Core framework  |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by Debriter):

 Proposed fix (slightly different than royleban's):

 if request.method == 'HEAD' and (request.META.get('REMOTE_ADDR') in
 settings.INTERNAL_IPS or (hasattr(request, "user") and
 request.user.is_authenticated() and request.user.is_staff)):

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #7299: XViewMiddleware raises AttributeError when authentication system is disabled

[Django]

#7299: XViewMiddleware raises AttributeError when authentication system is
disabled
-+--
  Reporter:  ishikawa_takanori   | Owner:  nobody
Status:  reopened| Milestone:
 Component:  Core framework  |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by Debriter):

 I run into this problem myself as I'm using my own auth system. I couldn't
 agree more with royleban.

 Has this been committed to the main branch? I'm using django off of Ubuntu
 9.04 release and it's not fixed there.

 Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #7299: XViewMiddleware raises AttributeError when authentication system is disabled

[Django]

#7299: XViewMiddleware raises AttributeError when authentication system is
disabled
-+--
  Reporter:  ishikawa_takanori   | Owner:  nobody
Status:  reopened| Milestone:
 Component:  Core framework  |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by [EMAIL PROTECTED]):

 One more thing: Taking this statement "For this middleware to be useful,
 it needs either a non-empty INTERNAL_IPS or the auth subsystem" at face
 value explains why it's a bug. Since I only need one or the other, the
 code must not fail if I don't have the auth subsystem. And it does.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #7299: XViewMiddleware raises AttributeError when authentication system is disabled

[Django]

#7299: XViewMiddleware raises AttributeError when authentication system is
disabled
-+--
  Reporter:  ishikawa_takanori   | Owner:  nobody
Status:  reopened| Milestone:
 Component:  Core framework  |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by [EMAIL PROTECTED]):

 I think this is a bug. The code dereferences through a None value and it
 shouldn't. It occurs for HEAD requests on Google App Engine if you use
 Google Auth instead of Django auth. The previously attached diff is not
 correct. The correct fix is the following code:

 if request.method == 'HEAD' and (request.META.get('REMOTE_ADDR') in
 settings.INTERNAL_IPS or (request.user and request.user.is_authenticated()
 and request.user.is_staff)):

 Change is addition of "request.user and"

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---