Re: [Django] #8122: Better way of testing for cookies

[Django]

#8122: Better way of testing for cookies
--+
 Reporter:  jcassee   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.sessions  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by kutenai):

 * Attachment "8122-rmaster.diff" added.

 Updated the diff to the latest master

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.b4094382c07c24a568b9a137fa436bd2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8122: Better way of testing for cookies

[Django]

#8122: Better way of testing for cookies
--+
 Reporter:  jcassee   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.sessions  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timo):

 * needs_better_patch:  0 => 1


Comment:

 Patch no longer applies cleanly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9230a989bc7af560dd08275dcb395cc8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8122: Better way of testing for cookies

[Django]

#8122: Better way of testing for cookies
--+
 Reporter:  jcassee   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.sessions  |  Version:  SVN
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Alex):

 * ui_ux:   => 0
 * easy:   => 0
 * stage:  Design decision needed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8122: Better way of testing for cookies

[Django]

#8122: Better way of testing for cookies
---+
   Reporter:  jcassee  | Owner:  nobody
 Status:  new  | Milestone:
  Component:  django.contrib.sessions  |   Version:  SVN   
 Resolution:   |  Keywords:
   Triage Stage:  Design decision needed   | Has patch:  1 
Needs documentation:  0|   Needs tests:  0 
Patch needs improvement:  0|  
---+
Changes (by iElectric):

 * cc: iElectric (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8122: Better way of testing for cookies

[Django]

#8122: Better way of testing for cookies
--+-
  Reporter:  jcassee  | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.sessions  |   Version:  SVN   
Resolution:   |  Keywords:
 Stage:  Design decision needed   | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Comment (by jcassee):

 I agree that the difference between the session key being {{{None}}} and
 being {{{""}}} is a subtle one, yet it is a useful distinction here. I
 wrote tests precisely to check whether I did the tests right!

 The tests were written before I noticed how other middleware was tested. I
 agree that changing it to just calling the middleware directly would be
 nice.

 I will post a message about this ticket on django-dev, as you suggested.
 Thanks for looking at it!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8122: Better way of testing for cookies

[Django]

#8122: Better way of testing for cookies
--+-
  Reporter:  jcassee  | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.sessions  |   Version:  SVN   
Resolution:   |  Keywords:
 Stage:  Design decision needed   | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Comment (by SmileyChris):

 Ah, I understand now - I was just a bit worried that it would be picking
 up that the key wasn't `None` and doing something with it. After a closer
 look at the session innards I see this isn't the case.

 This ticket looks good - why don't you raise it on the django-dev group?

 Of minor importance - the Django test client isn't really necessary here
 is it? (it's a lot slower than the testcase one) and wouldn't it be better
 to use the proper testcase assertions rather than just `assert` (but I'm
 not sure if it really matters)?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8122: Better way of testing for cookies

[Django]

#8122: Better way of testing for cookies
--+-
  Reporter:  jcassee  | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.sessions  |   Version:  SVN   
Resolution:   |  Keywords:
 Stage:  Design decision needed   | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Comment (by jcassee):

 The idea is that every session has a session cookie so that you avoid the
 need to call {{{set_test_cookie()}}} (which sets the cookie by added to
 the session). The session cookie is empty if the session is not yet
 modified to avoid a call to the session backend.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8122: Better way of testing for cookies

[Django]

#8122: Better way of testing for cookies
--+-
  Reporter:  jcassee  | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.sessions  |   Version:  SVN   
Resolution:   |  Keywords:
 Stage:  Design decision needed   | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Comment (by SmileyChris):

 Why the change in behaviour to set an initial session cookie for an
 unmodified session (if it wasn't found)?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---