Re: [Django] #8462: length and length_is filters don't fail silently

[Django]

#8462: length and length_is filters don't fail silently
+---
  Reporter:  magneto| Owner:  gwilson
Status:  assigned   | Milestone: 
 Component:  Template system|   Version:  SVN
Resolution: |  Keywords:  length 
 Stage:  Ready for checkin  | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  0  
Needs_better_patch:  0  |  
+---
Changes (by gwilson):

  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8462: length and length_is filters don't fail silently

[Django]

#8462: length and length_is filters don't fail silently
+---
  Reporter:  magneto| Owner:  gwilson
Status:  new| Milestone: 
 Component:  Template system|   Version:  SVN
Resolution: |  Keywords:  length 
 Stage:  Ready for checkin  | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  0  
Needs_better_patch:  0  |  
+---
Changes (by gwilson):

  * owner:  marcelor => gwilson
  * status:  assigned => new

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8462: length and length_is filters don't fail silently

[Django]

#8462: length and length_is filters don't fail silently
+---
  Reporter:  magneto| Owner:  marcelor
Status:  assigned   | Milestone:  
 Component:  Template system|   Version:  SVN 
Resolution: |  Keywords:  length  
 Stage:  Ready for checkin  | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by SmileyChris):

  * stage:  Accepted => Ready for checkin

Comment:

 Thanks marcelor and rob. Marking for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8462: length and length_is filters don't fail silently

[Django]

#8462: length and length_is filters don't fail silently
--+-
  Reporter:  magneto  | Owner:  marcelor
Status:  assigned | Milestone:  
 Component:  Template system  |   Version:  SVN 
Resolution:   |  Keywords:  length  
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Changes (by rob):

  * needs_better_patch:  1 => 0
  * has_patch:  0 => 1
  * needs_tests:  1 => 0

Comment:

 i think that takes care of needing tests

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8462: length and length_is filters don't fail silently

[Django]

#8462: length and length_is filters don't fail silently
--+-
  Reporter:  magneto  | Owner:  marcelor
Status:  assigned | Milestone:  
 Component:  Template system  |   Version:  SVN 
Resolution:   |  Keywords:  length  
 Stage:  Accepted | Has_patch:  0   
Needs_docs:  0|   Needs_tests:  1   
Needs_better_patch:  1|  
--+-
Comment (by SmileyChris):

 Marcelor, if you wouldn't mind extending the template filter test suite to
 encompass this change then that'll speed up the checkin process.

 Oh, and it'd be better style to just catch `ValueError` and `TypeError`
 rather than a raw except.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8462: length and length_is filters don't fail silently

[Django]

#8462: length and length_is filters don't fail silently
--+-
  Reporter:  magneto  | Owner:  marcelor
Status:  assigned | Milestone:  
 Component:  Template system  |   Version:  SVN 
Resolution:   |  Keywords:  length  
 Stage:  Accepted | Has_patch:  0   
Needs_docs:  0|   Needs_tests:  1   
Needs_better_patch:  1|  
--+-
Changes (by marcelor):

  * owner:  nobody => marcelor
  * status:  new => assigned

Comment:

 Submitted patch which makes both filters to return '' when their arguments
 are not measurable.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8462: length and length_is filters don't fail silently

[Django]

#8462: length and length_is filters don't fail silently
--+-
  Reporter:  magneto  | Owner:  nobody
Status:  new  | Milestone:
 Component:  Template system  |   Version:  SVN   
Resolution:   |  Keywords:  length
 Stage:  Accepted | Has_patch:  0 
Needs_docs:  0|   Needs_tests:  1 
Needs_better_patch:  1|  
--+-
Changes (by SmileyChris):

  * needs_better_patch:  => 1
  * stage:  Unreviewed => Accepted
  * summary:  template tag Length and the 'error' => length and length_is
  filters don't fail silently
  * needs_tests:  => 1
  * needs_docs:  => 0

Comment:

 This is also an issue for `length_is`.

 I think returning `''` would make more sense for the length filter (it's
 invalid, not `0`)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8462: length and length_is filters don't fail silently

[Django]

#8462: length and length_is filters don't fail silently
--+-
  Reporter:  magneto  | Owner:  nobody
Status:  new  | Milestone:
 Component:  Template system  |   Version:  SVN   
Resolution:   |  Keywords:  length
 Stage:  Accepted | Has_patch:  0 
Needs_docs:  0|   Needs_tests:  1 
Needs_better_patch:  1|  
--+-
Comment (by mtredinnick):

 I agree with Chris: if you're applying `length` or `length_is` to
 something that isn't measurable, it's an invalid usage, so returning an
 empty string is probably better.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---