Re: [Django] #9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin

2010-03-16 Thread Django 
#9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin
---+
  Reporter:  pickel...@gmail.com   | Owner:  nobody
Status:  reopened  | Milestone:  1.3   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Ready for checkin | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by carljm):

 #7985 was a duplicate of this, and also had a patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin

2010-03-03 Thread Django 
#9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin
---+
  Reporter:  pickel...@gmail.com   | Owner:  nobody
Status:  reopened  | Milestone:  1.3   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Ready for checkin | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by ubernostrum):

  * milestone:  1.2 => 1.3

Comment:

 I'm going to bump this off the 1.2 milestone, for a couple reasons:

  1. There are several tickets (this one, #9110, #9784 and #9983) all
 exposing cases where the event handling for `prepopulated_fields` falls
 over in specific edge cases, so the real solution is not to fix any of
 these individually but rather to make `prepopulate_from` more robust.
  2. I suspect the admin-ui work will be coming up for discussion in the
 1.3 timeframe, and that's a more solid place to talk about dealing with
 this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin

2010-03-03 Thread Django 
#9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin
---+
  Reporter:  pickel...@gmail.com   | Owner:  nobody
Status:  reopened  | Milestone:  1.2   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Ready for checkin | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by jacob):

  * stage:  Accepted => Ready for checkin

Comment:

 This really should be updated to use jQuery now, but it's not a big deal.
 We can commit it and clean it up later if needed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin

2009-05-07 Thread Django 
#9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin
---+
  Reporter:  pickel...@gmail.com   | Owner:  nobody
Status:  reopened  | Milestone:  1.2   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by jacob):

  * milestone:  1.1 => 1.2

Comment:

 Pushing to 1.2 for the same reason as #9983.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin

2009-05-07 Thread Django 
#9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin
---+
  Reporter:  pickel...@gmail.com   | Owner:  nobody
Status:  reopened  | Milestone:  1.1   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by apollo13):

  * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin

2009-03-31 Thread Django 
#9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin
---+
  Reporter:  pickel...@gmail.com   | Owner:  nobody
Status:  reopened  | Milestone:  1.1   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by kkubasik):

 This patch will conflict with the js patch in #9983, however. The patch
 there has been updated to include this fix.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin

2009-03-30 Thread Django 
#9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin
---+
  Reporter:  pickel...@gmail.com   | Owner:  nobody
Status:  reopened  | Milestone:  1.1   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by kmtracey):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 If there's a patch to be tested, it doesn't sound like this is fixed?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin

2009-03-30 Thread Django 
#9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin
---+
  Reporter:  pickel...@gmail.com   | Owner:  nobody
Status:  closed| Milestone:  1.1   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:  fixed |  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by peterbe):

 Patch tested in Firefox and Opera only.
 IE anyone?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin

2009-03-30 Thread Django 
#9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin
---+
  Reporter:  pickel...@gmail.com   | Owner:  nobody
Status:  closed| Milestone:  1.1   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:  fixed |  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by peterbe):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 I have reviewed this too.

 No, it's not reproducible. It does work perfectly well to have multiple
 slug fields like this:
 {{{
 class FooModelAdmin(admin.ModelAdmin):
 prepopulated_fields = {'slug': ('name',),
'slug2': ('name2',) }
 }}}

 BUT! If you have multiple slug fields that expect to use the same fields
 you have a problem. For example:
 {{{
 class FooModelAdmin(admin.ModelAdmin):
 prepopulated_fields = {'slug': ('name',),
'slug2': ('name',)
   }
 }}}

 What happens is effectively this:
 {{{
 ...
 document.getElementById("id_name").onkeyup = function() {
 var e = document.getElementById("id_slug");
 ...
 }

 document.getElementById("id_name").onkeyup = function() {
 var e = document.getElementById("id_slug2");
 ...
 }
 ...
 }}}

 Which is fundamentally wrong since it overwrites the keyup event on the
 same element.


 So attached is a patch to prepopulated_fields_js.html which use
 {{{addEvent(my_dom_obj, 'keyup', function(){})}}} rather that
 {{{my_dom_obj.onkeyup=function(){

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin

2009-03-26 Thread Django 
#9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin
---+
  Reporter:  pickel...@gmail.com   | Owner:  nobody
Status:  new   | Milestone:  1.1   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by dgouldin):

 * cc: dgoul...@gmail.com (added)

Comment:

 I was not able to reproduce this.  Can anybody else?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin

2009-02-26 Thread Django 
#9264: ModelAdmin: multipe items in prepopulated_fields breaks the auto-fillin
---+
  Reporter:  pickel...@gmail.com   | Owner:  nobody
Status:  new   | Milestone:  1.1   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by jacob):

  * needs_better_patch:  => 0
  * needs_docs:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * milestone:  => 1.1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---