Re: [Django] #9751: project_directory calculated incorrectly when "settings" is a directory (breaks 'startapp')

[Django]

#9751: project_directory calculated incorrectly when "settings" is a directory
(breaks 'startapp')
+---
  Reporter:  lamby  | Owner:  gsong 
  
Status:  closed | Milestone:  1.1   
  
 Component:  django-admin.py|   Version:  1.0   
  
Resolution:  fixed  |  Keywords:  
startapp,settings,module
 Stage:  Ready for checkin  | Has_patch:  1 
  
Needs_docs:  0  |   Needs_tests:  0 
  
Needs_better_patch:  0  |  
+---
Comment (by Leo):

 This fix broke our configuration - documented in #11147.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9751: project_directory calculated incorrectly when "settings" is a directory (breaks 'startapp')

[Django]

#9751: project_directory calculated incorrectly when "settings" is a directory
(breaks 'startapp')
+---
  Reporter:  lamby  | Owner:  gsong 
  
Status:  assigned   | Milestone:  1.1   
  
 Component:  django-admin.py|   Version:  1.0   
  
Resolution: |  Keywords:  
startapp,settings,module
 Stage:  Ready for checkin  | Has_patch:  1 
  
Needs_docs:  0  |   Needs_tests:  0 
  
Needs_better_patch:  0  |  
+---
Changes (by anonymous):

 * cc: robillard.etie...@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9751: project_directory calculated incorrectly when "settings" is a directory (breaks 'startapp')

[Django]

#9751: project_directory calculated incorrectly when "settings" is a directory
(breaks 'startapp')
+---
  Reporter:  lamby  | Owner:  gsong 
  
Status:  assigned   | Milestone:  1.1   
  
 Component:  django-admin.py|   Version:  1.0   
  
Resolution: |  Keywords:  
startapp,settings,module
 Stage:  Ready for checkin  | Has_patch:  1 
  
Needs_docs:  0  |   Needs_tests:  0 
  
Needs_better_patch:  0  |  
+---
Comment (by Alex):

 __import__ doesn't redo an imoprt if it's already in sys.modules.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9751: project_directory calculated incorrectly when "settings" is a directory (breaks 'startapp')

[Django]

#9751: project_directory calculated incorrectly when "settings" is a directory
(breaks 'startapp')
+---
  Reporter:  lamby  | Owner:  gsong 
  
Status:  assigned   | Milestone:  1.1   
  
 Component:  django-admin.py|   Version:  1.0   
  
Resolution: |  Keywords:  
startapp,settings,module
 Stage:  Ready for checkin  | Has_patch:  1 
  
Needs_docs:  0  |   Needs_tests:  0 
  
Needs_better_patch:  0  |  
+---
Comment (by gsong):

 The reason for using `sys.modules` lookup instead of `import_module()` was
 to '''prevent''' the setting module from unnecessarily being imported
 again, since it would have to have been imported by this point.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9751: project_directory calculated incorrectly when "settings" is a directory (breaks 'startapp')

[Django]

#9751: project_directory calculated incorrectly when "settings" is a directory
(breaks 'startapp')
+---
  Reporter:  lamby  | Owner:  gsong 
  
Status:  assigned   | Milestone:  1.1   
  
 Component:  django-admin.py|   Version:  1.0   
  
Resolution: |  Keywords:  
startapp,settings,module
 Stage:  Ready for checkin  | Has_patch:  1 
  
Needs_docs:  0  |   Needs_tests:  0 
  
Needs_better_patch:  0  |  
+---
Changes (by Alex):

  * needs_tests:  1 => 0
  * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9751: project_directory calculated incorrectly when "settings" is a directory (breaks 'startapp')

[Django]

#9751: project_directory calculated incorrectly when "settings" is a directory
(breaks 'startapp')
--+-
  Reporter:  lamby| Owner:  gsong   
Status:  assigned | Milestone:  1.1 
 Component:  django-admin.py  |   Version:  1.0 
Resolution:   |  Keywords:  startapp,settings,module
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  1   
Needs_better_patch:  0|  
--+-
Comment (by ericholscher):

 All tests pass, and the regression test (first at the top of that patch)
 fails on current trunk and passes with the patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9751: project_directory calculated incorrectly when "settings" is a directory (breaks 'startapp')

[Django]

#9751: project_directory calculated incorrectly when "settings" is a directory
(breaks 'startapp')
--+-
  Reporter:  lamby| Owner:  gsong   
Status:  assigned | Milestone:  1.1 
 Component:  django-admin.py  |   Version:  1.0 
Resolution:   |  Keywords:  startapp,settings,module
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  1   
Needs_better_patch:  0|  
--+-
Changes (by ericholscher):

  * needs_tests:  0 => 1

Comment:

 Trying to write tests for this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9751: project_directory calculated incorrectly when "settings" is a directory (breaks 'startapp')

[Django]

#9751: project_directory calculated incorrectly when "settings" is a directory
(breaks 'startapp')
--+-
  Reporter:  lamby| Owner:  gsong   
Status:  assigned | Milestone:  1.1 
 Component:  django-admin.py  |   Version:  1.0 
Resolution:   |  Keywords:  startapp,settings,module
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Changes (by gsong):

  * owner:  nobody => gsong
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9751: project_directory calculated incorrectly when "settings" is a directory (breaks 'startapp')

[Django]

#9751: project_directory calculated incorrectly when "settings" is a directory
(breaks 'startapp')
--+-
  Reporter:  lamby| Owner:  nobody  
Status:  new  | Milestone:  1.1 
 Component:  django-admin.py  |   Version:  1.0 
Resolution:   |  Keywords:  startapp,settings,module
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Comment (by gsong):

 My patch fixes a few problems:
 1. ``get_commands()`` was importing project settings each time it's
 called. That's not necessary.
 2. ``get_commands()`` was actually passing the project package instead of
 settings module/package to ``setup_environ()``.
 3. In ``setup_environ()``, check to see if settings module is a package or
 module by checking to see if its ``__file__`` contains ``__init__.py`` or
 not. Not sure if this works for Jython as I don't know how Jython
 filenames work.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9751: project_directory calculated incorrectly when "settings" is a directory (breaks 'startapp')

[Django]

#9751: project_directory calculated incorrectly when "settings" is a directory
(breaks 'startapp')
--+-
  Reporter:  lamby| Owner:  nobody  
Status:  new  | Milestone:  1.1 
 Component:  django-admin.py  |   Version:  1.0 
Resolution:   |  Keywords:  startapp,settings,module
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Comment (by alexr):

 Looks like the conditional the patch added (if settings_name ==
 "__init__") is being excecuted during the tests, even though I don't think
 they are using a settings directory. Not exactly sure why that is.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9751: project_directory calculated incorrectly when "settings" is a directory (breaks 'startapp')

[Django]

#9751: project_directory calculated incorrectly when "settings" is a directory
(breaks 'startapp')
--+-
  Reporter:  lamby| Owner:  nobody  
Status:  new  | Milestone:  1.1 
 Component:  django-admin.py  |   Version:  1.0 
Resolution:   |  Keywords:  startapp,settings,module
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Comment (by alexr):

 06-fix-project_name-location-when-settings-is-a-module.patch does fix the
 bug. It also breaks 37 of the admin_scripts regression tests. Somehow it
 causes the spawned admin commands to die with a "TypeError: relative
 imports require the 'package' argument" traceback.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9751: project_directory calculated incorrectly when "settings" is a directory (breaks 'startapp')

[Django]

#9751: project_directory calculated incorrectly when "settings" is a directory
(breaks 'startapp')
--+-
  Reporter:  lamby| Owner:  nobody  
Status:  new  | Milestone:  1.1 
 Component:  django-admin.py  |   Version:  1.0 
Resolution:   |  Keywords:  startapp,settings,module
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Changes (by russellm):

  * component:  Uncategorized => django-admin.py

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9751: project_directory calculated incorrectly when "settings" is a directory (breaks 'startapp')

[Django]

#9751: project_directory calculated incorrectly when "settings" is a directory
(breaks 'startapp')
+---
  Reporter:  lamby  | Owner:  nobody  
Status:  new| Milestone:  1.1 
 Component:  Uncategorized  |   Version:  1.0 
Resolution: |  Keywords:  startapp,settings,module
 Stage:  Accepted   | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by jacob):

  * stage:  Unreviewed => Accepted
  * milestone:  => 1.1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9751: project_directory calculated incorrectly when "settings" is a directory (breaks 'startapp')

[Django]

#9751: project_directory calculated incorrectly when "settings" is a directory
(breaks 'startapp')
+---
  Reporter:  lamby  | Owner:  nobody  
Status:  new| Milestone:  
 Component:  Uncategorized  |   Version:  1.0 
Resolution: |  Keywords:  startapp,settings,module
 Stage:  Unreviewed | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by lamby):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Rebasing patch against HEAD.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---