Re: Keeping track of the original values for a record...
Blah... I could have sworn that worked when I tried it yesterday. but when I went to start working on it today..that method is returning the changed values as well... very strange... I might have to resort to calling the values from the DB again before doing a save :( On Aug 29, 4:34 pm, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: > Maybe it's a bug in my branch..I'm using the multiple db branch... but > the other method Mike pointed out appears to work. Tomorrow I'm going > to tie it all together and have my save method only fire save if there > are dirty fields, and log what data has been changed into my event > table... > > Thanks again everyone! > > On Aug 29, 4:13 pm, Doug B <[EMAIL PROTECTED]> wrote: > > > Hmm. It works in shell for me, I'm not sure what the difference might > > be. It only keeps _original_data for the life of the instance, so if > > the view completes, the next view is a different instance. You could > > make a pickle field to persist it, if you wanted to keep track of the > > changed values. > > > In [2]: m=cm.MarketingStatus(marketing_status_name="Test Name", > > marketing_status_description="Testing signals") > > In [3]: m.save() > > In [4]: m.marketing_status_name="Changed this" > > In [5]: m.marketing_status_name > > Out[5]: 'Changed this' > > In [6]: m._original_data['marketing_status_name'] > > Out[6]: 'Test Name' > > > I added a couple print statements to print testing and testing 2 in > > the save method: > > > In [2]: m=cm.MarketingStatus.objects.all()[0] > > In [3]: m.marketing_status_name = "changed again" > > In [4]: m.save() > > testing: Test Name > > testing2: changed again > > > - using this code > > def backup_model_data(sender, instance, signal, *args, **kwargs): > > instance._original_data = instance.__dict__.copy() > > > class MarketingStatus(models.Model): > > marketing_status_id = models.AutoField(primary_key=True) > > marketing_status_name = models.CharField(blank=True, maxlength=30) > > marketing_status_description = > > models.CharField(blank=True,maxlength=255) > > > def save(self): > > testing =self._original_data['marketing_status_name'] > > testing2 = self.marketing_status_name > > print "testing: %s" % testing > > print "testing2: %s" % testing2 > > super(MarketingStatus, self).save() > > > dispatcher.connect(backup_model_data,signal=signals.post_init,sender=MarketingStatus) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~--~~~~--~~--~--~---
Re: Keeping track of the original values for a record...
Maybe it's a bug in my branch..I'm using the multiple db branch... but the other method Mike pointed out appears to work. Tomorrow I'm going to tie it all together and have my save method only fire save if there are dirty fields, and log what data has been changed into my event table... Thanks again everyone! On Aug 29, 4:13 pm, Doug B <[EMAIL PROTECTED]> wrote: > Hmm. It works in shell for me, I'm not sure what the difference might > be. It only keeps _original_data for the life of the instance, so if > the view completes, the next view is a different instance. You could > make a pickle field to persist it, if you wanted to keep track of the > changed values. > > In [2]: m=cm.MarketingStatus(marketing_status_name="Test Name", > marketing_status_description="Testing signals") > In [3]: m.save() > In [4]: m.marketing_status_name="Changed this" > In [5]: m.marketing_status_name > Out[5]: 'Changed this' > In [6]: m._original_data['marketing_status_name'] > Out[6]: 'Test Name' > > I added a couple print statements to print testing and testing 2 in > the save method: > > In [2]: m=cm.MarketingStatus.objects.all()[0] > In [3]: m.marketing_status_name = "changed again" > In [4]: m.save() > testing: Test Name > testing2: changed again > > - using this code > def backup_model_data(sender, instance, signal, *args, **kwargs): > instance._original_data = instance.__dict__.copy() > > class MarketingStatus(models.Model): > marketing_status_id = models.AutoField(primary_key=True) > marketing_status_name = models.CharField(blank=True, maxlength=30) > marketing_status_description = > models.CharField(blank=True,maxlength=255) > > def save(self): > testing =self._original_data['marketing_status_name'] > testing2 = self.marketing_status_name > print "testing: %s" % testing > print "testing2: %s" % testing2 > super(MarketingStatus, self).save() > > dispatcher.connect(backup_model_data,signal=signals.post_init,sender=MarketingStatus) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~--~~~~--~~--~--~---
Re: Keeping track of the original values for a record...
Hmm. It works in shell for me, I'm not sure what the difference might be. It only keeps _original_data for the life of the instance, so if the view completes, the next view is a different instance. You could make a pickle field to persist it, if you wanted to keep track of the changed values. In [2]: m=cm.MarketingStatus(marketing_status_name="Test Name", marketing_status_description="Testing signals") In [3]: m.save() In [4]: m.marketing_status_name="Changed this" In [5]: m.marketing_status_name Out[5]: 'Changed this' In [6]: m._original_data['marketing_status_name'] Out[6]: 'Test Name' I added a couple print statements to print testing and testing 2 in the save method: In [2]: m=cm.MarketingStatus.objects.all()[0] In [3]: m.marketing_status_name = "changed again" In [4]: m.save() testing: Test Name testing2: changed again - using this code def backup_model_data(sender, instance, signal, *args, **kwargs): instance._original_data = instance.__dict__.copy() class MarketingStatus(models.Model): marketing_status_id = models.AutoField(primary_key=True) marketing_status_name = models.CharField(blank=True, maxlength=30) marketing_status_description = models.CharField(blank=True,maxlength=255) def save(self): testing =self._original_data['marketing_status_name'] testing2 = self.marketing_status_name print "testing: %s" % testing print "testing2: %s" % testing2 super(MarketingStatus, self).save() dispatcher.connect(backup_model_data,signal=signals.post_init,sender=MarketingStatus) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~--~~~~--~~--~--~---
Re: Keeping track of the original values for a record...
Ahh..this appears to work! Thanks! On Aug 29, 3:46 pm, Michael <[EMAIL PROTECTED]> wrote: > You can simply override the __init__ method and take a copy of the > values then: > > See Malcolm's explanation > here:http://groups.google.com/group/django-users/msg/6d849eca95243371 > > -Mike > > On Aug 30, 5:28 am, "[EMAIL PROTECTED]" > > <[EMAIL PROTECTED]> wrote: > > I tried using the signals... but setting a new value on the record, > > seems to also set it on the _original_data ...which is odd...maybe I'm > > not seeing something stupid that I'm doing? If I change my > > marketing_status_name data in my view and save, the new data is in > > both the _original_data, and in the new property value. > > > # some extra properties removed to make it shorter to read > > from django.db.models import signals > > from django.dispatch import dispatcher > > from django.db import models > > > def backup_model_data(sender, instance, signal, *args, **kwargs): > > instance._original_data = instance.__dict__.copy() > > > class MarketingStatus(models.Model): > > marketing_status_id = models.AutoField(primary_key=True) > > marketing_status_name = models.CharField(blank=True, maxlength=30) > > marketing_status_description = models.CharField(blank=True, > > maxlength=255) > > > def save(self): > > testing = > > self._original_data['marketing_status_name'] > > testing2 = self.marketing_status_name > > > triggererror = madeupvariabletotriggererror # > > just stuck this here so I can view the data in the browser > > > super(MarketingStatus, self).save() > > > class Meta: > > db_table = 'marketing_status' > > > dispatcher.connect(backup_model_data,signal=signals.post_init,sender=MarketingStatus) > > > On Aug 29, 2:24 pm, Doug B <[EMAIL PROTECTED]> wrote: > > > > You could probably use the post_init signal to make a copy of the > > > model values for comparison in your save method. I'm doing something > > > similar to create a special manager object each time a certain model > > > instance is created. > > > > Something like this... > > > > def backup_model_data(sender, instance, signal, *args, **kwargs): > > > instance._original_data = instance.__dict__.copy() > > > > class YourModel(model.Models): > > > ... > > > dispatcher.connect(backup_model_data,signal=signals.post_init, > > > sender=YourModel) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~--~~~~--~~--~--~---
Re: Keeping track of the original values for a record...
You can simply override the __init__ method and take a copy of the values then: See Malcolm's explanation here: http://groups.google.com/group/django-users/msg/6d849eca95243371 -Mike On Aug 30, 5:28 am, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: > I tried using the signals... but setting a new value on the record, > seems to also set it on the _original_data ...which is odd...maybe I'm > not seeing something stupid that I'm doing? If I change my > marketing_status_name data in my view and save, the new data is in > both the _original_data, and in the new property value. > > # some extra properties removed to make it shorter to read > from django.db.models import signals > from django.dispatch import dispatcher > from django.db import models > > def backup_model_data(sender, instance, signal, *args, **kwargs): > instance._original_data = instance.__dict__.copy() > > class MarketingStatus(models.Model): > marketing_status_id = models.AutoField(primary_key=True) > marketing_status_name = models.CharField(blank=True, maxlength=30) > marketing_status_description = models.CharField(blank=True, > maxlength=255) > > def save(self): > testing = > self._original_data['marketing_status_name'] > testing2 = self.marketing_status_name > > triggererror = madeupvariabletotriggererror # > just stuck this here so I can view the data in the browser > > super(MarketingStatus, self).save() > > class Meta: > db_table = 'marketing_status' > > dispatcher.connect(backup_model_data,signal=signals.post_init,sender=MarketingStatus) > > On Aug 29, 2:24 pm, Doug B <[EMAIL PROTECTED]> wrote: > > > You could probably use the post_init signal to make a copy of the > > model values for comparison in your save method. I'm doing something > > similar to create a special manager object each time a certain model > > instance is created. > > > Something like this... > > > def backup_model_data(sender, instance, signal, *args, **kwargs): > > instance._original_data = instance.__dict__.copy() > > > class YourModel(model.Models): > > ... > > dispatcher.connect(backup_model_data,signal=signals.post_init, > > sender=YourModel) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~--~~~~--~~--~--~---
Re: Keeping track of the original values for a record...
I tried using the signals... but setting a new value on the record, seems to also set it on the _original_data ...which is odd...maybe I'm not seeing something stupid that I'm doing? If I change my marketing_status_name data in my view and save, the new data is in both the _original_data, and in the new property value. # some extra properties removed to make it shorter to read from django.db.models import signals from django.dispatch import dispatcher from django.db import models def backup_model_data(sender, instance, signal, *args, **kwargs): instance._original_data = instance.__dict__.copy() class MarketingStatus(models.Model): marketing_status_id = models.AutoField(primary_key=True) marketing_status_name = models.CharField(blank=True, maxlength=30) marketing_status_description = models.CharField(blank=True, maxlength=255) def save(self): testing = self._original_data['marketing_status_name'] testing2 = self.marketing_status_name triggererror = madeupvariabletotriggererror # just stuck this here so I can view the data in the browser super(MarketingStatus, self).save() class Meta: db_table = 'marketing_status' dispatcher.connect(backup_model_data,signal=signals.post_init,sender=MarketingStatus) On Aug 29, 2:24 pm, Doug B <[EMAIL PROTECTED]> wrote: > You could probably use the post_init signal to make a copy of the > model values for comparison in your save method. I'm doing something > similar to create a special manager object each time a certain model > instance is created. > > Something like this... > > def backup_model_data(sender, instance, signal, *args, **kwargs): > instance._original_data = instance.__dict__.copy() > > class YourModel(model.Models): > ... > dispatcher.connect(backup_model_data,signal=signals.post_init, > sender=YourModel) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~--~~~~--~~--~--~---
Re: Keeping track of the original values for a record...
You could probably use the post_init signal to make a copy of the model values for comparison in your save method. I'm doing something similar to create a special manager object each time a certain model instance is created. Something like this... def backup_model_data(sender, instance, signal, *args, **kwargs): instance._original_data = instance.__dict__.copy() class YourModel(model.Models): ... dispatcher.connect(backup_model_data,signal=signals.post_init, sender=YourModel) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~--~~~~--~~--~--~---
Re: Keeping track of the original values for a record...
Jure Čuhalev wrote:
> On 8/29/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
>> Since there isn't a load() method on a model... I'm thinking I somehow
>> have to do this on the manager..but not sure ... any tips would be
>> great.
>>
>> When I load a record, either via get() or by looping through the
>> results of a .filter(), I'd like to keep track of the original
>> attribute values via setting a custom property on that model which
>> would contain a dict of the attribute/value at the time the record was
>> loaded ...
>>
>> This is basically so that when I save, I can compare the current
>> values with those of the original to see which values have changed,
>> and which haven't, which I need to know for some event logs I'm
>> writing out at save time.
>>
>> Thanks for any info.
>>
>
> You could hook yourself to pre_save:
>
> http://www.djangoproject.com/documentation/db-api/#what-happens-when-you-save
But by the time pre_save occurs, all the values have been changed, and
you would have to perform another get() before you would have all the
original values. I don't think that's quite as good.
Something you could do is override the __set__ (or do the same via a
descriptor), and from there you could easily populate your dict with
original values. Once there's a set value for each key, then don't
populate the dict any more. Off the cuff code:
d = {}
def __set__(self, obj, val):
if obj not in d:
d[obj] = val
super(SomeClass, self).__set__(obj, val)
I have no idea if that works, but it's one possible starting point. If
you do manage to get this working, post your solution, I think this one
might be a good starting point for those people who want to do the
"change-only" query saves to the DB too. (I know that there's a ticket
somewhere in Trac that is related to that topic, but I'm too lazy to
look it up).
Good luck,
gav
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"Django users" group.
To post to this group, send email to django-users@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-users?hl=en
-~--~~~~--~~--~--~---
Re: Keeping track of the original values for a record...
Thanks..but I'm already overriding save, and creating an event record... I need to know how to do something extra when the data is loaded initially. I know I could query the record again into a new object and use that for the original values..but that seems pretty hackish ...so I'd prefer to try and save off the original values into a dict when the record gets loaded... On Aug 29, 1:21 pm, "Jure Čuhalev" <[EMAIL PROTECTED]> wrote: > On 8/29/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > > > > > Since there isn't a load() method on a model... I'm thinking I somehow > > have to do this on the manager..but not sure ... any tips would be > > great. > > > When I load a record, either via get() or by looping through the > > results of a .filter(), I'd like to keep track of the original > > attribute values via setting a custom property on that model which > > would contain a dict of the attribute/value at the time the record was > > loaded ... > > > This is basically so that when I save, I can compare the current > > values with those of the original to see which values have changed, > > and which haven't, which I need to know for some event logs I'm > > writing out at save time. > > > Thanks for any info. > > You could hook yourself to pre_save: > > http://www.djangoproject.com/documentation/db-api/#what-happens-when-... > > kr, jure --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~--~~~~--~~--~--~---
Re: Keeping track of the original values for a record...
On 8/29/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > Since there isn't a load() method on a model... I'm thinking I somehow > have to do this on the manager..but not sure ... any tips would be > great. > > When I load a record, either via get() or by looping through the > results of a .filter(), I'd like to keep track of the original > attribute values via setting a custom property on that model which > would contain a dict of the attribute/value at the time the record was > loaded ... > > This is basically so that when I save, I can compare the current > values with those of the original to see which values have changed, > and which haven't, which I need to know for some event logs I'm > writing out at save time. > > Thanks for any info. > You could hook yourself to pre_save: http://www.djangoproject.com/documentation/db-api/#what-happens-when-you-save kr, jure --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~--~~~~--~~--~--~---
