Re: Questions about code reviews and static analysis tools for TU Delft research
Thanks for answering Tim, I appreciate it. On Tuesday, December 16, 2014 8:44:32 PM UTC+1, Tim Graham wrote: > > Hi Radjino, > > 1. 1. Do all developers (contributors and core developers) have to >> submit a code review for every change? I’m asking because many projects >> only review changes made by contributors. >> > While there is nothing that prevents core developers from committing a > patch without review, we highly discourage that for any non-trivial change. > Most core developers do follow the same process of submitting a pull > request in order to get their contributions reviewed. > > >> 2. 2. Which code review tools are used (just Github, or maybe >> other tools)? >> > GitHub is the primary review tool. We also allow attaching patches to Trac > tickets, but it's more difficult to give substantial review comments so > this is typically only used for trivial changes. > > >> 3. 3. Are static analyzers used? If they are used: >> >> a. Is passing the checks of the static analyzers necessary for a >> change to be accepted? >> >> b. Which static analyzers are used? >> > Yes, we use flake8. It runs as part of the build process when we run a > pull request against our continuous integration servers (Jenkins). > > -- You received this message because you are subscribed to the Google Groups "Django users" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-users+unsubscr...@googlegroups.com. To post to this group, send email to django-users@googlegroups.com. Visit this group at http://groups.google.com/group/django-users. To view this discussion on the web visit https://groups.google.com/d/msgid/django-users/b3a4a647-1d92-4bbd-805d-fc33c06a015a%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Questions about code reviews and static analysis tools for TU Delft research
Hi Radjino, 1. 1. Do all developers (contributors and core developers) have to > submit a code review for every change? I’m asking because many projects > only review changes made by contributors. > While there is nothing that prevents core developers from committing a patch without review, we highly discourage that for any non-trivial change. Most core developers do follow the same process of submitting a pull request in order to get their contributions reviewed. > 2. 2. Which code review tools are used (just Github, or maybe other > tools)? > GitHub is the primary review tool. We also allow attaching patches to Trac tickets, but it's more difficult to give substantial review comments so this is typically only used for trivial changes. > 3. 3. Are static analyzers used? If they are used: > > a. Is passing the checks of the static analyzers necessary for a > change to be accepted? > > b. Which static analyzers are used? > Yes, we use flake8. It runs as part of the build process when we run a pull request against our continuous integration servers (Jenkins). -- You received this message because you are subscribed to the Google Groups "Django users" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-users+unsubscr...@googlegroups.com. To post to this group, send email to django-users@googlegroups.com. Visit this group at http://groups.google.com/group/django-users. To view this discussion on the web visit https://groups.google.com/d/msgid/django-users/0e48ba08-5af7-4b9b-9705-53eaa8736e69%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
