Re: [dm-devel] [f2fs-dev] [PATCH 26/27] block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD
On 2022/4/15 12:52, Christoph Hellwig wrote: Secure erase is a very different operation from discard in that it is a data integrity operation vs hint. Fully split the limits and helper infrastructure to make the separation more clear. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen Acked-by: Christoph Böhmwalder [drbd] Acked-by: Ryusuke Konishi [nifs2] Acked-by: Jaegeuk Kim [f2fs] Acked-by: Coly Li [bcache] Acked-by: David Sterba [btrfs] For f2fs part, Acked-by: Chao Yu Thanks, -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
Re: [dm-devel] [f2fs-dev] [PATCH 07/17] f2fs: use blkdev_issue_flush in __submit_flush_wait
On 2021/1/26 22:52, Christoph Hellwig wrote: Use the blkdev_issue_flush helper instead of duplicating it. Signed-off-by: Christoph Hellwig Acked-by: Chao Yu Thanks, -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
Re: [dm-devel] [f2fs-dev] [PATCH 08/17] f2fs: remove FAULT_ALLOC_BIO
On 2021/1/26 22:52, Christoph Hellwig wrote: Sleeping bio allocations do not fail, which means that injecting an error into sleeping bio allocations is a little silly. Signed-off-by: Christoph Hellwig Acked-by: Chao Yu Thanks, -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
Re: [dm-devel] [PATCH 04/45] fs: simplify freeze_bdev/thaw_bdev
On 2020/11/24 21:27, Christoph Hellwig wrote: Store the frozen superblock in struct block_device to avoid the awkward interface that can return a sb only used a cookie, an ERR_PTR or NULL. Signed-off-by: Christoph Hellwig --- drivers/md/dm-core.h | 5 - drivers/md/dm.c | 20 ++-- fs/block_dev.c| 39 --- fs/buffer.c | 2 +- fs/ext4/ioctl.c | 2 +- fs/f2fs/file.c| 14 +- For f2fs part, Acked-by: Chao Yu Thanks, fs/xfs/xfs_fsops.c| 7 ++- include/linux/blk_types.h | 1 + include/linux/blkdev.h| 4 ++-- 9 files changed, 34 insertions(+), 60 deletions(-) -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
Re: [dm-devel] [PATCH 38/45] block: switch partition lookup to use struct block_device
On 2020/11/24 21:27, Christoph Hellwig wrote: Use struct block_device to lookup partitions on a disk. This removes all usage of struct hd_struct from the I/O path, and this allows removing the percpu refcount in struct hd_struct. Signed-off-by: Christoph Hellwig --- block/bio.c| 4 +- block/blk-core.c | 66 ++ block/blk-flush.c | 2 +- block/blk-mq.c | 9 ++-- block/blk-mq.h | 7 ++-- block/blk.h| 4 +- block/genhd.c | 56 + block/partitions/core.c| 7 +--- drivers/block/drbd/drbd_receiver.c | 2 +- drivers/block/drbd/drbd_worker.c | 2 +- drivers/block/zram/zram_drv.c | 2 +- drivers/md/bcache/request.c| 4 +- drivers/md/dm.c| 4 +- drivers/md/md.c| 4 +- drivers/nvme/target/admin-cmd.c| 20 - fs/ext4/super.c| 18 +++- fs/ext4/sysfs.c| 10 + fs/f2fs/f2fs.h | 2 +- fs/f2fs/super.c| 6 +-- For f2fs part, Acked-by: Chao Yu Thanks, include/linux/blkdev.h | 8 ++-- include/linux/genhd.h | 4 +- include/linux/part_stat.h | 17 22 files changed, 120 insertions(+), 138 deletions(-) -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
Re: [dm-devel] [PATCH 43/45] f2fs: remove a few bd_part checks
On 2020/11/24 21:27, Christoph Hellwig wrote: bd_part is never NULL for a block device in use by a file system, so remove the checks. Signed-off-by: Christoph Hellwig Reviewed-by: Chao Yu Thanks, -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
Re: [dm-devel] [PATCH 30/45] block: remove the nr_sects field in struct hd_struct
On 2020/11/24 21:27, Christoph Hellwig wrote: Now that the hd_struct always has a block device attached to it, there is no need for having two size field that just get out of sync. Additional the field in hd_struct did not use proper serializiation, possibly allowing for torn writes. By only using the block_device field this problem also gets fixed. Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman --- block/bio.c| 4 +- block/blk-core.c | 2 +- block/blk.h| 53 -- block/genhd.c | 55 +++--- block/partitions/core.c| 17 --- drivers/block/loop.c | 1 - drivers/block/nbd.c| 2 +- drivers/block/xen-blkback/common.h | 4 +- drivers/md/bcache/super.c | 2 +- drivers/s390/block/dasd_ioctl.c| 4 +- drivers/target/target_core_pscsi.c | 7 +-- fs/block_dev.c | 73 +- fs/f2fs/super.c| 2 +- For f2fs part, Acked-by: Chao Yu Thanks, fs/pstore/blk.c| 2 +- include/linux/genhd.h | 29 +++- kernel/trace/blktrace.c| 2 +- 16 files changed, 60 insertions(+), 199 deletions(-) -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
