[dm-devel] [PATCH 4/5] nvme/multipath: Use blk_retryable
Uses common code for determining if an error should be retried on alternate path. Signed-off-by: Keith Busch --- drivers/nvme/host/multipath.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c index ae9abb600c0f..93bb72b6efb6 100644 --- a/drivers/nvme/host/multipath.c +++ b/drivers/nvme/host/multipath.c @@ -37,19 +37,7 @@ bool nvme_req_needs_failover(struct request *req, blk_status_t error) { if (!(req->cmd_flags & REQ_NVME_MPATH)) return false; - - switch (error) { - case BLK_STS_NOTSUPP: - case BLK_STS_NOSPC: - case BLK_STS_TARGET: - case BLK_STS_NEXUS: - case BLK_STS_MEDIUM: - case BLK_STS_PROTECTION: - return false; - } - - /* Everything else could be a path failure, so should be retried */ - return true; + return blk_retryable(error); } void nvme_kick_requeue_lists(struct nvme_ctrl *ctrl) -- 2.13.6 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
Re: [dm-devel] [PATCH 4/5] nvme/multipath: Use blk_retryable
On Thu, Jan 04 2018 at 5:46pm -0500, Keith Busch wrote: > Uses common code for determining if an error should be retried on > alternate path. > > Signed-off-by: Keith Busch Acked-by: Mike Snitzer -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
Re: [dm-devel] [PATCH 4/5] nvme/multipath: Use blk_retryable
On 01/04/2018 11:46 PM, Keith Busch wrote: > Uses common code for determining if an error should be retried on > alternate path. > > Signed-off-by: Keith Busch > --- > drivers/nvme/host/multipath.c | 14 +- > 1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c > index ae9abb600c0f..93bb72b6efb6 100644 > --- a/drivers/nvme/host/multipath.c > +++ b/drivers/nvme/host/multipath.c > @@ -37,19 +37,7 @@ bool nvme_req_needs_failover(struct request *req, > blk_status_t error) > { > if (!(req->cmd_flags & REQ_NVME_MPATH)) > return false; > - > - switch (error) { > - case BLK_STS_NOTSUPP: > - case BLK_STS_NOSPC: > - case BLK_STS_TARGET: > - case BLK_STS_NEXUS: > - case BLK_STS_MEDIUM: > - case BLK_STS_PROTECTION: > - return false; > - } > - > - /* Everything else could be a path failure, so should be retried */ > - return true; > + return blk_retryable(error); > } > > void nvme_kick_requeue_lists(struct nvme_ctrl *ctrl) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.com +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel