Re: [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure()
On Wed, Aug 18, 2021 at 10:10:51AM -0700, Dan Williams wrote: > > Sounds like a nice solution. I think I can add an is_notify_supported() > > interface in dax_holder_ops and check it when register dax_holder. > > Shouldn't the fs avoid registering a memory failure handler if it is > not prepared to take over? For example, shouldn't this case behave > identically to ext4 that will not even register a callback? Yes.
Re: [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure()
On Fri, Jul 30, 2021 at 3:02 AM Shiyang Ruan wrote: > > When memory-failure occurs, we call this function which is implemented > by each kind of devices. For the fsdax case, pmem device driver > implements it. Pmem device driver will find out the filesystem in which > the corrupted page located in. And finally call filesystem handler to > deal with this error. > > The filesystem will try to recover the corrupted data if necessary. This patch looks good to me, but I would fold it into the patch that first populates ->memory_failure().
