Re: [dnsdist] identical metrics
On 7/12/19 2:35 PM, Klaus Darilion wrote: >>> I think this may cause problems with later visualization tools. I think >>> it would be good to add an optional "name" parameter (as with newServer). >> >> Yes, I agree the current situation could be improved, I have a few ideas >> in mind for the next refactoring of this code. >> In the meantime this exact issue should have been fixed by [1] on master. >> >> [1]: https://github.com/PowerDNS/pdns/pull/7934 > > Will this rename the metrics to be unique or will it generate a single > metric with the sum of all submetrics? It will rename the metrics so that they are unique. In the future I would like to provide both per-thread metrics and also aggregated ones, but I'm afraid that will have to wait for 1.5.0. Best regards, -- Remi Gacogne PowerDNS.COM BV - https://www.powerdns.com/ signature.asc Description: OpenPGP digital signature ___ dnsdist mailing list dnsdist@mailman.powerdns.com https://mailman.powerdns.com/mailman/listinfo/dnsdist
Re: [dnsdist] identical metrics
Hi Remi! Am 12.07.2019 um 10:27 schrieb Remi Gacogne: > Hi Klaus! > > On 7/12/19 10:23 AM, Klaus Darilion wrote: >> I think this may cause problems with later visualization tools. I think >> it would be good to add an optional "name" parameter (as with newServer). > > Yes, I agree the current situation could be improved, I have a few ideas > in mind for the next refactoring of this code. > In the meantime this exact issue should have been fixed by [1] on master. > > [1]: https://github.com/PowerDNS/pdns/pull/7934 Will this rename the metrics to be unique or will it generate a single metric with the sum of all submetrics? Thanks Klaus ___ dnsdist mailing list dnsdist@mailman.powerdns.com https://mailman.powerdns.com/mailman/listinfo/dnsdist
Re: [dnsdist] identical metrics
Hi Klaus! On 7/12/19 10:23 AM, Klaus Darilion wrote: > I think this may cause problems with later visualization tools. I think > it would be good to add an optional "name" parameter (as with newServer). Yes, I agree the current situation could be improved, I have a few ideas in mind for the next refactoring of this code. In the meantime this exact issue should have been fixed by [1] on master. [1]: https://github.com/PowerDNS/pdns/pull/7934 Best regards, -- Remi Gacogne PowerDNS.COM BV - https://www.powerdns.com/ signature.asc Description: OpenPGP digital signature ___ dnsdist mailing list dnsdist@mailman.powerdns.com https://mailman.powerdns.com/mailman/listinfo/dnsdist
[dnsdist] identical metrics
Hi!
For performance reasons (it helps a lot) I have 3 listeners:
setLocal("0.0.0.0:53", { doTCP=true, reusePort=true, tcpFastOpenSize=100 })
addLocal("0.0.0.0:53", { doTCP=true, reusePort=true, tcpFastOpenSize=100 })
addLocal("0.0.0.0:53", { doTCP=true, reusePort=true, tcpFastOpenSize=100 })
/metrics then uses the same metric name:
dnsdist_frontend_queries{frontend="0.0.0.0:53",proto="udp"} 3459
dnsdist_frontend_queries{frontend="0.0.0.0:53",proto="udp"} 3516
dnsdist_frontend_queries{frontend="0.0.0.0:53",proto="udp"} 3422
I think this may cause problems with later visualization tools. I think
it would be good to add an optional "name" parameter (as with newServer).
regards
Klaus
___
dnsdist mailing list
dnsdist@mailman.powerdns.com
https://mailman.powerdns.com/mailman/listinfo/dnsdist
