Re: [Dnsmasq-discuss] Make HighLoad constant value configurable from config.h
60 / 100 = 0.6 So yea, it is connected вс, 10 апр. 2022 г. в 14:54, Серж ИвановЪ : > Patch attached > > пт, 8 апр. 2022 г. в 17:55, Серж ИвановЪ : > >> no problem, will do, if it is acceptable to merge it, please confirm, >> thanks >> >> пт, 8 апр. 2022 г. в 17:46, Geert Stappers : >> >>> On Fri, Apr 08, 2022 at 04:34:11PM +0300, Серж ИвановЪ wrote: >>> > I am talking about this part of code in src/dhcp.c >>> > ``` >>> > struct ping_result *do_icmp_ping(time_t now, struct in_addr addr, >>> unsigned >>> > int h >>> > { >>> > static struct ping_result dummy; >>> > struct ping_result *r, *victim = NULL; >>> > int count, max = (int)(0.6 * (((float)PING_CACHE_TIME)/ >>> >((float)PING_WAIT))); >>> > ``` >>> > >>> > 0.6 should be configurable via compile-time constants, not hard-coded >>> >>> That should be expressed as a patch. >>> >>> >>> Groeten >>> Geert Stappers >>> -- >>> Silence is hard to parse >>> >> ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss
Re: [Dnsmasq-discuss] Whitelist again, git bisect
On Mon, Apr 11, 2022 at 12:45:38PM +0200, William Edwards wrote: > Kovács József via Dnsmasq-discuss schreef op 2022-04-11 13:28: > > > > I downgraded the dnsmasq from 2.86 to 2.80 and whitelist is working. > > > > What could be the difference, if the configuration files are same? > > ... > > > > Could somebody help me? > > You could help yourself by binary searching for the commit that caused the > change in behaviour ;) Use `git bisect` for it. Here a snippet from `man git bisect` Basic bisect commands: start, bad, good As an example, suppose you are trying to find the commit that broke a feature that was known to work in version v2.6.13-rc2 of your project. You start a bisect session as follows: $ git bisect start $ git bisect bad # Current version is bad $ git bisect good v2.6.13-rc2# v2.6.13-rc2 is known to be good Once you have specified at least one bad and one good commit, git bisect selects a commit in the middle of that range of history, checks it out, and outputs something similar to the following: Bisecting: 675 revisions left to test after this (roughly 10 steps) You should now compile the checked-out version and test it. If that version works correctly, type $ git bisect good If that version is broken, type $ git bisect bad > > Thank you very much, in advance! Yes, we are looking forward you reporting back. Groeten Geert Stappers P.S. @József your system clock is some hours ahead, please adjust it. -- Silence is hard to parse ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss
Re: [Dnsmasq-discuss] Whitelist again
Kovács József via Dnsmasq-discuss schreef op 2022-04-11 13:28: Hello All, I downgraded the dnsmasq from 2.86 to 2.80 and whitelist is working. What could be the difference, if the configuration files are same? These are is my configuration files: kovacsj@laptop:~# cat /tmp/cmr/ap_dnsmasq_v1p1.5.conf no-hosts except-interface=lo bind-interfaces pid-file=/var/run/dnsmasq_v1p1.5.pid dhcp-leasefile=/var/run/dnsmasq_v1p1.5.leases log-facility=/var/log/lwuci/dnsmasq_v1p1.5.log interface=v1p1.5 dhcp-range=192.168.5.11,192.168.5.91,255.255.255.0 servers-file=/tmp/cmr/filtering.conf kovacsj@laptop:~# cat /tmp/cmr/filtering.conf server=/robotszoft.hu/# server=/#/ kovacsj@laptop:~# The robotszoft.hu website is reachable, but the any others are not. This is the desired result, but in the 2.86 version, it is not working. Could somebody help me? You could help yourself by binary searching for the commit that caused the change in behaviour ;) Thank you very much, in advance! -- Üdvözlettel: Kovács József - villamosmérnök informatikus programozó PLC programozó etikus hacker Cert:ECC7512963840 Tel: +36703146459 ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss -- With kind regards, William Edwards ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss
Re: [Dnsmasq-discuss] Whitelist magic
On Mon, Apr 11, 2022 at 01:28:39PM +0200, Kovács József via Dnsmasq-discuss wrote: > Hello All, > > I downgraded the dnsmasq from 2.86 to 2.80 and whitelist is working. > > What could be the difference, if the configuration files are same? > > These are is my configuration files: > > kovacsj@laptop:~# cat /tmp/cmr/ap_dnsmasq_v1p1.5.conf > no-hosts > except-interface=lo > bind-interfaces > pid-file=/var/run/dnsmasq_v1p1.5.pid > dhcp-leasefile=/var/run/dnsmasq_v1p1.5.leases > log-facility=/var/log/lwuci/dnsmasq_v1p1.5.log > interface=v1p1.5 > dhcp-range=192.168.5.11,192.168.5.91,255.255.255.0 > servers-file=/tmp/cmr/filtering.conf > > kovacsj@laptop:~# cat /tmp/cmr/filtering.conf > server=/robotszoft.hu/# > server=/#/ > kovacsj@laptop:~# > > The robotszoft.hu website is reachable, but the any others are not. > > This is the desired result, but in the 2.86 version, it is not working. > > Could somebody help me? I tried to understand the "problem" and tried to understand the "solution", but failed. It is the > server=/#/ that I don't understand. Manual page says this about # The special server address '#' means, "use the standard servers", so --server=/google.com/1.2.3.4 --server=/www.google.com/# will send queries for google.com and its subdomains to 1.2.3.4, except www.google.com (and its subdomains) which will be forwarded as usual. > Thank you very much, in advance! Please elaborate > server=/#/ Groeten Geert Stappers -- Silence is hard to parse ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss
[Dnsmasq-discuss] Whitelist again
Hello All, I downgraded the dnsmasq from 2.86 to 2.80 and whitelist is working. What could be the difference, if the configuration files are same? These are is my configuration files: kovacsj@laptop:~# cat /tmp/cmr/ap_dnsmasq_v1p1.5.conf no-hosts except-interface=lo bind-interfaces pid-file=/var/run/dnsmasq_v1p1.5.pid dhcp-leasefile=/var/run/dnsmasq_v1p1.5.leases log-facility=/var/log/lwuci/dnsmasq_v1p1.5.log interface=v1p1.5 dhcp-range=192.168.5.11,192.168.5.91,255.255.255.0 servers-file=/tmp/cmr/filtering.conf kovacsj@laptop:~# cat /tmp/cmr/filtering.conf server=/robotszoft.hu/# server=/#/ kovacsj@laptop:~# The robotszoft.hu website is reachable, but the any others are not. This is the desired result, but in the 2.86 version, it is not working. Could somebody help me? Thank you very much, in advance! -- Üdvözlettel: Kovács József villamosmérnök informatikus programozó PLC programozó etikus hacker Cert:ECC7512963840 Tel: +36703146459___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss