Re: [Dnsmasq-discuss] dnsmasq sending advertise packets for the packet containing server id

2023-05-19 Thread Petr Menšík 
Just for pure interest, can you share what test suite are you using? Is 
that open source?


On 5/3/23 06:23, shashikumar Shashi wrote:

Hi Simon,

While validating the RFC 3315 standards through the test suite caught 
this issue.


Thanks,
Shashi

On Tue, May 2, 2023 at 4:05 AM Simon Kelley  
wrote:


On 24/04/2023 05:41, shashikumar Shashi wrote:
> Hi,
>
> I am using dnsmasq-2.80, IN this I am observing dnsmasq sending the
> advertising packets for the packet containing the Server id.
> This is a violation of the RFC -
> https://www.rfc-editor.org/rfc/rfc3315#section-15.2
> 
>
> Below is my packet:
> 0x:  0001 0002 0050 5696 5000 86dd 6000
> 0x0010:  003a 11ff fe80    0250
> 0x0020: 56ff fe96 5000 ff02    
> 0x0030:  0001 0002 0222 0223 003a ac9b 01ac
> 0x0040: 1a04 0002 0012 554e 5553 4544 2d53 4552
> 0x0050: 5645 522d 4455 4944 0001 0004 3e74 dd1b
> 0x0060: 0003 000c 6848 70e4    
>
>
> Is there any known issue??
>


Thanks for the report. I've just pushed a code change which
improves the
checking of received packets to conform better with section 15.


https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=7500157cff8ea28ab03e6e62e0d1575e4d01746b

Out of interest, did this cause problems in a real installation,
or were
you running a test suite?


Cheers,

Simon.

___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss


___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss


--
Petr Menšík
Software Engineer, RHEL
Red Hat,https://www.redhat.com/
PGP: DFCF908DB7C87E8E529925BC4931CA5B6C9FC5CB
___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss

Re: [Dnsmasq-discuss] dnsmasq sending advertise packets for the packet containing server id

2023-05-02 Thread shashikumar Shashi 
Hi Simon,

While validating the RFC 3315 standards through the test suite caught this
issue.

Thanks,
Shashi

On Tue, May 2, 2023 at 4:05 AM Simon Kelley  wrote:

> On 24/04/2023 05:41, shashikumar Shashi wrote:
> > Hi,
> >
> > I am using dnsmasq-2.80, IN this I am observing dnsmasq sending the
> > advertising packets for the packet containing the Server id.
> > This is a violation of the RFC -
> > https://www.rfc-editor.org/rfc/rfc3315#section-15.2
> > 
> >
> > Below is my packet:
> > 0x:  0001 0002 0050 5696 5000 86dd 6000
> > 0x0010:  003a 11ff fe80    0250
> > 0x0020: 56ff fe96 5000 ff02    
> > 0x0030:  0001 0002 0222 0223 003a ac9b 01ac
> > 0x0040: 1a04 0002 0012 554e 5553 4544 2d53 4552
> > 0x0050: 5645 522d 4455 4944 0001 0004 3e74 dd1b
> > 0x0060: 0003 000c 6848 70e4    
> >
> >
> > Is there any known issue??
> >
>
>
> Thanks for the report. I've just pushed a code change which improves the
> checking of received packets to conform better with section 15.
>
>
> https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=7500157cff8ea28ab03e6e62e0d1575e4d01746b
>
> Out of interest, did this cause problems in a real installation, or were
> you running a test suite?
>
>
> Cheers,
>
> Simon.
>
> ___
> Dnsmasq-discuss mailing list
> Dnsmasq-discuss@lists.thekelleys.org.uk
> https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss
>
___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss

Re: [Dnsmasq-discuss] dnsmasq sending advertise packets for the packet containing server id

2023-05-01 Thread Simon Kelley 

On 24/04/2023 05:41, shashikumar Shashi wrote:

Hi,

I am using dnsmasq-2.80, IN this I am observing dnsmasq sending the 
advertising packets for the packet containing the Server id.
This is a violation of the RFC - 
https://www.rfc-editor.org/rfc/rfc3315#section-15.2 



Below is my packet:
0x:  0001 0002 0050 5696 5000 86dd 6000
0x0010:  003a 11ff fe80    0250
0x0020: 56ff fe96 5000 ff02    
0x0030:  0001 0002 0222 0223 003a ac9b 01ac
0x0040: 1a04 0002 0012 554e 5553 4544 2d53 4552
0x0050: 5645 522d 4455 4944 0001 0004 3e74 dd1b
0x0060: 0003 000c 6848 70e4    


Is there any known issue??




Thanks for the report. I've just pushed a code change which improves the 
checking of received packets to conform better with section 15.


https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=7500157cff8ea28ab03e6e62e0d1575e4d01746b

Out of interest, did this cause problems in a real installation, or were 
you running a test suite?



Cheers,

Simon.

___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss

[Dnsmasq-discuss] dnsmasq sending advertise packets for the packet containing server id

2023-04-23 Thread shashikumar Shashi 
Hi,

I am using dnsmasq-2.80, IN this I am observing dnsmasq sending the
advertising packets for the packet containing the Server id.
This is a violation of the RFC -
https://www.rfc-editor.org/rfc/rfc3315#section-15.2

Below is my packet:
0x:  0001 0002 0050 5696 5000 86dd 6000
0x0010:  003a 11ff fe80    0250
0x0020: 56ff fe96 5000 ff02    
0x0030:  0001 0002 0222 0223 003a ac9b 01ac
0x0040: 1a04 0002 0012 554e 5553 4544 2d53 4552
0x0050: 5645 522d 4455 4944 0001 0004 3e74 dd1b
0x0060: 0003 000c 6848 70e4    


Is there any known issue??

Thanks,
Shashi
___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss