[PATCH] imapc: Accept strings in FLAGS responses

2016-03-07 Thread Richard Laager
While non-standard, the IMAP server we are replacing returns non-system
flags as strings instead of atoms.

Prior to this change, imapc would abort processing on the first message
with a string flag.
---
 src/lib-storage/index/imapc/imapc-mailbox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/lib-storage/index/imapc/imapc-mailbox.c 
b/src/lib-storage/index/imapc/imapc-mailbox.c
index c3e12d1..91333dc 100644
--- a/src/lib-storage/index/imapc/imapc-mailbox.c
+++ b/src/lib-storage/index/imapc/imapc-mailbox.c
@@ -310,7 +310,8 @@ static void imapc_untagged_fetch(const struct 
imapc_untagged_reply *reply,
t_array_init(&keywords, 8);
seen_flags = TRUE;
for (j = 0; flags_list[j].type != IMAP_ARG_EOL; j++) {
-   if (!imap_arg_get_atom(&flags_list[j], &atom))
+   if (!imap_arg_get_atom(&flags_list[j], &atom) &&
+   !imap_arg_get_string(&flags_list[j], &atom))
return;
if (atom[0] == '\\')
flags |= imap_parse_system_flag(atom);
-- 
2.1.4


Re: Dsync Header Hashing

2016-03-07 Thread Richard Laager
On 03/04/2016 08:52 AM, Timo Sirainen wrote:
> On 04 Mar 2016, at 07:47, Richard Laager  wrote:
>> Is there any way to disable the header hashing in dsync?
...
> Does the attached patch happen to work? Compiles, but untested for now.

It works with one more change on top of your patch:

diff --git a/src/doveadm/dsync/dsync-mailbox-export.c 
b/src/doveadm/dsync/dsync-mailbox-export.c
index 361cc55..0267f86 100644
--- a/src/doveadm/dsync/dsync-mailbox-export.c
+++ b/src/doveadm/dsync/dsync-mailbox-export.c
@@ -518,7 +518,7 @@ dsync_mailbox_export_init(struct mailbox *box,
p_array_init(&exporter->expunged_seqs, pool, 16);
p_array_init(&exporter->expunged_guids, pool, 16);
 
-   if (!exporter->mails_have_guids)
+   if (!exporter->mails_have_guids && !exporter->no_hdr_hashes)
exporter->wanted_headers = dsync_mail_get_hash_headers(box);
 
/* first scan transaction log and save any expunges and flag changes */

-- 
Richard


dovecot: imap-login: Panic: Trying to allocate 0 bytes

2016-03-07 Thread Ron Garret
My ISP had a hard drive crash.  After the dust settled, my dovecot installation 
started failing with the following error every time a client tries to connect:

dovecot: imap-login: Panic: Trying to allocate 0 bytes

My installation has otherwise been stable and rock-solid for years.  Both I and 
the techs at my ISP are stumped.  Any advice on how to debug this would be 
greatly appreciated.

Vital info:

[ron@vm1:/etc/dovecot]$ /usr/sbin/dovecot -n
# 1.2.15: /etc/dovecot/dovecot.conf
# OS: Linux 2.6.32-5-amd64 x86_64 Debian 6.0.10 
log_timestamp: %Y-%m-%d %H:%M:%S 
ssl_ca_file: /etc/ssl/local-certs/startssl.ca.pem
ssl_cert_file: /etc/ssl/local-certs/...
ssl_key_file: /etc/ssl/local-keys/...
login_dir: /var/run/dovecot/login
login_executable: /usr/lib/dovecot/imap-login
first_valid_uid: 100
mail_privileged_group: mail
mbox_write_locks: fcntl dotlock
auth default:
  user: postfix
  passdb:
driver: sql
args: /etc/dovecot/dovecot-sql.conf
  userdb:
driver: prefetch
  socket:
type: listen
client:
  path: /var/spool/postfix/private/auth
  mode: 432
  user: postfix
  group: postfix

I have checked the MySQL configuration and everything seems to be OK there.  In 
fact, I’ve checked everything that I know how to check, and everything seems to 
be OK.  And yet it is not working.

Many thanks,
rg


Re: segfault in imap and doveadm

2016-03-07 Thread Joe Beaubien
In order to provide more information, here is a sample output of mail.err:

Mar  7 13:37:30 mba dovecot: imap(document): Error: mdbox map
/mba_data/emails/document/storage/dovecot.map.index corrupted:
map_uid=284393 refcount too low
Mar  7 13:37:30 mba dovecot: imap(document): Fatal: master: service(imap):
child 7549 killed with signal 11 (core dumped)
Mar  7 13:37:30 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/Drafts/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 13:37:30 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/Templates/_Old/dbox-Mails/dovecot.index
reset, view is now inconsistent
Mar  7 13:37:30 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/Templates/Divers/dbox-Mails/dovecot.index
reset, view is now inconsistent
Mar  7 13:37:31 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/Sent/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 13:37:31 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/_QSW - a
verifier/dbox-Mails/dovecot.index reset, view is now inconsistent
Mar  7 13:37:31 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/Anick/dbox-Mails/dovecot.index
reset, view is now inconsistent
Mar  7 13:37:31 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/Anick/dbox-Mails/dovecot.index
reset, view is now inconsistent
Mar  7 13:37:31 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/Kristine/dbox-Mails/dovecot.index
reset, view is now inconsistent
Mar  7 13:37:31 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/PO/dbox-Mails/dovecot.index
reset, view is now inconsistent
Mar  7 13:37:31 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/Daphne/dbox-Mails/dovecot.index
reset, view is now inconsistent
Mar  7 13:37:31 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 13:37:31 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/Sent/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 13:37:31 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 13:37:31  dovecot: last message repeated 4 times
Mar  7 13:37:31 mba dovecot: imap(document): Error: mdbox map
/mba_data/emails/document/storage/dovecot.map.index corrupted:
map_uid=284393 refcount too low
Mar  7 13:37:32 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 13:37:32 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 13:37:32 mba dovecot: imap(document): Fatal: master: service(imap):
child 7561 killed with signal 11 (core dumped)
Mar  7 13:37:33 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 13:37:33 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/Sent/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 13:37:34 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 13:37:34  dovecot: last message repeated 2 times
Mar  7 13:37:34 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/Sent/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 13:37:34 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 13:38:59  dovecot: last message repeated 3 times


On Mon, Mar 7, 2016 at 12:58 PM, Joe Beaubien 
wrote:

> Hi everyone,
>
> Dovecot keeps on segfaulting on me and I am unsure why. This setup has
> been running for 5 years and has given me very little trouble.
>
> I am running Dovecot 2.1.7, setup with mdbox.
>
> The imap process keeps on segfaulting for the same account (makes me think
> maybe an email or folder of that account is problematic).
>
> My big issue is that force-resync also causes doveadm to segfault.
>
> Here is the mail.err file I am getting:
>
> Mar  7 12:34:36 mba kernel: [ 1955.486324] imap[5663]: segfault at 0 ip
> 7ff1c1bd0b5e sp 7fffd8599a40 error 4 in
> libdovecot-storage.so.0.0.0[7ff1c1b51000+fb000]
> Mar  7 12:34:36 mba dovecot: imap(document): Error:
> /mba_data/emails/document/mailboxes/INBOX/Sara/dbox-Mails/dovecot.index
> reset, view is now inconsistent
> Mar  7 12:34:36 mba dovecot: imap(document): Error:
> /mba_data/emails/document/mailboxes/INBOX/Lucie/dbox-Mails/dovecot.index
> reset, view is now inconsistent
> Mar  7 12:34:37 mba dovecot: imap(document): Error: mdbox map
> /mba_data/emails/document/st

segfault in imap and doveadm

2016-03-07 Thread Joe Beaubien
Hi everyone,

Dovecot keeps on segfaulting on me and I am unsure why. This setup has been
running for 5 years and has given me very little trouble.

I am running Dovecot 2.1.7, setup with mdbox.

The imap process keeps on segfaulting for the same account (makes me think
maybe an email or folder of that account is problematic).

My big issue is that force-resync also causes doveadm to segfault.

Here is the mail.err file I am getting:

Mar  7 12:34:36 mba kernel: [ 1955.486324] imap[5663]: segfault at 0 ip
7ff1c1bd0b5e sp 7fffd8599a40 error 4 in
libdovecot-storage.so.0.0.0[7ff1c1b51000+fb000]
Mar  7 12:34:36 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/Sara/dbox-Mails/dovecot.index
reset, view is now inconsistent
Mar  7 12:34:36 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/Lucie/dbox-Mails/dovecot.index
reset, view is now inconsistent
Mar  7 12:34:37 mba dovecot: imap(document): Error: mdbox map
/mba_data/emails/document/storage/dovecot.map.index corrupted:
map_uid=284393 refcount too low
Mar  7 12:34:37 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/Templates/dbox-Mails/dovecot.index
reset, view is now inconsistent
Mar  7 12:34:39 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/Sent/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 12:34:40 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 12:34:40 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 12:34:41 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 12:34:41 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 12:34:41 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 12:34:42 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/_EE - a
verifier/dbox-Mails/dovecot.index reset, view is now inconsistent
Mar  7 12:34:43 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/dbox-Mails/dovecot.index reset,
view is now inconsistent
Mar  7 12:34:48 mba kernel: [ 1967.972883] imap[5688]: segfault at 0 ip
7f058ebc9b5e sp 7fff9baa7c00 error 4 in
libdovecot-storage.so.0.0.0[7f058eb4a000+fb000]
Mar  7 12:34:49 mba dovecot: imap(document): Error:
/mba_data/emails/document/mailboxes/INBOX/Lucie/dbox-Mails/dovecot.index
reset, view is now inconsistent
Mar  7 12:43:44 mba dovecot: imap(document): Error: indexer disconnected
unexpectedly
Mar  7 12:43:44 mba dovecot: indexer: Error: Indexer worker disconnected,
discarding 119 requests for document
Mar  7 12:48:31 mba kernel: [ 2790.363755] doveadm[6586]: segfault at 0 ip
7f1b2023fb5e sp 7fff4e8ce200 error 4 in
libdovecot-storage.so.0.0.0[7f1b201c+fb000]
Mar  7 12:49:10 mba kernel: [ 2829.203900] doveadm[6604]: segfault at 0 ip
7fa0d16e4b5e sp 7fff1b89f480 error 4 in
libdovecot-storage.so.0.0.0[7fa0d1665000+fb000]


First line is imap segfaulting. Last lines are doveadm segfaulting when I
try to run force-resync.

Does anyone have any clue what to do in this situation?

Regards,

-Joe


Re: Compilation fails: SSL_TXT_SSLV2 not defined

2016-03-07 Thread Muffinman
On 07/03/16 17:12, aki.tu...@dovecot.fi wrote:
>> On March 7, 2016 at 6:09 PM aki.tu...@dovecot.fi wrote:
>>
>>
>>
>>> On March 7, 2016 at 5:54 PM Muffinman  wrote:
>>>
>>>
>>> Hello all,
>>>
>>> I'm trying to compile dovecot 2.2.21 on OS-X 10.11.3 and I'm running a
>>> bit of trouble with OpenSSL. I've cloned OpenSSL (OpenSSL
>>> 1.1.0-pre4-dev) from github and in openssl/ssl.h c is not
>>> defined anymore. Compilation fails with:
>>>
>>> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../src/lib
>>> -I../../src/lib-test -DMODULE_DIR=\"/usr/local/lib/dovecot\" -std=gnu99
>>> -g -O2 -Wall -W -Wmissing-prototypes -Wmissing-declarations
>>> -Wpointer-arith -Wchar-subscripts -Wformat=2 -Wbad-function-cast
>>> -Wno-duplicate-decl-specifier -Wstrict-aliasing=2 -MT
>>> iostream-openssl-common.lo -MD -MP -MF .deps/iostream-openssl-common.Tpo
>>> -c iostream-openssl-common.c  -fno-common -DPIC -o
>>> .libs/iostream-openssl-common.o
>>> iostream-openssl-common.c:34:24: error: use of undeclared identifier
>>> 'SSL_TXT_SSLV2'
>>> if (strcasecmp(name, SSL_TXT_SSLV2) == 0)
>>>  ^
>>> 1 error generated.
>>> make[3]: *** [iostream-openssl-common.lo] Error 1
>>> make[2]: *** [all-recursive] Error 1
>>> make[1]: *** [all-recursive] Error 1
>>> make: *** [all] Error 2
>>>
>>> In openssl/ssl.h the following is defined:
>>>
>>> # define SSL_TXT_SSLV3   "SSLv3"
>>> # define SSL_TXT_TLSV1   "TLSv1"
>>> # define SSL_TXT_TLSV1_1 "TLSv1.1"
>>> # define SSL_TXT_TLSV1_2 "TLSv1.2"
>>>
>>> # define SSL_TXT_ALL "ALL"
>>>
>>> Any suggestions on how to fix this?
>>>
>>> Kind regards, Maarten
>> Hi!
>>
>> Can you try the attached patch?
>>
>> ---
>> Aki Tuomi
>> Dovecot oy
> Apologies, fixed patch attached.
>
> Aki

Thanks for the fast response and patch. However, there seems to be a lot
more missing from the ssl.h header than just the 'SSL_TXT_SSLV2'
definition. I figured I might better get the latest stable instead of
the github version. Now everything compiles and runs fine (also without
the patch).

Thanks for the support!!

Kind regards, Maarten


Re: Compilation fails: SSL_TXT_SSLV2 not defined

2016-03-07 Thread aki . tuomi

> On March 7, 2016 at 6:09 PM aki.tu...@dovecot.fi wrote:
> 
> 
> 
> > On March 7, 2016 at 5:54 PM Muffinman  wrote:
> > 
> > 
> > Hello all,
> > 
> > I'm trying to compile dovecot 2.2.21 on OS-X 10.11.3 and I'm running a
> > bit of trouble with OpenSSL. I've cloned OpenSSL (OpenSSL
> > 1.1.0-pre4-dev) from github and in openssl/ssl.h SSL_TXT_SSLV2 is not
> > defined anymore. Compilation fails with:
> > 
> > libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../src/lib
> > -I../../src/lib-test -DMODULE_DIR=\"/usr/local/lib/dovecot\" -std=gnu99
> > -g -O2 -Wall -W -Wmissing-prototypes -Wmissing-declarations
> > -Wpointer-arith -Wchar-subscripts -Wformat=2 -Wbad-function-cast
> > -Wno-duplicate-decl-specifier -Wstrict-aliasing=2 -MT
> > iostream-openssl-common.lo -MD -MP -MF .deps/iostream-openssl-common.Tpo
> > -c iostream-openssl-common.c  -fno-common -DPIC -o
> > .libs/iostream-openssl-common.o
> > iostream-openssl-common.c:34:24: error: use of undeclared identifier
> > 'SSL_TXT_SSLV2'
> > if (strcasecmp(name, SSL_TXT_SSLV2) == 0)
> >  ^
> > 1 error generated.
> > make[3]: *** [iostream-openssl-common.lo] Error 1
> > make[2]: *** [all-recursive] Error 1
> > make[1]: *** [all-recursive] Error 1
> > make: *** [all] Error 2
> > 
> > In openssl/ssl.h the following is defined:
> > 
> > # define SSL_TXT_SSLV3   "SSLv3"
> > # define SSL_TXT_TLSV1   "TLSv1"
> > # define SSL_TXT_TLSV1_1 "TLSv1.1"
> > # define SSL_TXT_TLSV1_2 "TLSv1.2"
> > 
> > # define SSL_TXT_ALL "ALL"
> > 
> > Any suggestions on how to fix this?
> > 
> > Kind regards, Maarten
> 
> Hi!
> 
> Can you try the attached patch?
> 
> ---
> Aki Tuomi
> Dovecot oy

Apologies, fixed patch attached.

AkiFrom 33ca3f1cb55f732fac3e5ed653eaf14ad9a27852 Mon Sep 17 00:00:00 2001
From: Aki Tuomi 
Date: Mon, 7 Mar 2016 18:08:14 +0200
Subject: [PATCH] lib-ssl-iostream: Make SSLv2 conditional

---
 src/lib-ssl-iostream/iostream-openssl-common.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/src/lib-ssl-iostream/iostream-openssl-common.c b/src/lib-ssl-iostream/iostream-openssl-common.c
index cbdbc44..f2af263 100644
--- a/src/lib-ssl-iostream/iostream-openssl-common.c
+++ b/src/lib-ssl-iostream/iostream-openssl-common.c
@@ -31,9 +31,14 @@ int openssl_get_protocol_options(const char *protocols)
 			name++;
 			neg = TRUE;
 		}
+
+#ifdef SSL_TXT_SSLV2
 		if (strcasecmp(name, SSL_TXT_SSLV2) == 0)
 			proto = DOVECOT_SSL_PROTO_SSLv2;
 		else if (strcasecmp(name, SSL_TXT_SSLV3) == 0)
+#else
+		if  (strcasecmp(name, SSL_TXT_SSLV3) == 0)
+#endif
 			proto = DOVECOT_SSL_PROTO_SSLv3;
 		else if (strcasecmp(name, SSL_TXT_TLSV1) == 0)
 			proto = DOVECOT_SSL_PROTO_TLSv1;
-- 
1.9.1



Re: Compilation fails: SSL_TXT_SSLV2 not defined

2016-03-07 Thread aki . tuomi

> On March 7, 2016 at 5:54 PM Muffinman  wrote:
> 
> 
> Hello all,
> 
> I'm trying to compile dovecot 2.2.21 on OS-X 10.11.3 and I'm running a
> bit of trouble with OpenSSL. I've cloned OpenSSL (OpenSSL
> 1.1.0-pre4-dev) from github and in openssl/ssl.h SSL_TXT_SSLV2 is not
> defined anymore. Compilation fails with:
> 
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../src/lib
> -I../../src/lib-test -DMODULE_DIR=\"/usr/local/lib/dovecot\" -std=gnu99
> -g -O2 -Wall -W -Wmissing-prototypes -Wmissing-declarations
> -Wpointer-arith -Wchar-subscripts -Wformat=2 -Wbad-function-cast
> -Wno-duplicate-decl-specifier -Wstrict-aliasing=2 -MT
> iostream-openssl-common.lo -MD -MP -MF .deps/iostream-openssl-common.Tpo
> -c iostream-openssl-common.c  -fno-common -DPIC -o
> .libs/iostream-openssl-common.o
> iostream-openssl-common.c:34:24: error: use of undeclared identifier
> 'SSL_TXT_SSLV2'
> if (strcasecmp(name, SSL_TXT_SSLV2) == 0)
>  ^
> 1 error generated.
> make[3]: *** [iostream-openssl-common.lo] Error 1
> make[2]: *** [all-recursive] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
> 
> In openssl/ssl.h the following is defined:
> 
> # define SSL_TXT_SSLV3   "SSLv3"
> # define SSL_TXT_TLSV1   "TLSv1"
> # define SSL_TXT_TLSV1_1 "TLSv1.1"
> # define SSL_TXT_TLSV1_2 "TLSv1.2"
> 
> # define SSL_TXT_ALL "ALL"
> 
> Any suggestions on how to fix this?
> 
> Kind regards, Maarten

Hi!

Can you try the attached patch?

---
Aki Tuomi
Dovecot oyFrom 23b46652f29ef7ddb77bd0ec2bdc444b58f690b0 Mon Sep 17 00:00:00 2001
From: Aki Tuomi 
Date: Mon, 7 Mar 2016 18:08:14 +0200
Subject: [PATCH] lib-ssl-iostream: Make SSLv2 conditional

---
 src/lib-ssl-iostream/iostream-openssl-common.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/src/lib-ssl-iostream/iostream-openssl-common.c b/src/lib-ssl-iostream/iostream-openssl-common.c
index cbdbc44..4d04d5b 100644
--- a/src/lib-ssl-iostream/iostream-openssl-common.c
+++ b/src/lib-ssl-iostream/iostream-openssl-common.c
@@ -31,10 +31,15 @@ int openssl_get_protocol_options(const char *protocols)
 			name++;
 			neg = TRUE;
 		}
+
+#ifdef SSL_TXT_SSLV2
 		if (strcasecmp(name, SSL_TXT_SSLV2) == 0)
 			proto = DOVECOT_SSL_PROTO_SSLv2;
 		else if (strcasecmp(name, SSL_TXT_SSLV3) == 0)
+#else
+		if  (strcasecmp(name, SSL_TXT_SSLV3) == 0)
 			proto = DOVECOT_SSL_PROTO_SSLv3;
+#endif
 		else if (strcasecmp(name, SSL_TXT_TLSV1) == 0)
 			proto = DOVECOT_SSL_PROTO_TLSv1;
 #ifdef SSL_TXT_TLSV1_1
-- 
1.9.1



Compilation fails: SSL_TXT_SSLV2 not defined

2016-03-07 Thread Muffinman
Hello all,

I'm trying to compile dovecot 2.2.21 on OS-X 10.11.3 and I'm running a
bit of trouble with OpenSSL. I've cloned OpenSSL (OpenSSL
1.1.0-pre4-dev) from github and in openssl/ssl.h SSL_TXT_SSLV2 is not
defined anymore. Compilation fails with:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../src/lib
-I../../src/lib-test -DMODULE_DIR=\"/usr/local/lib/dovecot\" -std=gnu99
-g -O2 -Wall -W -Wmissing-prototypes -Wmissing-declarations
-Wpointer-arith -Wchar-subscripts -Wformat=2 -Wbad-function-cast
-Wno-duplicate-decl-specifier -Wstrict-aliasing=2 -MT
iostream-openssl-common.lo -MD -MP -MF .deps/iostream-openssl-common.Tpo
-c iostream-openssl-common.c  -fno-common -DPIC -o
.libs/iostream-openssl-common.o
iostream-openssl-common.c:34:24: error: use of undeclared identifier
'SSL_TXT_SSLV2'
if (strcasecmp(name, SSL_TXT_SSLV2) == 0)
 ^
1 error generated.
make[3]: *** [iostream-openssl-common.lo] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

In openssl/ssl.h the following is defined:

# define SSL_TXT_SSLV3   "SSLv3"
# define SSL_TXT_TLSV1   "TLSv1"
# define SSL_TXT_TLSV1_1 "TLSv1.1"
# define SSL_TXT_TLSV1_2 "TLSv1.2"

# define SSL_TXT_ALL "ALL"

Any suggestions on how to fix this?

Kind regards, Maarten


Re: questions regarding zlib plugin

2016-03-07 Thread Alessio Cecchi



Il 07/03/2016 16:13, Andrew McGlashan ha scritto:

Okay, I like the idea of saving messages in compressed format,
My exim4 on Debian with split config doesn't create files with the size
tag, ala:

maildir_tag = ,S=$message_size

Where should I put this to make it active for exim4 on Debian?


You should use dovecot-lda (or LMTP) to add "S=$size" to email files. I 
don't know how to do it with Exim.

--
Alessio Cecchi
Postmaster @ http://www.qboxmail.it
https://www.linkedin.com/in/alessice


Re: questions regarding zlib plugin

2016-03-07 Thread Andrew McGlashan
Hi,

On 8/03/2016 12:13 AM, Alessio Cecchi wrote:
> Il 04/03/2016 14:35, Götz Reinicke - IT Koordinator ha scritto:
>> Hi,
>>
>> faced with a current space problem on our dovecot 2.2.18 server, I
>> thought about using the zlib plugin.
>>
>> My questions:
>>
>> - is it really as simple as adding the options to the conf files as
>> described in the docs :) ? http://wiki2.dovecot.org/Plugins/Zlib
> 
> Yes, we had enable it on Maildir/ without problems.

Okay, I like the idea of saving messages in compressed format,
My exim4 on Debian with split config doesn't create files with the size
tag, ala:

   maildir_tag = ,S=$message_size

Where should I put this to make it active for exim4 on Debian?

I've tried a couple of different config locations, but I can't get it to
create new files with ,S=$message_size in the file names.

AIUI, the message size component of the file name is required to use
gzip method on files.

I've also adjusted the dovecot config due to this requirement:

   "If you want to use dsync to convert to a compressed Maildir you may
need -o maildir_copy_with_hardlinks=no (this is set to yes by default
and will prevent compression). "

Would I normally need this setting like that as well?


Kind Regards
AndrewM


Re: questions regarding zlib plugin

2016-03-07 Thread Alessio Cecchi



Il 04/03/2016 14:35, Götz Reinicke - IT Koordinator ha scritto:

Hi,

faced with a current space problem on our dovecot 2.2.18 server, I
thought about using the zlib plugin.

My questions:

- is it really as simple as adding the options to the conf files as
described in the docs :) ? http://wiki2.dovecot.org/Plugins/Zlib


Yes, we had enable it on Maildir/ without problems.


- As this just compresses new messages; dose anybody has a sort of
simple cron or whatever script or best practice how to compress existing
maildir mails? The doc is a bit complicated to me at that point...


We had created a custom script but you can find many example on the web:

https://gist.github.com/cs278/1490556

I suggest to do not use script that rename email files because they can 
invalid the uidlist. Simple check if the file is already compress (es. 
if gzip -t "${MAILFILE}" 2> /dev/null".


--
Alessio Cecchi
Postmaster @ http://www.qboxmail.it
https://www.linkedin.com/in/alessice


sis deduplication broken from 2.2.16 upwards

2016-03-07 Thread Pavel Stano
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi,

sis attachment deduplication is broken in 2.2.16 upwards.
It is caused by this commit.
https://github.com/dovecot/core/commit/664bf3e236c214aee86294483c379e4fa66c2e63

in src/lib-fs/fs-sis.c function fs_sis_try_link() is comparation of
inodes of hash files.
Because fs_stat() after that commit use fstat() on open fd of temporary
file instead of stat on filename. But that temporary file has differnt
inode.

It not cause any corruption but it will not save any space.
Because every duplicate attachment will be in separate file.

- -- 
[ Ohodnotte kvalitu mailu:
https://www.nicereply.com/websupport/4afafd34 ]

Pavel Stano | Troubleshooter

http://WebSupport.sk
*** BERTE A VYCHUTNAVAJTE ***

-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAEBAgAGBQJW3XkgAAoJEJDF0QA0DLajmJ0QAIZTFTkN0KMJDT3I/rft5Dpp
QYM6kyTVdr/FNeR200LLPjXsHXHF8hhoxkQbpfq1D9ceQO0ERDVaL6knKK7/j5Zj
EffO+ercXUkcJbE8iYRNcbdpXltUjgYYzgOha7ULiCk0VxROxcujThNTGCDHY8g/
zHXre2aW7hQ8o1yjjhITIOU5WsENSI8PbFktvvWF6OEMVwv8EnaEckJTRGwEl2fu
FEPSV+eQg6jHTs/fgiMxAbd4DSzRa2tkeOrw4l4oprtIuthU5hAi9G42Dk+IFvXk
k6imnsI6QMPhlrHCm+8Ym+8FwCv7S75JJ/iRp/sS2zHuEwvfwFcVi8pBSjeV50kZ
Z0Xglm35tFrHNLAFFb1CVnEw6ftQpuMEE7o/IYrLMVVdPB0C/1IP0s9ucKK0ccQ0
Ld9RULBo6jLgxsVodEntgtMABkfvxybut/tF3O4mm/iN0rDzlOZHMeQ+lsgcdrZd
J7h3ow/J0OYosR7CfRFLA875ue2g4GsF+FFP9/oKx/1TkHXJNXpKAhhjOCnSgxHe
h44bDrpJyYKlrCaLcOjQM4iUO0upBPpepOnJu50Fde1hNmyr4NaiHLTo23OGX/v3
kEA6xEgmTsXyr3kjhg51/0tdradqKvih2yIptmhpw8P+RWp+ceMoDX2hF95EGB8q
FGklrxdxCIoGPAZTOVyf
=imfX
-END PGP SIGNATURE-