[Dovecot] Bug in Dovecot Managesieve or Horde ?

2009-07-20 Thread Christian Felsing 
Hello,

there is a problem between Dovevot 1.2 Managesieve 0.11.7 and Horde
webmail 1.2.2 (possibly also in 1.2.3) in imap4flags

$ telnet localhost 2000
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
IMPLEMENTATION dovecot
SIEVE fileinto reject envelope encoded-character vacation subaddress
comparator-i;ascii-numeric relational regex imap4flags copy include body
variables enotify environment
SASL PLAIN LOGIN
STARTTLS
NOTIFY mailto
VERSION 1.0
OK taunusstein.net imap4/pop3 ready.

This shows imap4flags, Cyrus sieve shows imapflags instead that. Horde
Ingos does not like that and complains about missing imapflags. Two
small patches in Horde code resolves that, but I do not know if that's
the right way.

cd webmail2/ingo/lib

vi ./Script/sieve.php:

function requires()
{
//return array('imapflags');
return array('imap4flags');
}

vi ./tests/SieveTest.php:

function testBlacklistMarker()
{
$bl = new Ingo_Storage_blacklist(3);
$bl-setBlacklist(array('spam...@example.com'));
$bl-setBlacklistFolder(INGO_BLACKLIST_MARKER);

$this-store($bl);
//$this-assertScript('require imapflags;
$this-assertScript('require imap4flags;
if address :all :comparator i;ascii-casemap :is [From, Sender,
Resent-From] spam...@example.com  {
addflag Deleted;
keep;
removeflag Deleted;
stop;
}');
}


After that, Horde Ingo likes Dovecot mailsieve.

Is it a bug of mailsieve ?

Regards
Christian

Re: [Dovecot] Bug in Dovecot Managesieve or Horde ?

2009-07-20 Thread Tom Hendrikx 
Christian Felsing schreef:
 Hello,
 
 there is a problem between Dovevot 1.2 Managesieve 0.11.7 and Horde
 webmail 1.2.2 (possibly also in 1.2.3) in imap4flags
 
 $ telnet localhost 2000
 Trying 127.0.0.1...
 Connected to localhost.
 Escape character is '^]'.
 IMPLEMENTATION dovecot
 SIEVE fileinto reject envelope encoded-character vacation subaddress
 comparator-i;ascii-numeric relational regex imap4flags copy include body
 variables enotify environment
 SASL PLAIN LOGIN
 STARTTLS
 NOTIFY mailto
 VERSION 1.0
 OK taunusstein.net imap4/pop3 ready.
 
 This shows imap4flags, Cyrus sieve shows imapflags instead that. Horde
 Ingos does not like that and complains about missing imapflags. Two
 small patches in Horde code resolves that, but I do not know if that's
 the right way.
 
 cd webmail2/ingo/lib
 
 vi ./Script/sieve.php:
 
 function requires()
 {
 //return array('imapflags');
 return array('imap4flags');
 }
 
 vi ./tests/SieveTest.php:
 
 function testBlacklistMarker()
 {
 $bl = new Ingo_Storage_blacklist(3);
 $bl-setBlacklist(array('spam...@example.com'));
 $bl-setBlacklistFolder(INGO_BLACKLIST_MARKER);
 
 $this-store($bl);
 //$this-assertScript('require imapflags;
 $this-assertScript('require imap4flags;
 if address :all :comparator i;ascii-casemap :is [From, Sender,
 Resent-From] spam...@example.com  {
 addflag Deleted;
 keep;
 removeflag Deleted;
 stop;
 }');
 }
 
 
 After that, Horde Ingo likes Dovecot mailsieve.
 
 Is it a bug of mailsieve ?

http://wiki.dovecot.org/LDA/Sieve/Dovecot#migration

I guess Horde should be updated to handle different implementations of
Sieve. In the mean time, you could add the following line to your config
to enable the old flag (see wiki page for more info):

sieve_extensions = +imapflags


Regards,
Tom



signature.asc
Description: OpenPGP digital signature

Re: [Dovecot] Bug in Dovecot Managesieve or Horde ?

2009-07-20 Thread Thomas 

Hi,


there is a problem between Dovevot 1.2 Managesieve 0.11.7 and Horde
webmail 1.2.2 (possibly also in 1.2.3) in imap4flags


sieve_extensions = +imapflags will enable the deprecated imapflags
extension in addition to all extensions enabled by default.
http://wiki.dovecot.org/LDA/Sieve/Dovecot

Cheers,
Thomas

Re: [Dovecot] Bug in Dovecot Managesieve or Horde ?

2009-07-20 Thread Christian Felsing 
Hi Tom,

thank you for that hint, before RTFM FTFM (find the  manual) is the
problem ;-)
Obviously a better solution. My patch would be the Horde approach.

Reagards
Christian

Tom Hendrikx schrieb:

 I guess Horde should be updated to handle different implementations of