Re: [Dovecot] null errors from 2.0.beta5

2010-06-11 Thread Timo Sirainen 
On to, 2010-06-10 at 00:02 -0500, Mike Abbott wrote:
 When my dovecot-2.0.beta5 auth module logs a 552-byte debug message, the 
 message is split into two lines and also a null error message:
 Wed Jun  9 23:44:29 gromit dovecot[58892]: auth: Error: 
 
 I think this has to do with the use of PIPE_BUF (512) sized buffers in the 
 logging code, and the !line_is_ok() case in i_failure_parse_line().

Related to PIPE_BUF, yes, but problem was in the sending part. Fixed:
http://hg.dovecot.org/dovecot-2.0/rev/5ede18fe35fa

BTW. Is OSX's PIPE_BUF really only 512 bytes (instead of just the
#define being set too low)? In Linux it's 4096.

Re: [Dovecot] null errors from 2.0.beta5

2010-06-11 Thread Mike Abbott 
 Related to PIPE_BUF, yes, but problem was in the sending part. Fixed:
 http://hg.dovecot.org/dovecot-2.0/rev/5ede18fe35fa

Yes, that fixes it.  Thanks.

 Is OSX's PIPE_BUF really only 512 bytes

Yes.

[Dovecot] null errors from 2.0.beta5

2010-06-09 Thread Mike Abbott 
When my dovecot-2.0.beta5 auth module logs a 552-byte debug message, the 
message is split into two lines and also a null error message:
Wed Jun  9 23:44:29 gromit dovecot[58892]: auth: Error: 

I think this has to do with the use of PIPE_BUF (512) sized buffers in the 
logging code, and the !line_is_ok() case in i_failure_parse_line().

Could you please remove the null error message?  Just a nuisance, nothing 
serious.  Thanks.