Re: [Dovecot] Crash in pop3 with version 2.2.12
Le 4 avr. 2014 à 10:37, Teemu Huovila a écrit : > Hello > > On 04/04/2014 11:18 AM, Axel Luttgens wrote: >> I'm still wondering... under which circumstances could the crash occur? > This issue occurs whenever the function > src/pop3/pop3-commands.c:client_uidls_save() is called. > The function is called when: > > The pop3 internal structure client->message_uidls_save is 1. This in turn > happens when any of these is true: > 1. pop3 logoutformat has %u > 2. config setting pop3_uidl_duplicates is not the default "allow" > 3. config setting pop3_save_uidl=yes > > The problem manifests in two different ways. > 1) When the zlib plugin is active the executable crashed due to a > segmentation fault. > 2) If there is no zlib, the data returned by the UIDL command is "off-by-one" > and the last data item is null. > > Without zlib the error might look something like this: > C:uidl > S:+OK > S:1 0002533553b6 > S:2 0003533553b6 > S:3 0004533553b6 > S:4 0005533553b6 > S:5 0006533553b6 > S:6 (null) > S:. > >> Hence the question: to patch or not to patch? > Patch, if your setup will need to meet any of the three criteria triggering > the issue, before 2.2.13 is released. Hello Teemu, Thank you very much for your kind and very detailed explanation. None of 1. to 3. apply here, so I guess I've just been lucky. On the other hand, I didn't notice that the patch applies to a very precise context (the client_uidls_save function); it should thus be safe to apply it in all cases (even if un-needed with some *current* configuration). Sincerely, Axel
Re: [Dovecot] Crash in pop3 with version 2.2.12
Hello On 04/04/2014 11:18 AM, Axel Luttgens wrote: > I'm still wondering... under which circumstances could the crash occur? This issue occurs whenever the function src/pop3/pop3-commands.c:client_uidls_save() is called. The function is called when: The pop3 internal structure client->message_uidls_save is 1. This in turn happens when any of these is true: 1. pop3 logoutformat has %u 2. config setting pop3_uidl_duplicates is not the default "allow" 3. config setting pop3_save_uidl=yes The problem manifests in two different ways. 1) When the zlib plugin is active the executable crashed due to a segmentation fault. 2) If there is no zlib, the data returned by the UIDL command is "off-by-one" and the last data item is null. Without zlib the error might look something like this: C:uidl S:+OK S:1 0002533553b6 S:2 0003533553b6 S:3 0004533553b6 S:4 0005533553b6 S:5 0006533553b6 S:6 (null) S:. > Hence the question: to patch or not to patch? Patch, if your setup will need to meet any of the three criteria triggering the issue, before 2.2.13 is released. br, Teemu Huovila
Re: [Dovecot] Crash in pop3 with version 2.2.12
On 4/4/2014 11:18 πμ, Axel Luttgens wrote: I'm still wondering... under which circumstances could the crash occur? I was wondering the same thing. We are now running 2.2.12 in production for two weeks (unpatched) and we have not seen such an error (despite extensive use of POP3). Regards, Nick
Re: [Dovecot] Crash in pop3 with version 2.2.12
Le 28 mars 2014 à 17:12, Urban Loesch a écrit : > Hi, > > thanks for your fast help. > Now pop3 works again without error. > > Thanks > Urban > > > Am 28.03.2014 15:03, schrieb Teemu Huovila: >> Thats my bad. This commit should fix it >> http://hg.dovecot.org/dovecot-2.2/rev/b0359910ec96. Thanks for reporting it. >> >> Teemu Huovila Hello, I'm still wondering... under which circumstances could the crash occur? Trying here to reproduce it with an unpatched 2.2.12, without "success": LIST and UIDL always return consistent results, without crashes, and behave that way on several mailboxes. I'm asking, because the problem could thus be tied to some configurations/settings only (as Urban wrote: "I saw some people on the list [...]"); but the correction brought by b0359910ec96 is an unconditional one. On the other hand, the problem might be raised because of some particular combination of circumstances, which I can't reproduce now, but which I could face one day or another... Hence the question: to patch or not to patch? Many thanks in advance, Axel
Re: [Dovecot] Crash in pop3 with version 2.2.12
Hi, thanks for your fast help. Now pop3 works again without error. Thanks Urban Am 28.03.2014 15:03, schrieb Teemu Huovila: > Thats my bad. This commit should fix it > http://hg.dovecot.org/dovecot-2.2/rev/b0359910ec96. Thanks for reporting it. > > Teemu Huovila >
Re: [Dovecot] Crash in pop3 with version 2.2.12
Thats my bad. This commit should fix it http://hg.dovecot.org/dovecot-2.2/rev/b0359910ec96. Thanks for reporting it. Teemu Huovila
