Re: [Dovecot] Dovecot 2.0.beta3 managesieve sig11 (was: Re: Dovecot 2.0.beta3: Child killed with signal 11)

[Timo Sirainen]

On Sun, 2010-02-28 at 18:34 +, Bernhard Schmidt wrote:

  And managesieve segfaults immediately at TCP connect, but I have not
  managed to get a backtrace yet (it always says core not dumped
  regardless of ulimit -c setting. I also added -D to the executable, but
  no core file yet)
 
  Feb 28 17:18:07 mail dovecot: master: service(managesieve-login): child
  1168 killed with signal 11 (core not dumped)

Attached patch probably helps?

diff -r 4830b8741bf0 src/managesieve-login/client.c
--- a/src/managesieve-login/client.c	Sat Feb 13 12:48:32 2010 +0100
+++ b/src/managesieve-login/client.c	Sun Feb 28 21:24:23 2010 +0200
@@ -34,6 +34,7 @@
 
 void login_process_preinit(void)
 {
+	login_set_roots = managesieve_login_settings_set_roots;
 }
 
 /* Skip incoming data until newline is found,
@@ -392,7 +393,6 @@
 
 void clients_init(void)
 {
-	login_set_roots = managesieve_login_settings_set_roots;
 }
 
 void clients_deinit(void)


signature.asc
Description: This is a digitally signed message part

Re: [Dovecot] Dovecot 2.0.beta3 managesieve sig11

[Bernhard Schmidt]

On 28.02.2010 20:24, Timo Sirainen wrote:

On Sun, 2010-02-28 at 18:34 +, Bernhard Schmidt wrote:


And managesieve segfaults immediately at TCP connect, but I have not
managed to get a backtrace yet (it always says core not dumped
regardless of ulimit -c setting. I also added -D to the executable, but
no core file yet)

Feb 28 17:18:07 mail dovecot: master: service(managesieve-login): child
1168 killed with signal 11 (core not dumped)


Attached patch probably helps?


It does indeed, thank you very much.

The Thunderbird Sieve plugin is dead-slow with the new version on TLS 
connection setup (and doesn't work at all when you don't disable a Cyrus 
TLS workaround in it), but that needs more debugging.


Bernhard