Re: [Dovecot] Vacation messages come from POSTMASTER, not user

2012-11-28 Thread Colin Fowler

On 26/11/12 20:17, Stephan Bosch wrote:

On 11/26/2012 6:31 PM, cfowler wrote:

Problem : All vacation autoreplies come from the postmaster address.
Expected behavior : vacation notice comes from the user who set the 
vacation.
Platform : Dovecot 2.1.7 on Debian Squeeze ( See below for example 
reply, sieve script and dovecot -n output)


Any help appreciated!


This should fix that:

http://hg.rename-it.nl/dovecot-2.1-pigeonhole/rev/b56711807edc

Regards,

Stephan.



Sorry for the late reply. I've been off work sick :(
Excellent Work Stephan! Thank you so much. do you know if this patch 
will make it into 2.1.11?


regards,
Colin



Re: [Dovecot] Vacation messages come from POSTMASTER, not user

2012-11-26 Thread Ben Morrow
At  6PM + on 26/11/12 you (cfowler) wrote:
> On 26-11-2012 17:59, Ben Morrow wrote:
> > At  5PM + on 26/11/12 you (cfowler) wrote:
> >> Problem : All vacation autoreplies come from the postmaster address.
> >> Expected behavior : vacation notice comes from the user who set the
> >> vacation.
> >> Platform : Dovecot 2.1.7 on Debian Squeeze ( See below for example
> >> reply, sieve script and dovecot -n output)
> > 
> >
> >>sieve_vacation_dont_check_recipient = yes
> >
> > Why have you set this? Normally vacation will refuse to respond to a
> > message which doesn't have your address in one of the recipient
> > header fields; in fact the standard says that it MUST NOT respond
> > unless this is the case.

(Stephan has explained that I am wrong here: that's what comes from
reading the code rather than running it...)

> This feature is the reason I've upgraded to 2.1.7 from 1.2.15
> 
> Our users have addresses like bmor...@foo.com
> We also store aliases for them in LDAP like ben.mor...@foo.com. Postfix 
> knows of these aliases and accepts mail for them. Most of our users 
> prefer to hand out this alias as their email address
> 
> Mails to bmor...@foo.com were receiving vacation auto-replies as you'd 
> expect in 1.2.15
> Mails to ben.mor...@foo.com were not due to the infamous "discarding 
> vacation response for message implicitly delivered to bmor...@foo.com" 
> message.
> 
> I know the correct behavior is for the users to write a correct sieve 
> script with an addresses: line, but that's not going to happen 
> unfortunately. The users just want "Push button to make vacation go".

I see... this is a little tricky, yes, and I think you're right this is
the only straightforward solution at the moment. You do want to be a
little careful about enabling this, though: the restriction is there in
the standard to prevent automated replies from being sent for messages
to mailing lists and group aliases and such, where the sender does not
(and should not) know the list of final delivery addresses, and
certainly doesn't want vacation replies from all of them. Since most
mailing lists now set the List-* headers (which prevent vacation replies
anyway), they should be OK, so this is probably only a problem if you
use internal aliases which expand to lists of users.

Ideally pigeonhole would take advantage of this paragraph in the
standard

An email address is considered to belong to the recipient if it is
one of:

   1.  an email address known by the implementation to be associated
   with the recipient,

and allow you to specify a dict in which to lookup a default :addresses
list for each recipient. That way you could turn this parameter back
off, but instead give Dovecot the information it needs to determine that
a message To:  was in fact directly addressed to
this user. I wonder how difficult that would be...

> > If you send a message with the user's email address in To:, do you 
> > get a
> > vacation response From: the correct address?
> >
> 
> No, mails to bmor...@foo.com also get Postmaster replies.
> With 1.2.15 we were at least getting autoreplies from bmor...@foo.com 
> when a mail was sent to bmor...@foo.com.

Stephan said xthread that this has now been fixed.

Ben



Re: [Dovecot] Vacation messages come from POSTMASTER, not user

2012-11-26 Thread Stephan Bosch

On 11/26/2012 6:59 PM, Ben Morrow wrote:

At  5PM + on 26/11/12 you (cfowler) wrote:



This setting turns that check off, in which case Pigeonhole
will send a vacation response (despite the standard) but sends it from
Postmaster.


Actually, this shouldn't have happened. Originally, it would only use 
'Postmaster' when the recipient address is unknown, but that situation 
would never occur. With the addition of the dont_check_recipient 
setting, this got changed unintentionally.



I assume this is done for privacy reasons, since the person
the vacation response is being sent to doesn't necessarily know the user
who set the vacation exists, or what their address might be.


Interesting notion, but the real reason is of a more stupid nature as 
explained above. :) Do you think this is something people would want to 
configure? Since this particular feature deviates from the standard to 
begin with, nothing is specified about what should be done.  I think the 
added anonymity would often be useless, because the content of the 
vacation message can contain all sorts of information on the recipient, 
including the mail address, e.g. in the signature.



If you send a message with the user's email address in To:, do you get a
vacation response From: the correct address?


Since the recipient check is not performed, the recipient address used 
for the reply remained NULL and the reply code would revert to 
Postmaster at all times. This is fixed now.


Regards,

Stephan.




Re: [Dovecot] Vacation messages come from POSTMASTER, not user

2012-11-26 Thread Stephan Bosch

On 11/26/2012 6:31 PM, cfowler wrote:

Problem : All vacation autoreplies come from the postmaster address.
Expected behavior : vacation notice comes from the user who set the 
vacation.
Platform : Dovecot 2.1.7 on Debian Squeeze ( See below for example 
reply, sieve script and dovecot -n output)


Any help appreciated!


This should fix that:

http://hg.rename-it.nl/dovecot-2.1-pigeonhole/rev/b56711807edc

Regards,

Stephan.



Re: [Dovecot] Vacation messages come from POSTMASTER, not user

2012-11-26 Thread cfowler

On 26-11-2012 17:59, Ben Morrow wrote:

At  5PM + on 26/11/12 you (cfowler) wrote:

Problem : All vacation autoreplies come from the postmaster address.
Expected behavior : vacation notice comes from the user who set the
vacation.
Platform : Dovecot 2.1.7 on Debian Squeeze ( See below for example
reply, sieve script and dovecot -n output)




   sieve_vacation_dont_check_recipient = yes


Why have you set this? Normally vacation will refuse to respond to a
message which doesn't have your address in one of the recipient 
header
fields; in fact the standard says that it MUST NOT respond unless 
this
is the case. This setting turns that check off, in which case 
Pigeonhole
will send a vacation response (despite the standard) but sends it 
from
Postmaster. I assume this is done for privacy reasons, since the 
person
the vacation response is being sent to doesn't necessarily know the 
user

who set the vacation exists, or what their address might be.



This feature is the reason I've upgraded to 2.1.7 from 1.2.15

Our users have addresses like bmor...@foo.com
We also store aliases for them in LDAP like ben.mor...@foo.com. Postfix 
knows of these aliases and accepts mail for them. Most of our users 
prefer to hand out this alias as their email address


Mails to bmor...@foo.com were receiving vacation auto-replies as you'd 
expect in 1.2.15
Mails to ben.mor...@foo.com were not due to the infamous "discarding 
vacation response for message implicitly delivered to bmor...@foo.com" 
message.


I know the correct behavior is for the users to write a correct sieve 
script with an addresses: line, but that's not going to happen 
unfortunately. The users just want "Push button to make vacation go".


If you send a message with the user's email address in To:, do you 
get a

vacation response From: the correct address?



No, mails to bmor...@foo.com also get Postmaster replies.
With 1.2.15 we were at least getting autoreplies from bmor...@foo.com 
when a mail was sent to bmor...@foo.com.



Ben


Re: [Dovecot] Vacation messages come from POSTMASTER, not user

2012-11-26 Thread Ben Morrow
At  5PM + on 26/11/12 you (cfowler) wrote:
> Problem : All vacation autoreplies come from the postmaster address.
> Expected behavior : vacation notice comes from the user who set the 
> vacation.
> Platform : Dovecot 2.1.7 on Debian Squeeze ( See below for example 
> reply, sieve script and dovecot -n output)


>sieve_vacation_dont_check_recipient = yes

Why have you set this? Normally vacation will refuse to respond to a
message which doesn't have your address in one of the recipient header
fields; in fact the standard says that it MUST NOT respond unless this
is the case. This setting turns that check off, in which case Pigeonhole
will send a vacation response (despite the standard) but sends it from
Postmaster. I assume this is done for privacy reasons, since the person
the vacation response is being sent to doesn't necessarily know the user
who set the vacation exists, or what their address might be.

If you send a message with the user's email address in To:, do you get a
vacation response From: the correct address?

Ben



Re: [Dovecot] Vacation messages come from POSTMASTER, not user

2012-11-26 Thread Robert Schetterer
Am 26.11.2012 18:31, schrieb cfowler:
> Problem : All vacation autoreplies come from the postmaster address.

<> is not really the postmaster address, its special for the mailer daemon

> Expected behavior : vacation notice comes from the user who set the
> vacation.

at my knowledge, does not work that way ,yet,
guess what you want, might work with invoking external script via sieve

wait for other responses , special stefan might give better answer about
sieve


> Platform : Dovecot 2.1.7 on Debian Squeeze ( See below for example
> reply, sieve script and dovecot -n output)
> 
> Any help appreciated!
> 
> 
> 
> 
> 
> Sieve script used:
> 
> if true
> {
> vacation :days 2 :subject "Out of Office" "I am currently out of the
> office";
> stop;
> }
> 
> 
> 
> 
> Return-Path: <>
> X-Original-To: tests...@mydomain.com
> Delivered-To: tests...@mydomain.com
> Received: from localhost (localhost [127.0.0.1])
> by quicksilver.mydomain.com (Postfix) with ESMTP id 12591BE16
> for ; Mon, 26 Nov 2012 16:54:16 + (GMT)



Best Regards
MfG Robert Schetterer

-- 
[*] sys4 AG

http://sys4.de, +49 (89) 30 90 46 64
Franziskanerstraße 15, 81669 München

Sitz der Gesellschaft: München, Amtsgericht München: HRB 199263
Vorstand: Patrick Ben Koetter, Axel von der Ohe, Marc Schiffbauer
Aufsichtsratsvorsitzender: Joerg Heidrich