Re: Phyr Starter
On Thu, Jan 20, 2022 at 02:56:02PM +0100, Christoph Hellwig wrote: > - on the input side to dma mapping the bio_vecs (or phyrs) are chained >as bios or whatever the containing structure is. These already exist >and have infrastructure at least in the block layer > - on the output side I plan for two options: > > 1) we have a sane IOMMU and everyting will be coalesced into a > single dma_range. This requires setting the block layer > merge boundary to match the IOMMU page size, but that is > a very good thing to do anyway. It doesn't look like IOMMU page sizes are exported, or even necessarily consistently sized on at least one arch (power).
Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;
On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: > diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c > index eea0f453cfb6..8aac5bc60f4c 100644 > --- a/crypto/tcrypt.c > +++ b/crypto/tcrypt.c > @@ -2464,7 +2464,7 @@ static int do_test(const char *alg, u32 type, u32 mask, > int m, u32 num_mb) > test_hash_speed("streebog512", sec, > generic_hash_speed_template); > if (mode > 300 && mode < 400) break; > - fallthrough; > + break; > case 399: > break; Just imho, this change makes the preceding 'if' look even more pointless. Maybe the fallthrough was a deliberate choice? Not that my opinion matters here as I don't know this module, but it looked a bit odd to me. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 26/34] mm/gup_benchmark.c: convert put_page() to put_user_page*()
On Thu, Aug 01, 2019 at 07:19:57PM -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). > > Cc: Dan Carpenter > Cc: Greg Kroah-Hartman > Cc: Keith Busch > Cc: Kirill A. Shutemov > Cc: Michael S. Tsirkin > Cc: YueHaibing > Signed-off-by: John Hubbard Looks fine. Reviewed-by: Keith Busch > mm/gup_benchmark.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/gup_benchmark.c b/mm/gup_benchmark.c > index 7dd602d7f8db..515ac8eeb6ee 100644 > --- a/mm/gup_benchmark.c > +++ b/mm/gup_benchmark.c > @@ -79,7 +79,7 @@ static int __gup_benchmark_ioctl(unsigned int cmd, > for (i = 0; i < nr_pages; i++) { > if (!pages[i]) > break; > - put_page(pages[i]); > + put_user_page(pages[i]); > } > end_time = ktime_get(); > gup->put_delta_usec = ktime_us_delta(end_time, start_time); > -- ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel