RE: [kbuild-all] [RFC PATCH] drm/vkms: vkms_driver can be static

[Li, Philip]

> Subject: Re: [kbuild-all] [RFC PATCH] drm/vkms: vkms_driver can be static
> 
> On Tue, May 15, 2018 at 07:30:52PM +0800, kbuild test robot wrote:
> >
> > Fixes: 58d8108f080c ("drm/vkms: Introduce basic VKMS driver")
> > Signed-off-by: Fengguang Wu 
> 
> One thing I noticed while applying this: Your author (as recorded in the
> From: line) and your s-o-b don't match. Now I know that you're behind
> 0day, so it's ok, but our script gets annoyed and I need to overrule it
> with an -f flag.
> 
> Can you perhaps get the From: and S-o-b: lines into agreement so that a
> simple comparison works?
thanks for input, we the bot team has decided to use uniform From with the
address lkp recently, while the auto generated script is still using specific 
author's
signed-off-by.

> 
> Thanks, Daniel
> 
> > ---
> >  vkms_drv.c |2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c
> b/drivers/gpu/drm/vkms/vkms_drv.c
> > index b1df08e..35517b09 100644
> > --- a/drivers/gpu/drm/vkms/vkms_drv.c
> > +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> > @@ -40,7 +40,7 @@ static void vkms_release(struct drm_device *dev)
> > drm_dev_fini(>drm);
> >  }
> >
> > -struct drm_driver vkms_driver = {
> > +static struct drm_driver vkms_driver = {
> > .driver_features= DRIVER_MODESET | DRIVER_ATOMIC |
> DRIVER_GEM,
> > .release= vkms_release,
> > .fops   = _driver_fops,
> 
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> ___
> kbuild-all mailing list
> kbuild-...@lists.01.org
> https://lists.01.org/mailman/listinfo/kbuild-all
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: [kbuild-all] [PATCH] drm: fix drm-get-put.cocci warnings

[Li, Philip]

> Subject: Re: [kbuild-all] [PATCH] drm: fix drm-get-put.cocci warnings
> 
> On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote:
> > From: Fengguang Wu 
> >
> >  Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and
> >  drm_*_unreference() helpers.
> >
> > Generated by: scripts/coccinelle/api/drm-get-put.cocci
> >
> > Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver")
> > Signed-off-by: Fengguang Wu 
> > Signed-off-by: Julia Lawall 
> > ---
> >
> > tree:   https://github.com/shenki/linux drm-v1
> 
> This isn't an upstream tree (and the aspeed driver isn't in upstream
> afaict), so no need for spamming mailing lists I think.
thanks for feedback Daniel, we will mark this repo as private one to avoid
reporting to larger mailing list.

> 
> But thanks for doing all this, great motivation to put more of the drm
> refactorings into cocci files.
> 
> Cheers, Daniel
> > head:   9680ed7979d5d403c6bde36271a048d62c048180
> > commit: 6784ac15bc6889280522b04b97f1fb1208ee45e7 [23/27] drm: Add
> ASPEED
> > GFX
> > driver
> >
> >  aspeed_gfx_drv.c |4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> > @@ -268,7 +268,7 @@ static int aspeed_gfx_probe(struct platf
> >  err_unload:
> > aspeed_gfx_unload(drm);
> >  err_free:
> > -   drm_dev_unref(drm);
> > +   drm_dev_put(drm);
> >
> > return ret;
> >  }
> > @@ -279,7 +279,7 @@ static int aspeed_gfx_remove(struct plat
> >
> > drm_dev_unregister(drm);
> > aspeed_gfx_unload(drm);
> > -   drm_dev_unref(drm);
> > +   drm_dev_put(drm);
> >
> > return 0;
> >  }
> > ___
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> ___
> kbuild-all mailing list
> kbuild-...@lists.01.org
> https://lists.01.org/mailman/listinfo/kbuild-all
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel