[Nouveau] nouveau lockdep splat
On 03/20/2013 07:29 PM, Borislav Petkov wrote: > On Wed, Mar 20, 2013 at 07:23:19PM +0400, Lijo Antony wrote: >> # bad: [fffddfd6c8e0c10c42c6e2cc54ba880fcc36ebbb] Merge branch >> 'drm-next' of git://people.freedesktop.org/~airlied/linux >> git bisect bad fffddfd6c8e0c10c42c6e2cc54ba880fcc36ebbb > > This is a merge commit which means something went wrong along the way of > the bisection. > Looks like this has been fixed in -rc4. -lijo
Re: [Nouveau] nouveau lockdep splat
On 03/20/2013 07:29 PM, Borislav Petkov wrote: On Wed, Mar 20, 2013 at 07:23:19PM +0400, Lijo Antony wrote: # bad: [fffddfd6c8e0c10c42c6e2cc54ba880fcc36ebbb] Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux git bisect bad fffddfd6c8e0c10c42c6e2cc54ba880fcc36ebbb This is a merge commit which means something went wrong along the way of the bisection. Looks like this has been fixed in -rc4. -lijo ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [Nouveau] nouveau lockdep splat
On 03/20/2013 12:40 AM, Peter Hurley wrote: with the hope of having the right people on CC now (finally, thanks Lucas :-)), here's the same splat on -rc3. Someone better take a look soonish, please: Also happens in next (on nv50 hardware). I think this is same as https://lkml.org/lkml/2013/3/16/143 (btw, git bisect in that mail is incorrect). While investigating, I found this issue was introduced during 3.9 merge window. For me this comes when I connect my TV via HDMI. But for a couple of tags during bisecting, I have seen the same during boot also. -lijo ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [Nouveau] nouveau lockdep splat
On 03/20/2013 10:35 AM, Lijo Antony wrote: I think this is same as https://lkml.org/lkml/2013/3/16/143 (btw, git bisect in that mail is incorrect). While investigating, I found this issue was introduced during 3.9 merge window. For me this comes when I connect my TV via HDMI. FWIW, git bisect gave this log, git bisect start 'drivers/gpu/' # good: [e450fcc6669705ef49784080ac6dd8513df37763] drm/tegra: Add list of framebuffers to debugfs git bisect good e450fcc6669705ef49784080ac6dd8513df37763 # bad: [6dbe51c251a327e012439c4772097a13df43c5b8] Linux 3.9-rc1 git bisect bad 6dbe51c251a327e012439c4772097a13df43c5b8 # good: [bab588fcfb6335c767d811a8955979f5440328e0] Merge tag 'soc' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc git bisect good bab588fcfb6335c767d811a8955979f5440328e0 # good: [be88298b0a3f771a4802f20c5e66af74bfd1dff1] drm/tilcdc: only build on arm git bisect good be88298b0a3f771a4802f20c5e66af74bfd1dff1 # bad: [4d53233a36fdda567cd4d080e27e1ee4b669ddd1] drm: don't use idr_remove_all() git bisect bad 4d53233a36fdda567cd4d080e27e1ee4b669ddd1 # good: [9afa3195b96da7d2320ec44d19fbfbded7a15571] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial git bisect good 9afa3195b96da7d2320ec44d19fbfbded7a15571 # good: [496ad9aa8ef448058e36ca7a787c61f2e63f0f54] new helper: file_inode(file) git bisect good 496ad9aa8ef448058e36ca7a787c61f2e63f0f54 # bad: [d895cb1af15c04c522a25c79cc429076987c089b] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs git bisect bad d895cb1af15c04c522a25c79cc429076987c089b # bad: [fffddfd6c8e0c10c42c6e2cc54ba880fcc36ebbb] Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux git bisect bad fffddfd6c8e0c10c42c6e2cc54ba880fcc36ebbb -lijo ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Nouveau] nouveau lockdep splat
On 03/20/2013 10:35 AM, Lijo Antony wrote: > I think this is same as https://lkml.org/lkml/2013/3/16/143 (btw, git > bisect in that mail is incorrect). While investigating, I found this > issue was introduced during 3.9 merge window. For me this comes when I > connect my TV via HDMI. FWIW, git bisect gave this log, git bisect start 'drivers/gpu/' # good: [e450fcc6669705ef49784080ac6dd8513df37763] drm/tegra: Add list of framebuffers to debugfs git bisect good e450fcc6669705ef49784080ac6dd8513df37763 # bad: [6dbe51c251a327e012439c4772097a13df43c5b8] Linux 3.9-rc1 git bisect bad 6dbe51c251a327e012439c4772097a13df43c5b8 # good: [bab588fcfb6335c767d811a8955979f5440328e0] Merge tag 'soc' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc git bisect good bab588fcfb6335c767d811a8955979f5440328e0 # good: [be88298b0a3f771a4802f20c5e66af74bfd1dff1] drm/tilcdc: only build on arm git bisect good be88298b0a3f771a4802f20c5e66af74bfd1dff1 # bad: [4d53233a36fdda567cd4d080e27e1ee4b669ddd1] drm: don't use idr_remove_all() git bisect bad 4d53233a36fdda567cd4d080e27e1ee4b669ddd1 # good: [9afa3195b96da7d2320ec44d19fbfbded7a15571] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial git bisect good 9afa3195b96da7d2320ec44d19fbfbded7a15571 # good: [496ad9aa8ef448058e36ca7a787c61f2e63f0f54] new helper: file_inode(file) git bisect good 496ad9aa8ef448058e36ca7a787c61f2e63f0f54 # bad: [d895cb1af15c04c522a25c79cc429076987c089b] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs git bisect bad d895cb1af15c04c522a25c79cc429076987c089b # bad: [fffddfd6c8e0c10c42c6e2cc54ba880fcc36ebbb] Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux git bisect bad fffddfd6c8e0c10c42c6e2cc54ba880fcc36ebbb -lijo
[Nouveau] nouveau lockdep splat
On 03/20/2013 12:40 AM, Peter Hurley wrote: >> >> with the hope of having the right people on CC now (finally, thanks >> Lucas :-)), here's the same splat on -rc3. Someone better take a look >> soonish, please: > > Also happens in next (on nv50 hardware). I think this is same as https://lkml.org/lkml/2013/3/16/143 (btw, git bisect in that mail is incorrect). While investigating, I found this issue was introduced during 3.9 merge window. For me this comes when I connect my TV via HDMI. But for a couple of tags during bisecting, I have seen the same during boot also. -lijo
Re: [3.9.0-rc2] nouveau deadlock when HDMI TV is connected
On 03/16/2013 10:29 PM, Lijo Antony wrote: But looking at 65b5f42e2a9eb9c8383fb67698bf8c27657f8c14, it looks I might have done some mistake in bisecting. My bisecting was indeed incorrect. Issue started even before 3.9.0-rc1. Attempting a proper bisect this time... -lijo ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[3.9.0-rc2] nouveau deadlock when HDMI TV is connected
On 03/16/2013 10:29 PM, Lijo Antony wrote: > > But looking at 65b5f42e2a9eb9c8383fb67698bf8c27657f8c14, it looks I > might have done some mistake in bisecting. My bisecting was indeed incorrect. Issue started even before 3.9.0-rc1. Attempting a proper bisect this time... -lijo
[3.9.0-rc2] nouveau deadlock when HDMI TV is connected
Hi,
This is a Dell Inspiron N5110 laptop with Optimus mess.
Until 3.9.0-rc1, tv connected throuh HDMI was not getting detected. But
in 3.9.0-rc2, when I connect HDMI cable, I get this,
=
[ INFO: possible recursive locking detected ]
3.9.0-rc2 #22 Not tainted
-
kworker/0:1/54 is trying to acquire lock:
(>lock){+.+...}, at: [] evo_wait+0x43/0xf0
[nouveau]
but task is already holding lock:
(>lock){+.+...}, at: [] evo_wait+0x43/0xf0
[nouveau]
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0
lock(>lock);
lock(>lock);
*** DEADLOCK ***
May be due to missing lock nesting notation
5 locks held by kworker/0:1/54:
#0: (events){.+.+.+}, at: []
process_one_work+0x171/0x4c0
#1: ((_connector->hpd_work)){+.+.+.}, at: []
process_one_work+0x171/0x4c0
#2: (>mode_config.mutex){+.+.+.}, at: []
drm_modeset_lock_all+0x2a/0x70 [drm]
#3: (>mutex){+.+.+.}, at: []
drm_modeset_lock_all+0x54/0x70 [drm]
#4: (>lock){+.+...}, at: []
evo_wait+0x43/0xf0 [nouveau]
stack backtrace:
Pid: 54, comm: kworker/0:1 Not tainted 3.9.0-rc2 #22
Call Trace:
[] __lock_acquire+0x715/0x1be0
[] ? dcb_table+0x1ac/0x2a0 [nouveau]
[] lock_acquire+0xa1/0x130
[] ? evo_wait+0x43/0xf0 [nouveau]
[] ? mutex_lock_nested+0x299/0x340
[] mutex_lock_nested+0x49/0x340
[] ? evo_wait+0x43/0xf0 [nouveau]
[] ? mark_held_locks+0xaf/0x110
[] evo_wait+0x43/0xf0 [nouveau]
[] nv50_display_flip_next+0x713/0x7a0 [nouveau]
[] ? mutex_unlock+0xe/0x10
[] ? evo_kick+0x37/0x40 [nouveau]
[] nv50_crtc_commit+0x10e/0x230 [nouveau]
[] drm_crtc_helper_set_mode+0x365/0x510 [drm_kms_helper]
[] drm_crtc_helper_set_config+0xa4e/0xb70
[drm_kms_helper]
[] drm_mode_set_config_internal+0x31/0x70 [drm]
[] drm_fb_helper_set_par+0x71/0xf0 [drm_kms_helper]
[] ? drm_modeset_unlock_all+0x52/0x60 [drm]
[] drm_fb_helper_hotplug_event+0x81/0xb0
[drm_kms_helper]
[] nouveau_fbcon_output_poll_changed+0x1c/0x20 [nouveau]
[] drm_kms_helper_hotplug_event+0x2b/0x40
[drm_kms_helper]
[] drm_helper_hpd_irq_event+0x12a/0x140 [drm_kms_helper]
[] nouveau_connector_hotplug_work+0x93/0x100 [nouveau]
[] process_one_work+0x1d1/0x4c0
[] ? process_one_work+0x171/0x4c0
[] worker_thread+0x10f/0x380
[] ? busy_worker_rebind_fn+0xb0/0xb0
[] kthread+0xea/0xf0
[] ? kthread_create_on_node+0x160/0x160
[] ret_from_fork+0x7c/0xb0
[] ? kthread_create_on_node+0x160/0x160
This is consistent and git bisect pointed at,
65b5f42e2a9eb9c8383fb67698bf8c27657f8c14 is the first bad commit
commit 65b5f42e2a9eb9c8383fb67698bf8c27657f8c14
Author: Ben Skeggs
Date: Wed Feb 20 16:47:44 2013 +1000
drm/nve0/graph: some random reg moved on kepler
Signed-off-by: Ben Skeggs
:04 04 9658d1fd413b8797fe06fb2ca8ce681d4dbbedb0
c5b38586625718fc78c0eb062af3baa201fe2e7f M drivers
65b5f42e2a9eb9c8383fb67698bf8c27657f8c14
commit 65b5f42e2a9eb9c8383fb67698bf8c27657f8c14
Author: Ben Skeggs
Date: Wed Feb 20 16:47:44 2013 +1000
drm/nve0/graph: some random reg moved on kepler
Signed-off-by: Ben Skeggs
diff --git a/drivers/gpu/drm/nouveau/core/engine/graph/nve0.c
b/drivers/gpu/drm/nouveau/core/engine/graph/nve0.c
index 61cec0f..4857f91 100644
--- a/drivers/gpu/drm/nouveau/core/engine/graph/nve0.c
+++ b/drivers/gpu/drm/nouveau/core/engine/graph/nve0.c
@@ -350,7 +350,7 @@ nve0_graph_init_gpc_0(struct nvc0_graph_priv *priv)
nv_wr32(priv, GPC_UNIT(gpc, 0x0918), magicgpc918);
}
- nv_wr32(priv, GPC_BCAST(0x1bd4), magicgpc918);
+ nv_wr32(priv, GPC_BCAST(0x3fd4), magicgpc918);
nv_wr32(priv, GPC_BCAST(0x08ac), nv_rd32(priv, 0x100800));
}
But looking at 65b5f42e2a9eb9c8383fb67698bf8c27657f8c14, it looks I
might have done some mistake in bisecting. I will try again later.
Please let me know, if you need more info.
-lijo
git bisect log
--
# bad: [f6161aa153581da4a3867a2d1a7caf4be19b6ec9] Linux 3.9-rc2
git bisect bad f6161aa153581da4a3867a2d1a7caf4be19b6ec9
# good: [6dbe51c251a327e012439c4772097a13df43c5b8] Linux 3.9-rc1
git bisect good 6dbe51c251a327e012439c4772097a13df43c5b8
# good: [f40ebd6bcbbd0d30591f42dc16be52b5086a366b] drm/i915: Turn off
hsync and vsync on ADPA when disabling crt
git bisect good f40ebd6bcbbd0d30591f42dc16be52b5086a366b
# bad: [2cc79544bd0aabb4b3cf467ead5df526d9134c64] Merge branch
'drm-intel-fixes' of git://people.freedesktop.org/~danvet/drm-intel into
drm-next
git bisect bad 2cc79544bd0aabb4b3cf467ead5df526d9134c64
# bad: [f6853faa85793bf23b46787e4039824d275453c2] drm/nouveau: Fix typo
in init_idx_addr_latched().
git bisect bad f6853faa85793bf23b46787e4039824d275453c2
# bad: [650e1203c11354ba84d69ba445abc0efcfe3890a] drm/nouveau: Disable
AGP on PowerPC again.
git bisect bad 650e1203c11354ba84d69ba445abc0efcfe3890a
# bad: [65b5f42e2a9eb9c8383fb67698bf8c27657f8c14] drm/nve0/graph: some
[PATCH] drm/nouveau/core: fix spelling mistake in comment
Signed-off-by: Lijo Antony --- drivers/gpu/drm/nouveau/core/core/client.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/core/core/client.c b/drivers/gpu/drm/nouveau/core/core/client.c index 295c221..d0f6b9d 100644 --- a/drivers/gpu/drm/nouveau/core/core/client.c +++ b/drivers/gpu/drm/nouveau/core/core/client.c @@ -69,7 +69,7 @@ nouveau_client_create_(const char *name, u64 devname, const char *cfg, if (ret) return ret; - /* prevent init/fini being called, os in in charge of this */ + /* prevent init/fini being called, os is in charge of this */ atomic_set(_object(client)->usecount, 2); nouveau_object_ref(device, >device); -- 1.7.10.4
[PATCH] drm/nouveau/core: fix spelling mistake in comment
Signed-off-by: Lijo Antony lijo.ker...@gmail.com --- drivers/gpu/drm/nouveau/core/core/client.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/core/core/client.c b/drivers/gpu/drm/nouveau/core/core/client.c index 295c221..d0f6b9d 100644 --- a/drivers/gpu/drm/nouveau/core/core/client.c +++ b/drivers/gpu/drm/nouveau/core/core/client.c @@ -69,7 +69,7 @@ nouveau_client_create_(const char *name, u64 devname, const char *cfg, if (ret) return ret; - /* prevent init/fini being called, os in in charge of this */ + /* prevent init/fini being called, os is in charge of this */ atomic_set(nv_object(client)-usecount, 2); nouveau_object_ref(device, client-device); -- 1.7.10.4 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
