Re: [Intel-gfx] [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring
On Thu, Apr 11, 2013 at 08:14:10PM +0200, Daniel Vetter wrote: > > I've just tracked down and fixed an bug which can lead to a hard-hang > in the crtc restore code (which is used both in the lid handler when > opening and on resume). If you could please test this patch (on top of > drm-intel-nightly): > > https://patchwork.kernel.org/patch/2428971/ Now I can confirm this works fine, with no warnings, errors, or freezes. Thanks, Richard ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Intel-gfx] [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring
On Thu, Apr 11, 2013 at 08:14:10PM +0200, Daniel Vetter wrote: > > I've just tracked down and fixed an bug which can lead to a hard-hang > in the crtc restore code (which is used both in the lid handler when > opening and on resume). If you could please test this patch (on top of > drm-intel-nightly): > > https://patchwork.kernel.org/patch/2428971/ Now I can confirm this works fine, with no warnings, errors, or freezes. Thanks, Richard
[Intel-gfx] [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring
On Thu, Apr 11, 2013 at 08:14:10PM +0200, Daniel Vetter wrote: > > I've just tracked down and fixed an bug which can lead to a hard-hang > in the crtc restore code (which is used both in the lid handler when > opening and on resume). If you could please test this patch (on top of > drm-intel-nightly): > > https://patchwork.kernel.org/patch/2428971/ Okay, will do. > >> I'll quickly port the patch (in it's latest v3 version) to 3.9-rc > >> kernels for you to test. FWIW, this does work, no freeze, no warning, but instead: Apr 11 20:30:49 netboy laptop-mode: Laptop mode Apr 11 20:30:49 netboy laptop-mode: enabled, Apr 11 20:30:49 netboy laptop-mode: not active [unchanged] Apr 11 20:30:53 netboy kernel: [ 75.450783] [drm:i9xx_crtc_mode_set] *ERROR* Couldn't find PLL settings for mode! Apr 11 20:30:53 netboy laptop-mode: Laptop mode Apr 11 20:30:53 netboy laptop-mode: enabled, Apr 11 20:30:53 netboy laptop-mode: not active [unchanged] Thanks, Richard
[Intel-gfx] [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring
On Wed, Apr 10, 2013 at 10:03:25PM +0200, Daniel Vetter wrote: > That patch should crash at all, so this is not expected. Can you pls > check whether plain drm-intel-nightly is broken, too? I did try drm-intel-nightly just now (1dd83e3), and it also freezes the machine. I first verified that the power button shutdown is working (before starting X). Then, with X running, closing and reopening the lid results in a blank screen (no backlight) and a seemingly frozen box. > I'll quickly port the patch (in it's latest v3 version) to 3.9-rc > kernels for you to test. Okay, I'll try this next. Thanks, Richard
Re: [Intel-gfx] [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring
On Thu, Apr 11, 2013 at 08:14:10PM +0200, Daniel Vetter wrote: > > I've just tracked down and fixed an bug which can lead to a hard-hang > in the crtc restore code (which is used both in the lid handler when > opening and on resume). If you could please test this patch (on top of > drm-intel-nightly): > > https://patchwork.kernel.org/patch/2428971/ Okay, will do. > >> I'll quickly port the patch (in it's latest v3 version) to 3.9-rc > >> kernels for you to test. FWIW, this does work, no freeze, no warning, but instead: Apr 11 20:30:49 netboy laptop-mode: Laptop mode Apr 11 20:30:49 netboy laptop-mode: enabled, Apr 11 20:30:49 netboy laptop-mode: not active [unchanged] Apr 11 20:30:53 netboy kernel: [ 75.450783] [drm:i9xx_crtc_mode_set] *ERROR* Couldn't find PLL settings for mode! Apr 11 20:30:53 netboy laptop-mode: Laptop mode Apr 11 20:30:53 netboy laptop-mode: enabled, Apr 11 20:30:53 netboy laptop-mode: not active [unchanged] Thanks, Richard ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [Intel-gfx] [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring
On Wed, Apr 10, 2013 at 10:03:25PM +0200, Daniel Vetter wrote: > That patch should crash at all, so this is not expected. Can you pls > check whether plain drm-intel-nightly is broken, too? I did try drm-intel-nightly just now (1dd83e3), and it also freezes the machine. I first verified that the power button shutdown is working (before starting X). Then, with X running, closing and reopening the lid results in a blank screen (no backlight) and a seemingly frozen box. > I'll quickly port the patch (in it's latest v3 version) to 3.9-rc > kernels for you to test. Okay, I'll try this next. Thanks, Richard ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring
On Wed, Apr 10, 2013 at 02:07:24PM +0200, Daniel Vetter wrote: > > It's written against drm-intel-next-queued at > > http://cgit.freedesktop.org/~danvet/drm-intel > > I've thought that it should apply pretty cleanly against older kernels, > too. Apparently it conflicts a bit in intel_modeset_setup_hw_state, you > can just do the s/intel_crtc_restore_mode/__intel_set_mode/ change > manually. I couldn't see right away how to fix it up, so I just compiled your drm-intel-next-queued plus this patch. If I close the netbook's lid and open it again, the screen is blank, no backlight, and the machine seems to be frozen. I think I can live with the warning. Thanks anyhow, Richard ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/i915: don't check inconsistent modeset state when force-restoring
On Wed, Apr 10, 2013 at 02:07:24PM +0200, Daniel Vetter wrote: > > It's written against drm-intel-next-queued at > > http://cgit.freedesktop.org/~danvet/drm-intel > > I've thought that it should apply pretty cleanly against older kernels, > too. Apparently it conflicts a bit in intel_modeset_setup_hw_state, you > can just do the s/intel_crtc_restore_mode/__intel_set_mode/ change > manually. I couldn't see right away how to fix it up, so I just compiled your drm-intel-next-queued plus this patch. If I close the netbook's lid and open it again, the screen is blank, no backlight, and the machine seems to be frozen. I think I can live with the warning. Thanks anyhow, Richard
[PATCH] drm/i915: don't check inconsistent modeset state when force-restoring
On Tue, Apr 09, 2013 at 09:51:30PM +0200, Daniel Vetter wrote: > It will be only consistent once we've restored all the crtcs. Since a > bunch of other callers also want to just restore a single crtc, add a > boolean to disable checking only where it doesn't make sense. > > Note that intel_modeset_setup_hw_state already has a call to > intel_modeset_check_state at the end, so we don't reduce the amount of > checking. > > v2: Try harder not to create a big patch (Chris). To what does tree does this patch apply? Tried v3.8.6 and master d02a9a89. Thanks, Richard
Re: [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring
On Tue, Apr 09, 2013 at 09:51:30PM +0200, Daniel Vetter wrote: > It will be only consistent once we've restored all the crtcs. Since a > bunch of other callers also want to just restore a single crtc, add a > boolean to disable checking only where it doesn't make sense. > > Note that intel_modeset_setup_hw_state already has a call to > intel_modeset_check_state at the end, so we don't reduce the amount of > checking. > > v2: Try harder not to create a big patch (Chris). To what does tree does this patch apply? Tried v3.8.6 and master d02a9a89. Thanks, Richard ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
drm/i915: new warning (regression) in 3.7.10 and 3.8.3
On Tue, Apr 09, 2013 at 02:50:03PM +0200, Daniel Vetter wrote: > > This should be fixed with the above mentioned patch. The issue is that the > bios fumbles around with the output configuration behind our backs, so the > new paranoid modeset code in 3.7+ freaks out about the state mismatch > between sw and hw. > > The patch above should detect this situation and undo any bios-induced > damage. Even with the patch, I still am seeing the issue (in 3.8). Thanks, Richard
Re: Re: drm/i915: new warning (regression) in 3.7.10 and 3.8.3
On Tue, Apr 09, 2013 at 02:50:03PM +0200, Daniel Vetter wrote: > > This should be fixed with the above mentioned patch. The issue is that the > bios fumbles around with the output configuration behind our backs, so the > new paranoid modeset code in 3.7+ freaks out about the state mismatch > between sw and hw. > > The patch above should detect this situation and undo any bios-induced > damage. Even with the patch, I still am seeing the issue (in 3.8). Thanks, Richard ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: drm/i915: new warning (regression) in 3.7.10 and 3.8.3
On Mon, Mar 18, 2013 at 09:32:51AM +0100, Daniel Vetter wrote: > > Another pesky BIOS which changes the display state behind our back on lid > closing! Should be duct-tapped over with > > commit 45e2b5f640b3766da3eda48f6c35f088155c06f3 > Author: Daniel Vetter > Date: Fri Nov 23 18:16:34 2012 +0100 > > drm/i915: force restore on lid open > > which is in 3.8. But that warning was from a 3.8.3 kernel. Any other ideas? Thanks, Richard ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
drm/i915: new warning (regression) in 3.7.10 and 3.8.3
On Mon, Mar 18, 2013 at 09:32:51AM +0100, Daniel Vetter wrote: > > Another pesky BIOS which changes the display state behind our back on lid > closing! Should be duct-tapped over with > > commit 45e2b5f640b3766da3eda48f6c35f088155c06f3 > Author: Daniel Vetter > Date: Fri Nov 23 18:16:34 2012 +0100 > > drm/i915: force restore on lid open > > which is in 3.8. But that warning was from a 3.8.3 kernel. Any other ideas? Thanks, Richard
drm/i915: new warning (regression) in 3.7.10 and 3.8.3
I have an Acer Aspire One netbook, and on it I get the following warning when closing and opening the lid. I think this warning first appeared in 3.7. Does this need fixing? If so, who can do it? Thanks, Richard ** close lid Mar 16 11:32:03 netboy kernel: [ 287.429404] [drm:i9xx_crtc_mode_set] *ERROR* Couldn't find PLL settings for mode! Mar 16 11:32:03 netboy kernel: [ 287.429440] [ cut here ] Mar 16 11:32:03 netboy kernel: [ 287.429526] WARNING: at /home/richard/git/linux/drivers/gpu/drm/i915/intel_display.c:7877 intel_modeset_check_state+0x2f8/0x452 [i915]() Mar 16 11:32:03 netboy kernel: [ 287.429537] Hardware name: AOD257 Mar 16 11:32:03 netboy kernel: [ 287.429548] encoder's hw state doesn't match sw tracking (expected 1, found 0) Mar 16 11:32:03 netboy kernel: [ 287.429556] Modules linked in: mmc_block bluetooth crc16 cpufreq_stats cpufreq_userspace cpufreq_powersave cpufreq_conservative uinput fuse loop snd_hda_codec_realtek joydev arc4 iwldvm snd_hda_intel snd_hda_codec snd_hwdep snd_pcm_oss snd_mixer_oss snd_pcm mac80211 i915 snd_timer snd iwlwifi cfg80211 tpm_tis psmouse serio_raw drm_kms_helper tpm i2c_i801 soundcore evdev hid_generic drm i2c_algo_bit video pcspkr tpm_bios i2c_core ehci_pci snd_page_alloc acpi_cpufreq mperf battery ac rfkill wmi processor button ext3 jbd mbcache sd_mod crc_t10dif usbhid hid rtsx_pci_sdmmc mmc_core ahci libahci libata scsi_mod uhci_hcd ehci_hcd usbcore usb_common thermal thermal_sys rtsx_pci mfd_core r8169 mii Mar 16 11:32:03 netboy kernel: [ 287.429771] Pid: 34, comm: kworker/0:1 Not tainted 3.8.3 #74 Mar 16 11:32:03 netboy kernel: [ 287.429781] Call Trace: Mar 16 11:32:03 netboy kernel: [ 287.429808] [] ? warn_slowpath_common+0x6a/0x7b Mar 16 11:32:03 netboy kernel: [ 287.429882] [] ? intel_modeset_check_state+0x2f8/0x452 [i915] Mar 16 11:32:03 netboy kernel: [ 287.429904] [] ? warn_slowpath_fmt+0x28/0x2c Mar 16 11:32:03 netboy kernel: [ 287.429975] [] ? intel_modeset_check_state+0x2f8/0x452 [i915] Mar 16 11:32:03 netboy kernel: [ 287.430017] [] ? intel_set_mode+0x61a/0x6aa [i915] Mar 16 11:32:03 netboy kernel: [ 287.430162] [] ? intel_set_mode+0x654/0x6aa [i915] Mar 16 11:32:03 netboy kernel: [ 287.430290] [] ? intel_modeset_setup_hw_state+0x5e0/0x70a [i915] Mar 16 11:32:03 netboy kernel: [ 287.430386] [] ? intel_lid_notify+0x7a/0x8a [i915] Mar 16 11:32:03 netboy kernel: [ 287.430409] [] ? notifier_call_chain+0x23/0x46 Mar 16 11:32:03 netboy kernel: [ 287.430449] [] ? __blocking_notifier_call_chain+0x39/0x4c Mar 16 11:32:03 netboy kernel: [ 287.430470] [] ? blocking_notifier_call_chain+0x9/0xc Mar 16 11:32:03 netboy kernel: [ 287.430500] [] ? acpi_lid_send_state+0x7d/0xa0 [button] Mar 16 11:32:03 netboy kernel: [ 287.430532] [] ? acpi_button_notify+0x2b/0x95 [button] Mar 16 11:32:03 netboy kernel: [ 287.430557] [] ? acpi_device_notify+0xf/0x11 Mar 16 11:32:03 netboy kernel: [ 287.430578] [] ? acpi_ev_notify_dispatch+0x2b/0x42 Mar 16 11:32:03 netboy kernel: [ 287.430597] [] ? acpi_os_execute_deferred+0x18/0x21 Mar 16 11:32:03 netboy kernel: [ 287.430617] [] ? process_one_work+0x1b1/0x27e Mar 16 11:32:03 netboy kernel: [ 287.430637] [] ? worker_thread+0x115/0x203 Mar 16 11:32:03 netboy kernel: [ 287.430656] [] ? process_one_work+0x27e/0x27e Mar 16 11:32:03 netboy kernel: [ 287.430672] [] ? kthread+0x8d/0x92 Mar 16 11:32:03 netboy kernel: [ 287.430691] [] ? ret_from_kernel_thread+0x1b/0x28 Mar 16 11:32:03 netboy kernel: [ 287.430707] [] ? kthread_freezable_should_stop+0x4b/0x4b Mar 16 11:32:03 netboy kernel: [ 287.430720] ---[ end trace 4a7da2dcc2431943 ]--- ** open lid Mar 16 11:32:03 netboy kernel: [ 287.430746] [ cut here ] Mar 16 11:32:03 netboy kernel: [ 287.430849] WARNING: at /home/richard/git/linux/drivers/gpu/drm/i915/intel_display.c:7911 intel_modeset_check_state+0x3f3/0x452 [i915]() Mar 16 11:32:03 netboy kernel: [ 287.430889] Hardware name: AOD257 Mar 16 11:32:03 netboy kernel: [ 287.430928] crtc's computed active state doesn't match tracked active state (expected 1, found 0) Mar 16 11:32:03 netboy kernel: [ 287.430964] Modules linked in: mmc_block bluetooth crc16 cpufreq_stats cpufreq_userspace cpufreq_powersave cpufreq_conservative uinput fuse loop snd_hda_codec_realtek joydev arc4 iwldvm snd_hda_intel snd_hda_codec snd_hwdep snd_pcm_oss snd_mixer_oss snd_pcm mac80211 i915 snd_timer snd iwlwifi cfg80211 tpm_tis psmouse serio_raw drm_kms_helper tpm i2c_i801 soundcore evdev hid_generic drm i2c_algo_bit video pcspkr tpm_bios i2c_core ehci_pci snd_page_alloc acpi_cpufreq mperf battery ac rfkill wmi processor button ext3 jbd mbcache sd_mod crc_t10dif usbhid hid rtsx_pci_sdmmc mmc_core ahci libahci libata scsi_mod uhci_hcd ehci_hcd usbcore usb_common thermal thermal_sys rtsx_pci mfd_core r8169 mii Mar 16 11:32:03 netboy kernel: [ 287.431233] Pid: 34, comm: kworker/0:1 Tainted: GW3
drm/i915: new warning (regression) in 3.7.10 and 3.8.3
I have an Acer Aspire One netbook, and on it I get the following warning when closing and opening the lid. I think this warning first appeared in 3.7. Does this need fixing? If so, who can do it? Thanks, Richard ** close lid Mar 16 11:32:03 netboy kernel: [ 287.429404] [drm:i9xx_crtc_mode_set] *ERROR* Couldn't find PLL settings for mode! Mar 16 11:32:03 netboy kernel: [ 287.429440] [ cut here ] Mar 16 11:32:03 netboy kernel: [ 287.429526] WARNING: at /home/richard/git/linux/drivers/gpu/drm/i915/intel_display.c:7877 intel_modeset_check_state+0x2f8/0x452 [i915]() Mar 16 11:32:03 netboy kernel: [ 287.429537] Hardware name: AOD257 Mar 16 11:32:03 netboy kernel: [ 287.429548] encoder's hw state doesn't match sw tracking (expected 1, found 0) Mar 16 11:32:03 netboy kernel: [ 287.429556] Modules linked in: mmc_block bluetooth crc16 cpufreq_stats cpufreq_userspace cpufreq_powersave cpufreq_conservative uinput fuse loop snd_hda_codec_realtek joydev arc4 iwldvm snd_hda_intel snd_hda_codec snd_hwdep snd_pcm_oss snd_mixer_oss snd_pcm mac80211 i915 snd_timer snd iwlwifi cfg80211 tpm_tis psmouse serio_raw drm_kms_helper tpm i2c_i801 soundcore evdev hid_generic drm i2c_algo_bit video pcspkr tpm_bios i2c_core ehci_pci snd_page_alloc acpi_cpufreq mperf battery ac rfkill wmi processor button ext3 jbd mbcache sd_mod crc_t10dif usbhid hid rtsx_pci_sdmmc mmc_core ahci libahci libata scsi_mod uhci_hcd ehci_hcd usbcore usb_common thermal thermal_sys rtsx_pci mfd_core r8169 mii Mar 16 11:32:03 netboy kernel: [ 287.429771] Pid: 34, comm: kworker/0:1 Not tainted 3.8.3 #74 Mar 16 11:32:03 netboy kernel: [ 287.429781] Call Trace: Mar 16 11:32:03 netboy kernel: [ 287.429808] [] ? warn_slowpath_common+0x6a/0x7b Mar 16 11:32:03 netboy kernel: [ 287.429882] [] ? intel_modeset_check_state+0x2f8/0x452 [i915] Mar 16 11:32:03 netboy kernel: [ 287.429904] [] ? warn_slowpath_fmt+0x28/0x2c Mar 16 11:32:03 netboy kernel: [ 287.429975] [] ? intel_modeset_check_state+0x2f8/0x452 [i915] Mar 16 11:32:03 netboy kernel: [ 287.430017] [] ? intel_set_mode+0x61a/0x6aa [i915] Mar 16 11:32:03 netboy kernel: [ 287.430162] [] ? intel_set_mode+0x654/0x6aa [i915] Mar 16 11:32:03 netboy kernel: [ 287.430290] [] ? intel_modeset_setup_hw_state+0x5e0/0x70a [i915] Mar 16 11:32:03 netboy kernel: [ 287.430386] [] ? intel_lid_notify+0x7a/0x8a [i915] Mar 16 11:32:03 netboy kernel: [ 287.430409] [] ? notifier_call_chain+0x23/0x46 Mar 16 11:32:03 netboy kernel: [ 287.430449] [] ? __blocking_notifier_call_chain+0x39/0x4c Mar 16 11:32:03 netboy kernel: [ 287.430470] [] ? blocking_notifier_call_chain+0x9/0xc Mar 16 11:32:03 netboy kernel: [ 287.430500] [] ? acpi_lid_send_state+0x7d/0xa0 [button] Mar 16 11:32:03 netboy kernel: [ 287.430532] [] ? acpi_button_notify+0x2b/0x95 [button] Mar 16 11:32:03 netboy kernel: [ 287.430557] [] ? acpi_device_notify+0xf/0x11 Mar 16 11:32:03 netboy kernel: [ 287.430578] [] ? acpi_ev_notify_dispatch+0x2b/0x42 Mar 16 11:32:03 netboy kernel: [ 287.430597] [] ? acpi_os_execute_deferred+0x18/0x21 Mar 16 11:32:03 netboy kernel: [ 287.430617] [] ? process_one_work+0x1b1/0x27e Mar 16 11:32:03 netboy kernel: [ 287.430637] [] ? worker_thread+0x115/0x203 Mar 16 11:32:03 netboy kernel: [ 287.430656] [] ? process_one_work+0x27e/0x27e Mar 16 11:32:03 netboy kernel: [ 287.430672] [] ? kthread+0x8d/0x92 Mar 16 11:32:03 netboy kernel: [ 287.430691] [] ? ret_from_kernel_thread+0x1b/0x28 Mar 16 11:32:03 netboy kernel: [ 287.430707] [] ? kthread_freezable_should_stop+0x4b/0x4b Mar 16 11:32:03 netboy kernel: [ 287.430720] ---[ end trace 4a7da2dcc2431943 ]--- ** open lid Mar 16 11:32:03 netboy kernel: [ 287.430746] [ cut here ] Mar 16 11:32:03 netboy kernel: [ 287.430849] WARNING: at /home/richard/git/linux/drivers/gpu/drm/i915/intel_display.c:7911 intel_modeset_check_state+0x3f3/0x452 [i915]() Mar 16 11:32:03 netboy kernel: [ 287.430889] Hardware name: AOD257 Mar 16 11:32:03 netboy kernel: [ 287.430928] crtc's computed active state doesn't match tracked active state (expected 1, found 0) Mar 16 11:32:03 netboy kernel: [ 287.430964] Modules linked in: mmc_block bluetooth crc16 cpufreq_stats cpufreq_userspace cpufreq_powersave cpufreq_conservative uinput fuse loop snd_hda_codec_realtek joydev arc4 iwldvm snd_hda_intel snd_hda_codec snd_hwdep snd_pcm_oss snd_mixer_oss snd_pcm mac80211 i915 snd_timer snd iwlwifi cfg80211 tpm_tis psmouse serio_raw drm_kms_helper tpm i2c_i801 soundcore evdev hid_generic drm i2c_algo_bit video pcspkr tpm_bios i2c_core ehci_pci snd_page_alloc acpi_cpufreq mperf battery ac rfkill wmi processor button ext3 jbd mbcache sd_mod crc_t10dif usbhid hid rtsx_pci_sdmmc mmc_core ahci libahci libata scsi_mod uhci_hcd ehci_hcd usbcore usb_common thermal thermal_sys rtsx_pci mfd_core r8169 mii Mar 16 11:32:03 netboy kernel: [ 287.431233] Pid: 34, comm: kworker/0:1 Tainted: GW3
